From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"baruch@tkos.co.il" <baruch@tkos.co.il>,
"dafna.hirschfeld@collabora.com" <dafna.hirschfeld@collabora.com>,
Jacky Bai <ping.bai@nxp.com>,
"ccaione@baylibre.com" <ccaione@baylibre.com>,
"agx@sigxcpu.org" <agx@sigxcpu.org>,
"angus@akkea.ca" <angus@akkea.ca>, Peng Fan <peng.fan@nxp.com>,
Gary Bisson <gary.bisson@boundarydevices.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
Richard Hu <richard.hu@technexion.com>,
Abel Vesa <abel.vesa@nxp.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"jon@solid-run.com" <jon@solid-run.com>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"andradanciu1997@gmail.com" <andradanciu1997@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Troy Kisky <troy.kisky@boundarydevices.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
Andy Duan <fugang.duan@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Jun Li <jun.li@nxp.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to board DT
Date: Mon, 28 Oct 2019 11:15:00 +0800 [thread overview]
Message-ID: <20191028031459.GI16985@dragon> (raw)
In-Reply-To: <DB3PR0402MB3916A2258E1E8B4690CC1B7DF5660@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On Mon, Oct 28, 2019 at 01:29:32AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > On Wed, Oct 16, 2019 at 10:14:23AM +0800, Anson Huang wrote:
> > > usdhc's clock rate is different according to different devices
> > > connected, so clock rate assignment should be placed in board DT
> > > according to different devices connected on each usdhc port.
> >
> > I think it should be fine that we have a reasonable default settings in soc.dtsi,
> > and boards that need a different setup can overwrite the settings in
> > board.dts.
>
> Someone was complaining about the usdhc clock assignment in soc.dtsi, because some
> usdhc nodes are having clock assignments while some are NOT. That is why I did this
> patch set. I agree that we can have default settings in soc.dtsi, so do you think it makes
> sense to add default clock assignment to all usdhc nodes? If yes, I will redo the patch
> set.
I had a second thought on this. To ease the maintenance of soc.dtsi,
let's do clock assignments in board.dts.
Series applied, thanks.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Jun Li <jun.li@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"ccaione@baylibre.com" <ccaione@baylibre.com>,
Abel Vesa <abel.vesa@nxp.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"jon@solid-run.com" <jon@solid-run.com>,
"baruch@tkos.co.il" <baruch@tkos.co.il>,
"angus@akkea.ca" <angus@akkea.ca>, "pavel@ucw.cz" <pavel@ucw.cz>,
"agx@sigxcpu.org" <agx@sigxcpu.org>,
Troy Kisky <troy.kisky@boundarydevices.com>,
Gary Bisson <gary.bisson@boundarydevices.com>,
"dafna.hirschfeld@collabora.com" <dafna.hirschfeld@collabora.com>,
Richard Hu <richard.hu@technexion.com>,
"andradanciu1997@gmail.com" <andradanciu1997@gmail.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
Aisheng Dong <aisheng.dong@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Andy Duan <fugang.duan@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to board DT
Date: Mon, 28 Oct 2019 11:15:00 +0800 [thread overview]
Message-ID: <20191028031459.GI16985@dragon> (raw)
In-Reply-To: <DB3PR0402MB3916A2258E1E8B4690CC1B7DF5660@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On Mon, Oct 28, 2019 at 01:29:32AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > On Wed, Oct 16, 2019 at 10:14:23AM +0800, Anson Huang wrote:
> > > usdhc's clock rate is different according to different devices
> > > connected, so clock rate assignment should be placed in board DT
> > > according to different devices connected on each usdhc port.
> >
> > I think it should be fine that we have a reasonable default settings in soc.dtsi,
> > and boards that need a different setup can overwrite the settings in
> > board.dts.
>
> Someone was complaining about the usdhc clock assignment in soc.dtsi, because some
> usdhc nodes are having clock assignments while some are NOT. That is why I did this
> patch set. I agree that we can have default settings in soc.dtsi, so do you think it makes
> sense to add default clock assignment to all usdhc nodes? If yes, I will redo the patch
> set.
I had a second thought on this. To ease the maintenance of soc.dtsi,
let's do clock assignments in board.dts.
Series applied, thanks.
Shawn
next prev parent reply other threads:[~2019-10-28 3:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 2:14 [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to board DT Anson Huang
2019-10-16 2:14 ` Anson Huang
2019-10-16 2:14 ` [PATCH 2/5] arm64: dts: imx8mq: " Anson Huang
2019-10-16 2:14 ` Anson Huang
2019-10-16 2:14 ` [PATCH 3/5] arm64: dts: imx8mm: " Anson Huang
2019-10-16 2:14 ` Anson Huang
2019-10-16 2:14 ` [PATCH 4/5] arm64: dts: imx8mn: " Anson Huang
2019-10-16 2:14 ` Anson Huang
2019-10-16 2:14 ` [PATCH 5/5] ARM: dts: imx7ulp: " Anson Huang
2019-10-16 2:14 ` Anson Huang
2019-10-20 14:35 ` [PATCH 1/5] arm64: dts: imx8qxp: " Abel Vesa
2019-10-20 14:35 ` Abel Vesa
2019-10-26 12:09 ` Shawn Guo
2019-10-26 12:09 ` Shawn Guo
2019-10-28 1:29 ` Anson Huang
2019-10-28 1:29 ` Anson Huang
2019-10-28 3:15 ` Shawn Guo [this message]
2019-10-28 3:15 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028031459.GI16985@dragon \
--to=shawnguo@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=aisheng.dong@nxp.com \
--cc=andradanciu1997@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=anson.huang@nxp.com \
--cc=baruch@tkos.co.il \
--cc=ccaione@baylibre.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gary.bisson@boundarydevices.com \
--cc=jon@solid-run.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=richard.hu@technexion.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.