From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cristiane Naves <cristianenavescardoso09@gmail.com>
Cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis
Date: Mon, 28 Oct 2019 22:02:59 +0300 [thread overview]
Message-ID: <20191028190259.GF1944@kadam> (raw)
In-Reply-To: <158960d90adff42169bb7ce968a4082bf3e73387.1572273794.git.cristianenavescardoso09@gmail.com>
On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> Fix alignment should match open parenthesis. Issue found by checkpatch.
>
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index af12c16..304d031 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> precvbuf->ref_cnt = 0;
> precvbuf->adapter = padapter;
> list_add_tail(&precvbuf->list,
> - &(precvpriv->free_recv_buf_queue.queue));
> + (&precvpriv->free_recv_buf_queue.queue));
You did this correctly in v2.
- &(precvpriv->free_recv_buf_queue.queue));
+ &precvpriv->free_recv_buf_queue.queue);
> precvbuf++;
> }
> precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> tasklet_init(&precvpriv->recv_tasklet,
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-28 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 15:12 [PATCH v3 0/2] Cleanup in rtl8712 Cristiane Naves
2019-10-28 15:15 ` [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis Cristiane Naves
2019-10-28 19:02 ` Dan Carpenter [this message]
2019-10-28 21:21 ` Cristiane Naves
2019-10-29 7:51 ` Dan Carpenter
2019-10-29 8:05 ` [Outreachy kernel] " Greg KH
2019-10-29 8:15 ` Greg KH
2019-10-29 20:21 ` Cristiane Naves
2019-10-29 20:59 ` Julia Lawall
2019-10-29 21:06 ` Cristiane Naves
2019-10-30 5:58 ` Julia Lawall
2019-10-30 4:29 ` Dan Carpenter
2019-10-28 15:17 ` [PATCH v3 2/2] staging: rtl8712: Remove lines before a close brace Cristiane Naves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028190259.GF1944@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=cristianenavescardoso09@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.