Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > 
> > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > ---
> > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > index af12c16..304d031 100644
> > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > >  		precvbuf->ref_cnt = 0;
> > > >  		precvbuf->adapter = padapter;
> > > >  		list_add_tail(&precvbuf->list,
> > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > 
> > > You did this correctly in v2.
> > > 
> > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > 
> > > >  		precvbuf++;
> > > >  	}
> > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > 
> > > regards,
> > > dan carpenter
> > >
> > I wondered if it was better to use parentheses or not. Is it necessary
> > to send a new v5 version containing this change or it's possible to get it from
> > v2?
> 
> Send a follow-on patch to fix this up please as your other one is in my
> tree now I think.

Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
know if it is applied or not as you will get an email when it happens.

thanks,

greg k-h