Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > 
> > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > ---
> > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > index af12c16..304d031 100644
> > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > >  		precvbuf->ref_cnt = 0;
> > >  		precvbuf->adapter = padapter;
> > >  		list_add_tail(&precvbuf->list,
> > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > 
> > You did this correctly in v2.
> > 
> > -				 &(precvpriv->free_recv_buf_queue.queue));
> > +			      &precvpriv->free_recv_buf_queue.queue);
> > 
> > >  		precvbuf++;
> > >  	}
> > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > >  	tasklet_init(&precvpriv->recv_tasklet,
> > 
> > regards,
> > dan carpenter
> >
> I wondered if it was better to use parentheses or not. Is it necessary
> to send a new v5 version containing this change or it's possible to get it from
> v2?

Greg said that patch 2/2 of v4 didn't apply.  To me that suggests that
maybe he applied patch 1/2 and sent you an email?  If not then redo it.

If you don't change the parenthese Greg will apply it.  If you do then
maybe he will and maybe he won't.  The rules say don't do that but we
let people bend the rules slightly.  But why add that element of doubt?

I have a script which removes white space changes so if you change the
parentheses I have to check the patch by hand so that's annoying.  But I
might not comment on it when I'm reviewing the patch.

My advice is to remove the parenthese in a separate patch.

It's not possible to get the patch from v2.  Once a patch is gone then
it's gone forever.

regards,
dan carpenter