From: Boris Brezillon <boris.brezillon@collabora.com>
To: <Tudor.Ambarus@microchip.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH v3 18/32] mtd: spi-nor: Constify data to write to the Status Register
Date: Thu, 31 Oct 2019 12:16:03 +0100 [thread overview]
Message-ID: <20191031121603.295ee60f@collabora.com> (raw)
In-Reply-To: <20191029111615.3706-19-tudor.ambarus@microchip.com>
On Tue, 29 Oct 2019 11:17:17 +0000
<Tudor.Ambarus@microchip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Constify the data to write to the Status Register.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 5fb4d953b5c7..274786e1988f 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -865,7 +865,7 @@ static int spi_nor_write_sr(struct spi_nor *nor, u8 val)
> * second byte will be written to the configuration register.
> * Return negative if error occurred.
> */
> -static int spi_nor_write_sr_cr(struct spi_nor *nor, u8 *sr_cr)
> +static int spi_nor_write_sr_cr(struct spi_nor *nor, const u8 *sr_cr)
> {
> int ret;
>
> @@ -912,7 +912,7 @@ static int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 status_new,
> return ((nor->bouncebuf[0] & mask) != (status_new & mask)) ? -EIO : 0;
> }
>
> -static int spi_nor_write_sr2(struct spi_nor *nor, u8 *sr2)
> +static int spi_nor_write_sr2(struct spi_nor *nor, const u8 *sr2)
> {
> int ret;
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 18/32] mtd: spi-nor: Constify data to write to the Status Register
Date: Thu, 31 Oct 2019 12:16:03 +0100 [thread overview]
Message-ID: <20191031121603.295ee60f@collabora.com> (raw)
In-Reply-To: <20191029111615.3706-19-tudor.ambarus@microchip.com>
On Tue, 29 Oct 2019 11:17:17 +0000
<Tudor.Ambarus@microchip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Constify the data to write to the Status Register.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 5fb4d953b5c7..274786e1988f 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -865,7 +865,7 @@ static int spi_nor_write_sr(struct spi_nor *nor, u8 val)
> * second byte will be written to the configuration register.
> * Return negative if error occurred.
> */
> -static int spi_nor_write_sr_cr(struct spi_nor *nor, u8 *sr_cr)
> +static int spi_nor_write_sr_cr(struct spi_nor *nor, const u8 *sr_cr)
> {
> int ret;
>
> @@ -912,7 +912,7 @@ static int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 status_new,
> return ((nor->bouncebuf[0] & mask) != (status_new & mask)) ? -EIO : 0;
> }
>
> -static int spi_nor_write_sr2(struct spi_nor *nor, u8 *sr2)
> +static int spi_nor_write_sr2(struct spi_nor *nor, const u8 *sr2)
> {
> int ret;
>
next prev parent reply other threads:[~2019-10-31 11:16 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 11:16 [PATCH v3 00/32] mtd: spi-nor: Quad Enable and (un)lock methods Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 01/32] mtd: spi-nor: Prepend spi_nor_ to all Reg Ops methods Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:34 ` Boris Brezillon
2019-10-31 10:34 ` Boris Brezillon
2019-11-02 10:34 ` Tudor.Ambarus
2019-11-02 10:34 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 02/32] mtd: spi-nor: Drop duplicated new line Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:34 ` Boris Brezillon
2019-10-31 10:34 ` Boris Brezillon
2019-11-02 10:34 ` Tudor.Ambarus
2019-11-02 10:34 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 03/32] mtd: spi-nor: Group all Reg Ops to avoid forward declarations Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:35 ` Boris Brezillon
2019-10-31 10:35 ` Boris Brezillon
2019-11-02 10:35 ` Tudor.Ambarus
2019-11-02 10:35 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 04/32] mtd: spi-nor: Stop compare with negative in Reg Ops methods Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:36 ` Boris Brezillon
2019-10-31 10:36 ` Boris Brezillon
2019-11-02 10:36 ` Tudor.Ambarus
2019-11-02 10:36 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 05/32] mtd: spi-nor: Drop explicit cast to int to already int value Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:36 ` Boris Brezillon
2019-10-31 10:36 ` Boris Brezillon
2019-11-02 10:37 ` Tudor.Ambarus
2019-11-02 10:37 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 06/32] mtd: spi-nor: Use dev_err() instead of pr_err() Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:43 ` Boris Brezillon
2019-10-31 10:43 ` Boris Brezillon
2019-11-02 10:38 ` Tudor.Ambarus
2019-11-02 10:38 ` Tudor.Ambarus
2019-10-29 11:16 ` [PATCH v3 07/32] mtd: spi-nor: Don't overwrite errno from Reg Ops Tudor.Ambarus
2019-10-29 11:16 ` Tudor.Ambarus
2019-10-31 10:48 ` Boris Brezillon
2019-10-31 10:48 ` Boris Brezillon
2019-11-02 10:39 ` Tudor.Ambarus
2019-11-02 10:39 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 08/32] mtd: spi-nor: Pointer parameter for SR in spi_nor_read_sr() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 10:51 ` Boris Brezillon
2019-10-31 10:51 ` Boris Brezillon
2019-11-02 10:42 ` Tudor.Ambarus
2019-11-02 10:42 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 09/32] mtd: spi-nor: Pointer parameter for FSR in spi_nor_read_fsr() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 10:53 ` Boris Brezillon
2019-10-31 10:53 ` Boris Brezillon
2019-11-02 10:44 ` Tudor.Ambarus
2019-11-02 10:44 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 10/32] mtd: spi-nor: Pointer parameter for CR in spi_nor_read_cr() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 10:58 ` Boris Brezillon
2019-10-31 10:58 ` Boris Brezillon
2019-10-31 14:26 ` Tudor.Ambarus
2019-10-31 14:26 ` Tudor.Ambarus
2019-11-02 10:45 ` Tudor.Ambarus
2019-11-02 10:45 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 11/32] mtd: spi-nor: Drop redundant error reports in Reg Ops callers Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 10:59 ` Boris Brezillon
2019-10-31 10:59 ` Boris Brezillon
2019-11-02 10:46 ` Tudor.Ambarus
2019-11-02 10:46 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 12/32] mtd: spi-nor: Void return type for spi_nor_clear_sr/fsr() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:02 ` Boris Brezillon
2019-10-31 11:02 ` Boris Brezillon
2019-10-29 11:17 ` [PATCH v3 13/32] mtd: spi-nor: Print error messages inside Reg Ops methods Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:05 ` Boris Brezillon
2019-10-31 11:05 ` Boris Brezillon
2019-10-31 14:18 ` Tudor.Ambarus
2019-10-31 14:18 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 14/32] mtd: spi-nor: Fix retlen handling in sst_write() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:12 ` Boris Brezillon
2019-10-31 11:12 ` Boris Brezillon
2019-11-02 10:47 ` Tudor.Ambarus
2019-11-02 10:47 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 15/32] mtd: spi-nor: Check for errors after each Register Operation Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 6:57 ` Tudor.Ambarus
2019-10-31 6:57 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 16/32] mtd: spi-nor: Rename label as it is no longer generic Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:14 ` Boris Brezillon
2019-10-31 11:14 ` Boris Brezillon
2019-10-29 11:17 ` [PATCH v3 17/32] mtd: spi-nor: Move the WE and wait calls inside Write SR methods Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:15 ` Boris Brezillon
2019-10-31 11:15 ` Boris Brezillon
2019-10-29 11:17 ` [PATCH v3 18/32] mtd: spi-nor: Constify data to write to the Status Register Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:16 ` Boris Brezillon [this message]
2019-10-31 11:16 ` Boris Brezillon
2019-11-02 10:48 ` Tudor.Ambarus
2019-11-02 10:48 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 19/32] mtd: spi-nor: Merge spi_nor_write_sr() and spi_nor_write_sr_cr() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-31 11:17 ` Boris Brezillon
2019-10-31 11:17 ` Boris Brezillon
2019-10-29 11:17 ` [PATCH v3 20/32] mtd: spi-nor: Describe all the Reg Ops Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 21/32] mtd: spi-nor: Drop spansion_quad_enable() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 22/32] mtd: spi-nor: Fix errno on Quad Enable methods Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 23/32] mtd: spi-nor: Check all the bits written, not just the BP ones Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 24/32] mtd: spi-nor: Print error message when the read back test fails Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 25/32] mtd: spi-nor: Fix clearing of QE bit on lock()/unlock() Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 26/32] mtd: spi-nor: Extend the QE Read Back test to the entire SR byte Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 27/32] mtd: spi-nor: Extend the QE Read Back test to both SR1 and SR2 Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 28/32] mtd: spi-nor: Rename CR_QUAD_EN_SPAN to SR2_QUAD_EN_BIT1 Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 29/32] mtd: spi-nor: Merge spansion Quad Enable methods Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 30/32] mtd: spi-nor: Rename macronix_quad_enable to spi_nor_sr1_bit6_quad_enable Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 31/32] mtd: spi-nor: Prepend "spi_nor_" to "sr2_bit7_quad_enable" Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
2019-10-29 11:17 ` [PATCH v3 32/32] mtd: spi-nor: Rework the disabling of block write protection Tudor.Ambarus
2019-10-29 11:17 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031121603.295ee60f@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.