All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers
Date: Tue, 5 Nov 2019 11:13:06 +0100	[thread overview]
Message-ID: <20191105101306.GA3876@gilmour.lan> (raw)
In-Reply-To: <6C5CE71F-37F2-4C8A-9D94-1BC75937B478@holtmann.org>

On Mon, Nov 04, 2019 at 03:20:59PM +0100, Marcel Holtmann wrote:
> >> The rtl_bt driver already supports some Realtek controllers on ACPI
> >> platforms.
> >> This commit adds bindings for DT-only platforms.
> >>
> >> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> >> ---
> >> .../bindings/net/realtek-bluetooth.txt        | 25 +++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> >
> > You should write that binding using a YAML description. Free-form
> > device tree bindings are more or less deprecated now.
>
> unless we change all the Bluetooth descriptions, I prefer we keep it the “old” way.

FWIW, this is a warning in checkpatch now.

Maxime

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <mripard@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>,
	linux-bluetooth@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers
Date: Tue, 5 Nov 2019 11:13:06 +0100	[thread overview]
Message-ID: <20191105101306.GA3876@gilmour.lan> (raw)
In-Reply-To: <6C5CE71F-37F2-4C8A-9D94-1BC75937B478@holtmann.org>

On Mon, Nov 04, 2019 at 03:20:59PM +0100, Marcel Holtmann wrote:
> >> The rtl_bt driver already supports some Realtek controllers on ACPI
> >> platforms.
> >> This commit adds bindings for DT-only platforms.
> >>
> >> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> >> ---
> >> .../bindings/net/realtek-bluetooth.txt        | 25 +++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> >
> > You should write that binding using a YAML description. Free-form
> > device tree bindings are more or less deprecated now.
>
> unless we change all the Bluetooth descriptions, I prefer we keep it the “old” way.

FWIW, this is a warning in checkpatch now.

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-05 10:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 22:43 [PATCH v2 0/3] Add Bluetooth support to Teres A64 I Hugo Grostabussiat
2019-10-30 22:43 ` Hugo Grostabussiat
2019-10-30 22:43 ` [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers Hugo Grostabussiat
2019-10-30 22:43   ` Hugo Grostabussiat
2019-11-01  8:02   ` Maxime Ripard
2019-11-01  8:02     ` Maxime Ripard
2019-11-04 14:20     ` Marcel Holtmann
2019-11-04 14:20       ` Marcel Holtmann
2019-11-05 10:13       ` Maxime Ripard [this message]
2019-11-05 10:13         ` Maxime Ripard
2019-11-05 22:28       ` Rob Herring
2019-11-05 22:28         ` Rob Herring
2019-11-05 22:17   ` Rob Herring
2019-11-05 22:17     ` Rob Herring
2019-11-05 23:17     ` Hugo "Bonstra" Grostabussiat
2019-11-05 23:17       ` Hugo "Bonstra" Grostabussiat
2019-10-30 22:43 ` [PATCH v2 2/3] Bluetooth: hci_h5: Add DT support for rtl8723bs Hugo Grostabussiat
2019-10-30 22:43   ` Hugo Grostabussiat
2019-10-31  6:20   ` Marcel Holtmann
2019-10-31  6:20     ` Marcel Holtmann
2019-10-30 22:43 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: Enable Bluetooth on Teres-I Hugo Grostabussiat
2019-10-30 22:43   ` Hugo Grostabussiat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105101306.GA3876@gilmour.lan \
    --to=mripard@kernel.org \
    --cc=bonstra@bonstra.fr.eu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.