All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers
Date: Tue, 5 Nov 2019 16:17:56 -0600	[thread overview]
Message-ID: <20191105221756.GA15425@bogus> (raw)
In-Reply-To: <20191030224333.70241-2-bonstra@bonstra.fr.eu.org>

On Wed, Oct 30, 2019 at 11:43:31PM +0100, Hugo Grostabussiat wrote:
> The rtl_bt driver already supports some Realtek controllers on ACPI
> platforms.
> This commit adds bindings for DT-only platforms.
> 
> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> ---
>  .../bindings/net/realtek-bluetooth.txt        | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.txt b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> new file mode 100644
> index 000000000000..01d4ed146705
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> @@ -0,0 +1,25 @@
> +Realtek Bluetooth controllers
> +=============================
> +
> +This documents the binding structure and properties for the serial
> +attached Bluetooth controllers from Realtek.
> +
> +Required properties:
> +- compatible: currently, only "realtek,rt8723bs-bt" is supported
> +
> +Optional properties:
> +- enable-gpio: gpio line controlling the power down (BT_DIS#) signal

enable-gpios

Though based on the pin name, powerdown-gpios may be more appropriate. 

> +- device-wake: gpio line controlling the device wakeup (BT_WAKE) signal

device-wake-gpios

> +- config-name: postfix added to the name of the firmware file
> +  containing the chip configuration

'firmware-name' is the common property for this. It's the full filename 
which is more flexible. 

What's the default name?

> +
> +Example:
> +
> +&uart1 {
> +	bluetooth {
> +		compatible = "realtek,rtl8723bs-bt";
> +		enable-gpio = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
> +		device-wake-gpio = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */

PL4 and PL6 aren't meaningful in this context.

> +		config-name = "teres_a64_i";
> +	};
> +};
> -- 
> 2.23.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Maxime Ripard <mripard@kernel.org>,
	linux-bluetooth@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers
Date: Tue, 5 Nov 2019 16:17:56 -0600	[thread overview]
Message-ID: <20191105221756.GA15425@bogus> (raw)
In-Reply-To: <20191030224333.70241-2-bonstra@bonstra.fr.eu.org>

On Wed, Oct 30, 2019 at 11:43:31PM +0100, Hugo Grostabussiat wrote:
> The rtl_bt driver already supports some Realtek controllers on ACPI
> platforms.
> This commit adds bindings for DT-only platforms.
> 
> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> ---
>  .../bindings/net/realtek-bluetooth.txt        | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.txt b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> new file mode 100644
> index 000000000000..01d4ed146705
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> @@ -0,0 +1,25 @@
> +Realtek Bluetooth controllers
> +=============================
> +
> +This documents the binding structure and properties for the serial
> +attached Bluetooth controllers from Realtek.
> +
> +Required properties:
> +- compatible: currently, only "realtek,rt8723bs-bt" is supported
> +
> +Optional properties:
> +- enable-gpio: gpio line controlling the power down (BT_DIS#) signal

enable-gpios

Though based on the pin name, powerdown-gpios may be more appropriate. 

> +- device-wake: gpio line controlling the device wakeup (BT_WAKE) signal

device-wake-gpios

> +- config-name: postfix added to the name of the firmware file
> +  containing the chip configuration

'firmware-name' is the common property for this. It's the full filename 
which is more flexible. 

What's the default name?

> +
> +Example:
> +
> +&uart1 {
> +	bluetooth {
> +		compatible = "realtek,rtl8723bs-bt";
> +		enable-gpio = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
> +		device-wake-gpio = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */

PL4 and PL6 aren't meaningful in this context.

> +		config-name = "teres_a64_i";
> +	};
> +};
> -- 
> 2.23.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-11-05 22:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 22:43 [PATCH v2 0/3] Add Bluetooth support to Teres A64 I Hugo Grostabussiat
2019-10-30 22:43 ` Hugo Grostabussiat
2019-10-30 22:43 ` [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers Hugo Grostabussiat
2019-10-30 22:43   ` Hugo Grostabussiat
2019-11-01  8:02   ` Maxime Ripard
2019-11-01  8:02     ` Maxime Ripard
2019-11-04 14:20     ` Marcel Holtmann
2019-11-04 14:20       ` Marcel Holtmann
2019-11-05 10:13       ` Maxime Ripard
2019-11-05 10:13         ` Maxime Ripard
2019-11-05 22:28       ` Rob Herring
2019-11-05 22:28         ` Rob Herring
2019-11-05 22:17   ` Rob Herring [this message]
2019-11-05 22:17     ` Rob Herring
2019-11-05 23:17     ` Hugo "Bonstra" Grostabussiat
2019-11-05 23:17       ` Hugo "Bonstra" Grostabussiat
2019-10-30 22:43 ` [PATCH v2 2/3] Bluetooth: hci_h5: Add DT support for rtl8723bs Hugo Grostabussiat
2019-10-30 22:43   ` Hugo Grostabussiat
2019-10-31  6:20   ` Marcel Holtmann
2019-10-31  6:20     ` Marcel Holtmann
2019-10-30 22:43 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: Enable Bluetooth on Teres-I Hugo Grostabussiat
2019-10-30 22:43   ` Hugo Grostabussiat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105221756.GA15425@bogus \
    --to=robh@kernel.org \
    --cc=bonstra@bonstra.fr.eu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mark.rutland@arm.com \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.