All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Harry Wentland <harry.wentland@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio
Date: Fri, 15 Nov 2019 10:04:21 +0100	[thread overview]
Message-ID: <20191115100421.22fe2c1a@endymion> (raw)
In-Reply-To: <20191114204413.457504-1-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, 14 Nov 2019 20:44:13 +0000, Chris Wilson wrote:
> An old display with no audio may not have an EDID with a CEA block, or
> it may simply be too old to support audio. This is not a driver error,
> so don't flag it as such.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112140
> References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 11e5784aa62a..04808dbecab3 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -97,8 +97,6 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
>  			(struct edid *) edid->raw_edid);
>  
>  	sad_count = drm_edid_to_sad((struct edid *) edid->raw_edid, &sads);
> -	if (sad_count < 0)
> -		DRM_ERROR("Couldn't read SADs: %d\n", sad_count);
>  	if (sad_count <= 0)
>  		return result;
>  

I still believe that my approach was a better way to solve this problem:

https://patchwork.freedesktop.org/patch/329066/

Your approach would have to be applied to all individual drivers (all
callers of drm_edid_to_sad). It also prevents reporting actual errors.

Should I resend my patch?

-- 
Jean Delvare
SUSE L3 Support
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio
Date: Fri, 15 Nov 2019 10:04:21 +0100	[thread overview]
Message-ID: <20191115100421.22fe2c1a@endymion> (raw)
Message-ID: <20191115090421.Rfo4Wa9Wd6pT5Jop5n3fMxPFGjdH6mhe7gxjNkWbne4@z> (raw)
In-Reply-To: <20191114204413.457504-1-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, 14 Nov 2019 20:44:13 +0000, Chris Wilson wrote:
> An old display with no audio may not have an EDID with a CEA block, or
> it may simply be too old to support audio. This is not a driver error,
> so don't flag it as such.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112140
> References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 11e5784aa62a..04808dbecab3 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -97,8 +97,6 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
>  			(struct edid *) edid->raw_edid);
>  
>  	sad_count = drm_edid_to_sad((struct edid *) edid->raw_edid, &sads);
> -	if (sad_count < 0)
> -		DRM_ERROR("Couldn't read SADs: %d\n", sad_count);
>  	if (sad_count <= 0)
>  		return result;
>  

I still believe that my approach was a better way to solve this problem:

https://patchwork.freedesktop.org/patch/329066/

Your approach would have to be applied to all individual drivers (all
callers of drm_edid_to_sad). It also prevents reporting actual errors.

Should I resend my patch?

-- 
Jean Delvare
SUSE L3 Support
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Harry Wentland <harry.wentland@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio
Date: Fri, 15 Nov 2019 10:04:21 +0100	[thread overview]
Message-ID: <20191115100421.22fe2c1a@endymion> (raw)
Message-ID: <20191115090421.3Wa9rkM4WklwR-zI6yRWMzJ3TYcUqZznrKjoPm49_48@z> (raw)
In-Reply-To: <20191114204413.457504-1-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, 14 Nov 2019 20:44:13 +0000, Chris Wilson wrote:
> An old display with no audio may not have an EDID with a CEA block, or
> it may simply be too old to support audio. This is not a driver error,
> so don't flag it as such.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112140
> References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 11e5784aa62a..04808dbecab3 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -97,8 +97,6 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
>  			(struct edid *) edid->raw_edid);
>  
>  	sad_count = drm_edid_to_sad((struct edid *) edid->raw_edid, &sads);
> -	if (sad_count < 0)
> -		DRM_ERROR("Couldn't read SADs: %d\n", sad_count);
>  	if (sad_count <= 0)
>  		return result;
>  

I still believe that my approach was a better way to solve this problem:

https://patchwork.freedesktop.org/patch/329066/

Your approach would have to be applied to all individual drivers (all
callers of drm_edid_to_sad). It also prevents reporting actual errors.

Should I resend my patch?

-- 
Jean Delvare
SUSE L3 Support
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-15  9:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 20:44 [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio Chris Wilson
2019-11-14 20:44 ` [Intel-gfx] " Chris Wilson
2019-11-14 20:44 ` Chris Wilson
2019-11-14 21:22 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-14 21:22   ` [Intel-gfx] " Patchwork
2019-11-14 21:23 ` [PATCH] " Harry Wentland
2019-11-14 21:23   ` [Intel-gfx] " Harry Wentland
2019-11-14 21:47   ` Alex Deucher
2019-11-14 21:47     ` [Intel-gfx] " Alex Deucher
2019-11-14 21:47     ` Alex Deucher
2019-11-14 21:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-14 21:50   ` [Intel-gfx] " Patchwork
2019-11-15  9:04 ` Jean Delvare [this message]
2019-11-15  9:04   ` [Intel-gfx] [PATCH] " Jean Delvare
2019-11-15  9:04   ` Jean Delvare
2019-11-15  9:18   ` Daniel Vetter
2019-11-15  9:18     ` [Intel-gfx] " Daniel Vetter
2019-11-15  9:18     ` Daniel Vetter
2019-11-15 19:27     ` Ville Syrjälä
2019-11-15 19:27       ` Ville Syrjälä
2019-11-16  2:14 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-11-16  2:14   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115100421.22fe2c1a@endymion \
    --to=jdelvare@suse.de \
    --cc=alexander.deucher@amd.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.