All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio
@ 2019-11-14 20:44 ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-14 20:44 UTC (permalink / raw)
  To: dri-devel; +Cc: Alex Deucher, intel-gfx, Harry Wentland, Jean Delvare

An old display with no audio may not have an EDID with a CEA block, or
it may simply be too old to support audio. This is not a driver error,
so don't flag it as such.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112140
References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Jean Delvare <jdelvare@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index 11e5784aa62a..04808dbecab3 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -97,8 +97,6 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
 			(struct edid *) edid->raw_edid);
 
 	sad_count = drm_edid_to_sad((struct edid *) edid->raw_edid, &sads);
-	if (sad_count < 0)
-		DRM_ERROR("Couldn't read SADs: %d\n", sad_count);
 	if (sad_count <= 0)
 		return result;
 
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2019-11-16  2:15 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-14 20:44 [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio Chris Wilson
2019-11-14 20:44 ` [Intel-gfx] " Chris Wilson
2019-11-14 20:44 ` Chris Wilson
2019-11-14 21:22 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-14 21:22   ` [Intel-gfx] " Patchwork
2019-11-14 21:23 ` [PATCH] " Harry Wentland
2019-11-14 21:23   ` [Intel-gfx] " Harry Wentland
2019-11-14 21:47   ` Alex Deucher
2019-11-14 21:47     ` [Intel-gfx] " Alex Deucher
2019-11-14 21:47     ` Alex Deucher
2019-11-14 21:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-14 21:50   ` [Intel-gfx] " Patchwork
2019-11-15  9:04 ` [PATCH] " Jean Delvare
2019-11-15  9:04   ` [Intel-gfx] " Jean Delvare
2019-11-15  9:04   ` Jean Delvare
2019-11-15  9:18   ` Daniel Vetter
2019-11-15  9:18     ` [Intel-gfx] " Daniel Vetter
2019-11-15  9:18     ` Daniel Vetter
2019-11-15 19:27     ` Ville Syrjälä
2019-11-15 19:27       ` Ville Syrjälä
2019-11-16  2:14 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-11-16  2:14   ` [Intel-gfx] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.