From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning
Date: Mon, 18 Nov 2019 12:46:57 +0100 [thread overview]
Message-ID: <20191118114657.GA228826@kroah.com> (raw)
In-Reply-To: <20191117202435.28127-1-sudipm.mukherjee@gmail.com>
On Sun, Nov 17, 2019 at 08:24:35PM +0000, Sudip Mukherjee wrote:
> Any arm config which has 'CONFIG_MTD_ONENAND_SAMSUNG=m' and
> 'CONFIG_SERIAL_SAMSUNG=m' gives a build warning:
>
> warning: same module names found:
> drivers/tty/serial/samsung.ko
> drivers/mtd/nand/onenand/samsung.ko
>
> Rename both drivers/tty/serial/samsung.c to
> drivers/tty/serial/samsung_tty.c and drivers/mtd/nand/onenand/samsung.c
> drivers/mtd/nand/onenand/samsung_mtd.c to fix the warning.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> v1: only renamed drivers/tty/serial/samsung.c
> link: https://lore.kernel.org/lkml/20191018194707.27188-1-sudipm.mukherjee@gmail.com
>
> v2: rename both files.
>
> I was not sure if this should have been two different patch, but since
> this will be fixing the same problem so it seems its better to have them
> in a single patch.
>
> drivers/mtd/nand/onenand/Makefile | 2 +-
> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0
> drivers/tty/serial/Makefile | 2 +-
> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> 4 files changed, 2 insertions(+), 2 deletions(-)
> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%)
> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)
I can take this in the tty tree if the mtd maintainer gives an ack for
it...
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning
Date: Mon, 18 Nov 2019 12:46:57 +0100 [thread overview]
Message-ID: <20191118114657.GA228826@kroah.com> (raw)
In-Reply-To: <20191117202435.28127-1-sudipm.mukherjee@gmail.com>
On Sun, Nov 17, 2019 at 08:24:35PM +0000, Sudip Mukherjee wrote:
> Any arm config which has 'CONFIG_MTD_ONENAND_SAMSUNG=m' and
> 'CONFIG_SERIAL_SAMSUNG=m' gives a build warning:
>
> warning: same module names found:
> drivers/tty/serial/samsung.ko
> drivers/mtd/nand/onenand/samsung.ko
>
> Rename both drivers/tty/serial/samsung.c to
> drivers/tty/serial/samsung_tty.c and drivers/mtd/nand/onenand/samsung.c
> drivers/mtd/nand/onenand/samsung_mtd.c to fix the warning.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> v1: only renamed drivers/tty/serial/samsung.c
> link: https://lore.kernel.org/lkml/20191018194707.27188-1-sudipm.mukherjee@gmail.com
>
> v2: rename both files.
>
> I was not sure if this should have been two different patch, but since
> this will be fixing the same problem so it seems its better to have them
> in a single patch.
>
> drivers/mtd/nand/onenand/Makefile | 2 +-
> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0
> drivers/tty/serial/Makefile | 2 +-
> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> 4 files changed, 2 insertions(+), 2 deletions(-)
> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%)
> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)
I can take this in the tty tree if the mtd maintainer gives an ack for
it...
next prev parent reply other threads:[~2019-11-18 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 20:24 [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning Sudip Mukherjee
2019-11-17 20:24 ` Sudip Mukherjee
2019-11-18 11:46 ` Greg Kroah-Hartman [this message]
2019-11-18 11:46 ` Greg Kroah-Hartman
2019-11-18 12:47 ` Richard Weinberger
2019-11-18 12:47 ` Richard Weinberger
2019-11-18 19:22 ` Miquel Raynal
2019-11-18 19:22 ` Miquel Raynal
2019-11-18 19:31 ` Richard Weinberger
2019-11-18 19:31 ` Richard Weinberger
2019-11-18 19:40 ` Greg Kroah-Hartman
2019-11-18 19:40 ` Greg Kroah-Hartman
2019-11-20 9:03 ` Miquel Raynal
2019-11-20 9:03 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118114657.GA228826@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sudipm.mukherjee@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.