From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning
Date: Mon, 18 Nov 2019 20:22:57 +0100 [thread overview]
Message-ID: <20191118202257.6cfd1a7e@xps13> (raw)
In-Reply-To: <1505628642.90849.1574081270290.JavaMail.zimbra@nod.at>
Hi all,
Richard Weinberger <richard@nod.at> wrote on Mon, 18 Nov 2019 13:47:50
+0100 (CET):
> ----- Ursprüngliche Mail -----
> >> I was not sure if this should have been two different patch, but since
> >> this will be fixing the same problem so it seems its better to have them
> >> in a single patch.
> >>
> >> drivers/mtd/nand/onenand/Makefile | 2 +-
> >> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0
> >> drivers/tty/serial/Makefile | 2 +-
> >> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> >> 4 files changed, 2 insertions(+), 2 deletions(-)
> >> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%)
> >> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)
> >
> > I can take this in the tty tree if the mtd maintainer gives an ack for
> > it...
>
> Acked-by: Richard Weinberger <richard@nod.at>
If it is not too late, I am not a big fan of the new naming which is
rather not descriptive. Files in the onenand subdirectory are:
* onenand_<something>.c for the base files
* <vendor>.c for the vendors files (currently: omap2.c and samsung.c).
What about doing the MTD changes in a single patch and renaming both
vendor drivers (for the same reason): onenand_omap2.c and
onenand_samsung.c? I know it makes git blaming more difficult though.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning
Date: Mon, 18 Nov 2019 20:22:57 +0100 [thread overview]
Message-ID: <20191118202257.6cfd1a7e@xps13> (raw)
In-Reply-To: <1505628642.90849.1574081270290.JavaMail.zimbra@nod.at>
Hi all,
Richard Weinberger <richard@nod.at> wrote on Mon, 18 Nov 2019 13:47:50
+0100 (CET):
> ----- Ursprüngliche Mail -----
> >> I was not sure if this should have been two different patch, but since
> >> this will be fixing the same problem so it seems its better to have them
> >> in a single patch.
> >>
> >> drivers/mtd/nand/onenand/Makefile | 2 +-
> >> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0
> >> drivers/tty/serial/Makefile | 2 +-
> >> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> >> 4 files changed, 2 insertions(+), 2 deletions(-)
> >> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%)
> >> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)
> >
> > I can take this in the tty tree if the mtd maintainer gives an ack for
> > it...
>
> Acked-by: Richard Weinberger <richard@nod.at>
If it is not too late, I am not a big fan of the new naming which is
rather not descriptive. Files in the onenand subdirectory are:
* onenand_<something>.c for the base files
* <vendor>.c for the vendors files (currently: omap2.c and samsung.c).
What about doing the MTD changes in a single patch and renaming both
vendor drivers (for the same reason): onenand_omap2.c and
onenand_samsung.c? I know it makes git blaming more difficult though.
Thanks,
Miquèl
next prev parent reply other threads:[~2019-11-18 19:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 20:24 [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning Sudip Mukherjee
2019-11-17 20:24 ` Sudip Mukherjee
2019-11-18 11:46 ` Greg Kroah-Hartman
2019-11-18 11:46 ` Greg Kroah-Hartman
2019-11-18 12:47 ` Richard Weinberger
2019-11-18 12:47 ` Richard Weinberger
2019-11-18 19:22 ` Miquel Raynal [this message]
2019-11-18 19:22 ` Miquel Raynal
2019-11-18 19:31 ` Richard Weinberger
2019-11-18 19:31 ` Richard Weinberger
2019-11-18 19:40 ` Greg Kroah-Hartman
2019-11-18 19:40 ` Greg Kroah-Hartman
2019-11-20 9:03 ` Miquel Raynal
2019-11-20 9:03 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118202257.6cfd1a7e@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=richard@nod.at \
--cc=sudipm.mukherjee@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.