From: Eric Biggers <ebiggers@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Subject: Re: [RFC PATCH 3/3] generic: test adding filesystem-level fscrypt key via key_id
Date: Wed, 20 Nov 2019 16:25:29 -0800 [thread overview]
Message-ID: <20191121002528.GE168530@gmail.com> (raw)
In-Reply-To: <20191119223130.228341-4-ebiggers@kernel.org>
On Tue, Nov 19, 2019 at 02:31:30PM -0800, Eric Biggers wrote:
> +# Require support for adding a key to a filesystem's fscrypt keyring via an
> +# "fscrypt-provisioning" keyring key.
> +_require_add_enckey_by_key_id()
> +{
> + local mnt=$1
> +
> + # Userspace support
> + _require_xfs_io_command "add_enckey" "-k"
> +
> + # Kernel support
> + if $XFS_IO_PROG -c "$add_enckey -k 12345 $mnt" \
> + |& grep -q 'Invalid argument'; then
> + _notrun "Kernel doesn't support key_id parameter to FS_IOC_ADD_ENCRYPTION_KEY"
> + fi
> +}
There's a bug here that makes the test not be skipped when it should.
It should say:
if $XFS_IO_PROG -c "add_enckey -k 12345" "$mnt" \
I'll fix this in the next version.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Subject: Re: [RFC PATCH 3/3] generic: test adding filesystem-level fscrypt key via key_id
Date: Thu, 21 Nov 2019 00:25:29 +0000 [thread overview]
Message-ID: <20191121002528.GE168530@gmail.com> (raw)
In-Reply-To: <20191119223130.228341-4-ebiggers@kernel.org>
On Tue, Nov 19, 2019 at 02:31:30PM -0800, Eric Biggers wrote:
> +# Require support for adding a key to a filesystem's fscrypt keyring via an
> +# "fscrypt-provisioning" keyring key.
> +_require_add_enckey_by_key_id()
> +{
> + local mnt=$1
> +
> + # Userspace support
> + _require_xfs_io_command "add_enckey" "-k"
> +
> + # Kernel support
> + if $XFS_IO_PROG -c "$add_enckey -k 12345 $mnt" \
> + |& grep -q 'Invalid argument'; then
> + _notrun "Kernel doesn't support key_id parameter to FS_IOC_ADD_ENCRYPTION_KEY"
> + fi
> +}
There's a bug here that makes the test not be skipped when it should.
It should say:
if $XFS_IO_PROG -c "add_enckey -k 12345" "$mnt" \
I'll fix this in the next version.
- Eric
next prev parent reply other threads:[~2019-11-21 0:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 22:31 [RFC PATCH 0/3] xfstests: test adding filesystem-level fscrypt key via key_id Eric Biggers
2019-11-19 22:31 ` Eric Biggers
2019-11-19 22:31 ` [RFC PATCH 1/3] common/rc: handle option with argument in _require_xfs_io_command() Eric Biggers
2019-11-19 22:31 ` Eric Biggers
2019-11-19 22:31 ` [RFC PATCH 2/3] common/encrypt: move constant test key to common code Eric Biggers
2019-11-19 22:31 ` Eric Biggers
2019-11-19 22:31 ` [RFC PATCH 3/3] generic: test adding filesystem-level fscrypt key via key_id Eric Biggers
2019-11-19 22:31 ` Eric Biggers
2019-11-21 0:25 ` Eric Biggers [this message]
2019-11-21 0:25 ` Eric Biggers
2019-11-27 20:45 ` [RFC PATCH 0/3] xfstests: " Jarkko Sakkinen
2019-11-27 20:45 ` Jarkko Sakkinen
2019-11-27 20:46 ` Jarkko Sakkinen
2019-11-27 20:46 ` Jarkko Sakkinen
2019-11-27 22:57 ` Eric Biggers
2019-11-27 22:57 ` Eric Biggers
2019-12-11 9:50 ` Jarkko Sakkinen
2019-12-11 9:50 ` Jarkko Sakkinen
2019-12-11 18:00 ` Eric Biggers
2019-12-11 18:00 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121002528.GE168530@gmail.com \
--to=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.