All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH v2] drm/sched:  Fix passing zero to 'PTR_ERR' warning
Date: Fri, 29 Nov 2019 16:04:55 +0100	[thread overview]
Message-ID: <20191129160455.18eebe86@collabora.com> (raw)
In-Reply-To: <1572372468-20569-1-git-send-email-andrey.grodzovsky@amd.com>

On Tue, 29 Oct 2019 14:07:48 -0400
Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote:

> Fix a static code checker warning.
> 
> v2: Drop PTR_ERR_OR_ZERO.
> 
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index f39b97e..dba4390 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
>  		fence = sched->ops->run_job(s_job);
>  
>  		if (IS_ERR_OR_NULL(fence)) {
> +			if (IS_ERR(fence))
> +				dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> +
>  			s_job->s_fence->parent = NULL;
> -			dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
>  		} else {
>  			s_job->s_fence->parent = fence;
>  		}

Don't know if this patch has already been applied, but we can get rid of
the extra indentation level by doing:

		if (IS_ERR(fence)) {
			dma_fence_set_error(&s_fence->finished,
					    PTR_ERR(fence));
			fence = NULL;
		}

		s_job->s_fence->parent = fence;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
To: Andrey Grodzovsky <andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2] drm/sched:  Fix passing zero to 'PTR_ERR' warning
Date: Fri, 29 Nov 2019 16:04:55 +0100	[thread overview]
Message-ID: <20191129160455.18eebe86@collabora.com> (raw)
In-Reply-To: <1572372468-20569-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>

On Tue, 29 Oct 2019 14:07:48 -0400
Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote:

> Fix a static code checker warning.
> 
> v2: Drop PTR_ERR_OR_ZERO.
> 
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index f39b97e..dba4390 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
>  		fence = sched->ops->run_job(s_job);
>  
>  		if (IS_ERR_OR_NULL(fence)) {
> +			if (IS_ERR(fence))
> +				dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> +
>  			s_job->s_fence->parent = NULL;
> -			dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
>  		} else {
>  			s_job->s_fence->parent = fence;
>  		}

Don't know if this patch has already been applied, but we can get rid of
the extra indentation level by doing:

		if (IS_ERR(fence)) {
			dma_fence_set_error(&s_fence->finished,
					    PTR_ERR(fence));
			fence = NULL;
		}

		s_job->s_fence->parent = fence;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH v2] drm/sched:  Fix passing zero to 'PTR_ERR' warning
Date: Fri, 29 Nov 2019 16:04:55 +0100	[thread overview]
Message-ID: <20191129160455.18eebe86@collabora.com> (raw)
Message-ID: <20191129150455.8LynPFWHCFG0gyBR-ynf_9UzCHdFrCqEHta6ZIqF0R4@z> (raw)
In-Reply-To: <1572372468-20569-1-git-send-email-andrey.grodzovsky@amd.com>

On Tue, 29 Oct 2019 14:07:48 -0400
Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote:

> Fix a static code checker warning.
> 
> v2: Drop PTR_ERR_OR_ZERO.
> 
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index f39b97e..dba4390 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
>  		fence = sched->ops->run_job(s_job);
>  
>  		if (IS_ERR_OR_NULL(fence)) {
> +			if (IS_ERR(fence))
> +				dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> +
>  			s_job->s_fence->parent = NULL;
> -			dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
>  		} else {
>  			s_job->s_fence->parent = fence;
>  		}

Don't know if this patch has already been applied, but we can get rid of
the extra indentation level by doing:

		if (IS_ERR(fence)) {
			dma_fence_set_error(&s_fence->finished,
					    PTR_ERR(fence));
			fence = NULL;
		}

		s_job->s_fence->parent = fence;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-29 15:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 18:07 [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning Andrey Grodzovsky
2019-10-29 18:07 ` Andrey Grodzovsky
2019-10-29 18:07 ` Andrey Grodzovsky
     [not found] ` <1572372468-20569-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2019-11-04  3:37   ` Deng, Emily
2019-11-04  3:37     ` Deng, Emily
2019-11-04  3:37     ` Deng, Emily
     [not found]     ` <MN2PR12MB29755DDF54361142B8340FEF8F7F0-rweVpJHSKToFlvJWC7EAqwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-11-04 12:15       ` Christian König
2019-11-04 12:15         ` Christian König
2019-11-04 12:15         ` Christian König
2019-11-29 15:04 ` Boris Brezillon [this message]
2019-11-29 15:04   ` Boris Brezillon
2019-11-29 15:04   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191129160455.18eebe86@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.