* [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-10-29 18:07 ` Andrey Grodzovsky
0 siblings, 0 replies; 12+ messages in thread
From: Andrey Grodzovsky @ 2019-10-29 18:07 UTC (permalink / raw)
To: dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA
Cc: Andrey Grodzovsky, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Fix a static code checker warning.
v2: Drop PTR_ERR_OR_ZERO.
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
---
drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index f39b97e..dba4390 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
fence = sched->ops->run_job(s_job);
if (IS_ERR_OR_NULL(fence)) {
+ if (IS_ERR(fence))
+ dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
+
s_job->s_fence->parent = NULL;
- dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
} else {
s_job->s_fence->parent = fence;
}
@@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
r);
dma_fence_put(fence);
} else {
+ if (IS_ERR(fence))
+ dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
- dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
drm_sched_process_job(NULL, &sched_job->cb);
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-10-29 18:07 ` Andrey Grodzovsky
0 siblings, 0 replies; 12+ messages in thread
From: Andrey Grodzovsky @ 2019-10-29 18:07 UTC (permalink / raw)
To: dan.carpenter; +Cc: Andrey Grodzovsky, amd-gfx, dri-devel
Fix a static code checker warning.
v2: Drop PTR_ERR_OR_ZERO.
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
---
drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index f39b97e..dba4390 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
fence = sched->ops->run_job(s_job);
if (IS_ERR_OR_NULL(fence)) {
+ if (IS_ERR(fence))
+ dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
+
s_job->s_fence->parent = NULL;
- dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
} else {
s_job->s_fence->parent = fence;
}
@@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
r);
dma_fence_put(fence);
} else {
+ if (IS_ERR(fence))
+ dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
- dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
drm_sched_process_job(NULL, &sched_job->cb);
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-10-29 18:07 ` Andrey Grodzovsky
0 siblings, 0 replies; 12+ messages in thread
From: Andrey Grodzovsky @ 2019-10-29 18:07 UTC (permalink / raw)
To: dan.carpenter; +Cc: amd-gfx, dri-devel
Fix a static code checker warning.
v2: Drop PTR_ERR_OR_ZERO.
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
---
drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index f39b97e..dba4390 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
fence = sched->ops->run_job(s_job);
if (IS_ERR_OR_NULL(fence)) {
+ if (IS_ERR(fence))
+ dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
+
s_job->s_fence->parent = NULL;
- dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
} else {
s_job->s_fence->parent = fence;
}
@@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
r);
dma_fence_put(fence);
} else {
+ if (IS_ERR(fence))
+ dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
- dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
drm_sched_process_job(NULL, &sched_job->cb);
}
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* RE: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-04 3:37 ` Deng, Emily
0 siblings, 0 replies; 12+ messages in thread
From: Deng, Emily @ 2019-11-04 3:37 UTC (permalink / raw)
To: dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Cc: Grodzovsky, Andrey,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>-----Original Message-----
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>Andrey Grodzovsky
>Sent: Wednesday, October 30, 2019 2:08 AM
>To: dan.carpenter@oracle.com
>Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>
>Fix a static code checker warning.
>
>v2: Drop PTR_ERR_OR_ZERO.
>
>Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>---
> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>b/drivers/gpu/drm/scheduler/sched_main.c
>index f39b97e..dba4390 100644
>--- a/drivers/gpu/drm/scheduler/sched_main.c
>+++ b/drivers/gpu/drm/scheduler/sched_main.c
>@@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>drm_gpu_scheduler *sched)
> fence = sched->ops->run_job(s_job);
>
> if (IS_ERR_OR_NULL(fence)) {
>+ if (IS_ERR(fence))
>+ dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
>+
> s_job->s_fence->parent = NULL;
>- dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
> } else {
> s_job->s_fence->parent = fence;
> }
>@@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
> r);
> dma_fence_put(fence);
> } else {
>+ if (IS_ERR(fence))
>+ dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
>
>- dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
> drm_sched_process_job(NULL, &sched_job->cb);
> }
>
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-04 3:37 ` Deng, Emily
0 siblings, 0 replies; 12+ messages in thread
From: Deng, Emily @ 2019-11-04 3:37 UTC (permalink / raw)
To: Grodzovsky, Andrey, dan.carpenter@oracle.com
Cc: Grodzovsky, Andrey, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>-----Original Message-----
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>Andrey Grodzovsky
>Sent: Wednesday, October 30, 2019 2:08 AM
>To: dan.carpenter@oracle.com
>Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>
>Fix a static code checker warning.
>
>v2: Drop PTR_ERR_OR_ZERO.
>
>Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>---
> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>b/drivers/gpu/drm/scheduler/sched_main.c
>index f39b97e..dba4390 100644
>--- a/drivers/gpu/drm/scheduler/sched_main.c
>+++ b/drivers/gpu/drm/scheduler/sched_main.c
>@@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>drm_gpu_scheduler *sched)
> fence = sched->ops->run_job(s_job);
>
> if (IS_ERR_OR_NULL(fence)) {
>+ if (IS_ERR(fence))
>+ dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
>+
> s_job->s_fence->parent = NULL;
>- dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
> } else {
> s_job->s_fence->parent = fence;
> }
>@@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
> r);
> dma_fence_put(fence);
> } else {
>+ if (IS_ERR(fence))
>+ dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
>
>- dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
> drm_sched_process_job(NULL, &sched_job->cb);
> }
>
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-04 3:37 ` Deng, Emily
0 siblings, 0 replies; 12+ messages in thread
From: Deng, Emily @ 2019-11-04 3:37 UTC (permalink / raw)
To: Grodzovsky, Andrey, dan.carpenter@oracle.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>-----Original Message-----
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>Andrey Grodzovsky
>Sent: Wednesday, October 30, 2019 2:08 AM
>To: dan.carpenter@oracle.com
>Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>
>Fix a static code checker warning.
>
>v2: Drop PTR_ERR_OR_ZERO.
>
>Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>---
> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>b/drivers/gpu/drm/scheduler/sched_main.c
>index f39b97e..dba4390 100644
>--- a/drivers/gpu/drm/scheduler/sched_main.c
>+++ b/drivers/gpu/drm/scheduler/sched_main.c
>@@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>drm_gpu_scheduler *sched)
> fence = sched->ops->run_job(s_job);
>
> if (IS_ERR_OR_NULL(fence)) {
>+ if (IS_ERR(fence))
>+ dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
>+
> s_job->s_fence->parent = NULL;
>- dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
> } else {
> s_job->s_fence->parent = fence;
> }
>@@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
> r);
> dma_fence_put(fence);
> } else {
>+ if (IS_ERR(fence))
>+ dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
>
>- dma_fence_set_error(&s_fence->finished,
>PTR_ERR(fence));
> drm_sched_process_job(NULL, &sched_job->cb);
> }
>
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-04 12:15 ` Christian König
0 siblings, 0 replies; 12+ messages in thread
From: Christian König @ 2019-11-04 12:15 UTC (permalink / raw)
To: Deng, Emily, Grodzovsky, Andrey,
dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Reviewed-by: Christian König <christian.koenig@amd.com>
Am 04.11.19 um 04:37 schrieb Deng, Emily:
> Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>> Andrey Grodzovsky
>> Sent: Wednesday, October 30, 2019 2:08 AM
>> To: dan.carpenter@oracle.com
>> Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>> gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>> Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>>
>> Fix a static code checker warning.
>>
>> v2: Drop PTR_ERR_OR_ZERO.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> ---
>> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index f39b97e..dba4390 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>> drm_gpu_scheduler *sched)
>> fence = sched->ops->run_job(s_job);
>>
>> if (IS_ERR_OR_NULL(fence)) {
>> + if (IS_ERR(fence))
>> + dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> +
>> s_job->s_fence->parent = NULL;
>> - dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> } else {
>> s_job->s_fence->parent = fence;
>> }
>> @@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
>> r);
>> dma_fence_put(fence);
>> } else {
>> + if (IS_ERR(fence))
>> + dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>>
>> - dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> drm_sched_process_job(NULL, &sched_job->cb);
>> }
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-04 12:15 ` Christian König
0 siblings, 0 replies; 12+ messages in thread
From: Christian König @ 2019-11-04 12:15 UTC (permalink / raw)
To: Deng, Emily, Grodzovsky, Andrey, dan.carpenter@oracle.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Reviewed-by: Christian König <christian.koenig@amd.com>
Am 04.11.19 um 04:37 schrieb Deng, Emily:
> Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>> Andrey Grodzovsky
>> Sent: Wednesday, October 30, 2019 2:08 AM
>> To: dan.carpenter@oracle.com
>> Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>> gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>> Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>>
>> Fix a static code checker warning.
>>
>> v2: Drop PTR_ERR_OR_ZERO.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> ---
>> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index f39b97e..dba4390 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>> drm_gpu_scheduler *sched)
>> fence = sched->ops->run_job(s_job);
>>
>> if (IS_ERR_OR_NULL(fence)) {
>> + if (IS_ERR(fence))
>> + dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> +
>> s_job->s_fence->parent = NULL;
>> - dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> } else {
>> s_job->s_fence->parent = fence;
>> }
>> @@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
>> r);
>> dma_fence_put(fence);
>> } else {
>> + if (IS_ERR(fence))
>> + dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>>
>> - dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> drm_sched_process_job(NULL, &sched_job->cb);
>> }
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-04 12:15 ` Christian König
0 siblings, 0 replies; 12+ messages in thread
From: Christian König @ 2019-11-04 12:15 UTC (permalink / raw)
To: Deng, Emily, Grodzovsky, Andrey, dan.carpenter@oracle.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Reviewed-by: Christian König <christian.koenig@amd.com>
Am 04.11.19 um 04:37 schrieb Deng, Emily:
> Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>> Andrey Grodzovsky
>> Sent: Wednesday, October 30, 2019 2:08 AM
>> To: dan.carpenter@oracle.com
>> Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>> gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>> Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>>
>> Fix a static code checker warning.
>>
>> v2: Drop PTR_ERR_OR_ZERO.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> ---
>> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index f39b97e..dba4390 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>> drm_gpu_scheduler *sched)
>> fence = sched->ops->run_job(s_job);
>>
>> if (IS_ERR_OR_NULL(fence)) {
>> + if (IS_ERR(fence))
>> + dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> +
>> s_job->s_fence->parent = NULL;
>> - dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> } else {
>> s_job->s_fence->parent = fence;
>> }
>> @@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
>> r);
>> dma_fence_put(fence);
>> } else {
>> + if (IS_ERR(fence))
>> + dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>>
>> - dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> drm_sched_process_job(NULL, &sched_job->cb);
>> }
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
[not found] ` <1572372468-20569-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2019-11-04 3:37 ` Deng, Emily
@ 2019-11-29 15:04 ` Boris Brezillon
0 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2019-11-29 15:04 UTC (permalink / raw)
To: Andrey Grodzovsky; +Cc: dri-devel, amd-gfx, dan.carpenter
On Tue, 29 Oct 2019 14:07:48 -0400
Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote:
> Fix a static code checker warning.
>
> v2: Drop PTR_ERR_OR_ZERO.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index f39b97e..dba4390 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
> fence = sched->ops->run_job(s_job);
>
> if (IS_ERR_OR_NULL(fence)) {
> + if (IS_ERR(fence))
> + dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> +
> s_job->s_fence->parent = NULL;
> - dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> } else {
> s_job->s_fence->parent = fence;
> }
Don't know if this patch has already been applied, but we can get rid of
the extra indentation level by doing:
if (IS_ERR(fence)) {
dma_fence_set_error(&s_fence->finished,
PTR_ERR(fence));
fence = NULL;
}
s_job->s_fence->parent = fence;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-29 15:04 ` Boris Brezillon
0 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2019-11-29 15:04 UTC (permalink / raw)
To: Andrey Grodzovsky
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA
On Tue, 29 Oct 2019 14:07:48 -0400
Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote:
> Fix a static code checker warning.
>
> v2: Drop PTR_ERR_OR_ZERO.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index f39b97e..dba4390 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
> fence = sched->ops->run_job(s_job);
>
> if (IS_ERR_OR_NULL(fence)) {
> + if (IS_ERR(fence))
> + dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> +
> s_job->s_fence->parent = NULL;
> - dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> } else {
> s_job->s_fence->parent = fence;
> }
Don't know if this patch has already been applied, but we can get rid of
the extra indentation level by doing:
if (IS_ERR(fence)) {
dma_fence_set_error(&s_fence->finished,
PTR_ERR(fence));
fence = NULL;
}
s_job->s_fence->parent = fence;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
@ 2019-11-29 15:04 ` Boris Brezillon
0 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2019-11-29 15:04 UTC (permalink / raw)
To: Andrey Grodzovsky; +Cc: dri-devel, amd-gfx, dan.carpenter
On Tue, 29 Oct 2019 14:07:48 -0400
Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote:
> Fix a static code checker warning.
>
> v2: Drop PTR_ERR_OR_ZERO.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index f39b97e..dba4390 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched)
> fence = sched->ops->run_job(s_job);
>
> if (IS_ERR_OR_NULL(fence)) {
> + if (IS_ERR(fence))
> + dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> +
> s_job->s_fence->parent = NULL;
> - dma_fence_set_error(&s_fence->finished, PTR_ERR(fence));
> } else {
> s_job->s_fence->parent = fence;
> }
Don't know if this patch has already been applied, but we can get rid of
the extra indentation level by doing:
if (IS_ERR(fence)) {
dma_fence_set_error(&s_fence->finished,
PTR_ERR(fence));
fence = NULL;
}
s_job->s_fence->parent = fence;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-11-29 15:05 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 18:07 [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning Andrey Grodzovsky
2019-10-29 18:07 ` Andrey Grodzovsky
2019-10-29 18:07 ` Andrey Grodzovsky
[not found] ` <1572372468-20569-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2019-11-04 3:37 ` Deng, Emily
2019-11-04 3:37 ` Deng, Emily
2019-11-04 3:37 ` Deng, Emily
[not found] ` <MN2PR12MB29755DDF54361142B8340FEF8F7F0-rweVpJHSKToFlvJWC7EAqwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-11-04 12:15 ` Christian König
2019-11-04 12:15 ` Christian König
2019-11-04 12:15 ` Christian König
2019-11-29 15:04 ` Boris Brezillon
2019-11-29 15:04 ` Boris Brezillon
2019-11-29 15:04 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.