All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: stable@vger.kernel.org, Ingo Brunberg <ingo_brunberg@web.de>,
	hch@lst.de, linux-nvme@lists.infradead.org,
	Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional
Date: Mon, 2 Dec 2019 17:15:45 +0100	[thread overview]
Message-ID: <20191202161545.GA7434@lst.de> (raw)
In-Reply-To: <20191202155611.21549-1-kbusch@kernel.org>

On Tue, Dec 03, 2019 at 12:56:11AM +0900, Keith Busch wrote:
> Despite NVM Express specification 1.3 requires a controller claiming to
> be 1.3 or higher implement Identify CNS 03h (Namespace Identification
> Descriptor list), the driver doesn't really need this identification in
> order to use a namespace. The code had already documented in comments
> that we're not to consider an error to this command.
> 
> Return success if the controller provided any response to an
> namespace identification descriptors command.
> 
> Fixes: 538af88ea7d9de24 ("nvme: make nvme_report_ns_ids propagate error back")
> Reported-by: Ingo Brunberg <ingo_brunberg@web.de>

Why would we ignore the error?  Do you have a buggy controller messing
this up?

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
	Ingo Brunberg <ingo_brunberg@web.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	stable@vger.kernel.org
Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional
Date: Mon, 2 Dec 2019 17:15:45 +0100	[thread overview]
Message-ID: <20191202161545.GA7434@lst.de> (raw)
In-Reply-To: <20191202155611.21549-1-kbusch@kernel.org>

On Tue, Dec 03, 2019 at 12:56:11AM +0900, Keith Busch wrote:
> Despite NVM Express specification 1.3 requires a controller claiming to
> be 1.3 or higher implement Identify CNS 03h (Namespace Identification
> Descriptor list), the driver doesn't really need this identification in
> order to use a namespace. The code had already documented in comments
> that we're not to consider an error to this command.
> 
> Return success if the controller provided any response to an
> namespace identification descriptors command.
> 
> Fixes: 538af88ea7d9de24 ("nvme: make nvme_report_ns_ids propagate error back")
> Reported-by: Ingo Brunberg <ingo_brunberg@web.de>

Why would we ignore the error?  Do you have a buggy controller messing
this up?

  reply	other threads:[~2019-12-02 16:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 15:56 [PATCH] nvme: Namepace identification descriptor list is optional Keith Busch
2019-12-02 15:56 ` Keith Busch
2019-12-02 16:15 ` Christoph Hellwig [this message]
2019-12-02 16:15   ` Christoph Hellwig
2019-12-02 16:22   ` Keith Busch
2019-12-02 16:22     ` Keith Busch
2019-12-02 16:27     ` Nadolski, Edmund
2019-12-02 16:27       ` Nadolski, Edmund
2019-12-02 16:29       ` Christoph Hellwig
2019-12-02 16:29         ` Christoph Hellwig
2019-12-02 16:45         ` Nadolski, Edmund
2019-12-02 16:45           ` Nadolski, Edmund
2019-12-02 16:49         ` Keith Busch
2019-12-02 16:49           ` Keith Busch
2019-12-02 17:34           ` Christoph Hellwig
2019-12-02 17:34             ` Christoph Hellwig
2019-12-02 21:21             ` Keith Busch
2019-12-02 21:21               ` Keith Busch
2020-07-10  8:22 ` Ingo Brunberg
2020-07-22 23:23   ` Sagi Grimberg
2020-07-23  1:23     ` Ingo Brunberg
2020-07-28 11:08       ` Christoph Hellwig
2020-07-28 14:41         ` Ingo Brunberg
2020-07-28 16:01           ` Sagi Grimberg
     [not found] <d163890a-a469-e71c-45b7-f63e1efee04e@intel.com>
2020-07-12  9:31 ` Ingo Brunberg
2020-07-12 17:03   ` Rajashekar, Revanth
2020-07-14 15:21   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202161545.GA7434@lst.de \
    --to=hch@lst.de \
    --cc=ingo_brunberg@web.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.