From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Ingo Brunberg <ingo_brunberg@web.de>,
"Nadolski, Edmund" <edmund.nadolski@intel.com>,
stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional
Date: Mon, 2 Dec 2019 18:34:14 +0100 [thread overview]
Message-ID: <20191202173414.GA8950@lst.de> (raw)
In-Reply-To: <20191202164903.GA21650@redsun51.ssa.fujisawa.hgst.com>
On Tue, Dec 03, 2019 at 01:49:03AM +0900, Keith Busch wrote:
> Customer or OEM requirments are poorly written, like "Must report NVMe
> version 1.3". Nobody bothers to mention that it must also be compliant
> to that version, or even realize they never cared for those features in
> the first place.
>
> Compliance testing like from UNH should have caught this before shipping
> with such a device, but it's a cheap device, so maybe they skip that step.
>
> > I wonder if we actually do users a favour by allowing that..
>
> I think it's too late now. We did successfully use such namespaces
> before 5.4, even if they're fundamentally broken.
>
> Johannes also commented *not* to consider these errors when this
> identification was originally implemented, so either he knew vendors
> screwed this up, or had the forethought to know they would.
Yes. I guess your patch is the best thing for now:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I think we might need a new kernel tain flag or something like
it for devices that are so obviously broken in their identifiers.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Nadolski, Edmund" <edmund.nadolski@intel.com>,
stable@vger.kernel.org, Ingo Brunberg <ingo_brunberg@web.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional
Date: Mon, 2 Dec 2019 18:34:14 +0100 [thread overview]
Message-ID: <20191202173414.GA8950@lst.de> (raw)
In-Reply-To: <20191202164903.GA21650@redsun51.ssa.fujisawa.hgst.com>
On Tue, Dec 03, 2019 at 01:49:03AM +0900, Keith Busch wrote:
> Customer or OEM requirments are poorly written, like "Must report NVMe
> version 1.3". Nobody bothers to mention that it must also be compliant
> to that version, or even realize they never cared for those features in
> the first place.
>
> Compliance testing like from UNH should have caught this before shipping
> with such a device, but it's a cheap device, so maybe they skip that step.
>
> > I wonder if we actually do users a favour by allowing that..
>
> I think it's too late now. We did successfully use such namespaces
> before 5.4, even if they're fundamentally broken.
>
> Johannes also commented *not* to consider these errors when this
> identification was originally implemented, so either he knew vendors
> screwed this up, or had the forethought to know they would.
Yes. I guess your patch is the best thing for now:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I think we might need a new kernel tain flag or something like
it for devices that are so obviously broken in their identifiers.
next prev parent reply other threads:[~2019-12-02 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 15:56 [PATCH] nvme: Namepace identification descriptor list is optional Keith Busch
2019-12-02 15:56 ` Keith Busch
2019-12-02 16:15 ` Christoph Hellwig
2019-12-02 16:15 ` Christoph Hellwig
2019-12-02 16:22 ` Keith Busch
2019-12-02 16:22 ` Keith Busch
2019-12-02 16:27 ` Nadolski, Edmund
2019-12-02 16:27 ` Nadolski, Edmund
2019-12-02 16:29 ` Christoph Hellwig
2019-12-02 16:29 ` Christoph Hellwig
2019-12-02 16:45 ` Nadolski, Edmund
2019-12-02 16:45 ` Nadolski, Edmund
2019-12-02 16:49 ` Keith Busch
2019-12-02 16:49 ` Keith Busch
2019-12-02 17:34 ` Christoph Hellwig [this message]
2019-12-02 17:34 ` Christoph Hellwig
2019-12-02 21:21 ` Keith Busch
2019-12-02 21:21 ` Keith Busch
2020-07-10 8:22 ` Ingo Brunberg
2020-07-22 23:23 ` Sagi Grimberg
2020-07-23 1:23 ` Ingo Brunberg
2020-07-28 11:08 ` Christoph Hellwig
2020-07-28 14:41 ` Ingo Brunberg
2020-07-28 16:01 ` Sagi Grimberg
[not found] <d163890a-a469-e71c-45b7-f63e1efee04e@intel.com>
2020-07-12 9:31 ` Ingo Brunberg
2020-07-12 17:03 ` Rajashekar, Revanth
2020-07-14 15:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202173414.GA8950@lst.de \
--to=hch@lst.de \
--cc=edmund.nadolski@intel.com \
--cc=ingo_brunberg@web.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.