All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: thierry.reding@gmail.com, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
	christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels
Date: Sun, 15 Dec 2019 10:40:18 +0100	[thread overview]
Message-ID: <20191215094018.GA27552@ravnborg.org> (raw)
In-Reply-To: <1744285.zQlJhejOUX@phil>

Hi Heiko.

> > The idea was that if a write returned an error then do not even attempt
> > more writes. So if a write fails we do not loose the original error
> > code, assuming subsequent write would also fail.
> 
> Shouldn't the code above do exactly that? ... Because it's like
> 
> 	ret = dcs_write(...)
> 	if (ret <0)
> 		return ret;
> 
> So if any of the dcs_writes goes wrong it should just return the
> error code from that write from the function and not try any more
> writes. (or I'm blind and do not see something ;-) )

You are right, the code does it already.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	robh+dt@kernel.org, thierry.reding@gmail.com,
	christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels
Date: Sun, 15 Dec 2019 10:40:18 +0100	[thread overview]
Message-ID: <20191215094018.GA27552@ravnborg.org> (raw)
In-Reply-To: <1744285.zQlJhejOUX@phil>

Hi Heiko.

> > The idea was that if a write returned an error then do not even attempt
> > more writes. So if a write fails we do not loose the original error
> > code, assuming subsequent write would also fail.
> 
> Shouldn't the code above do exactly that? ... Because it's like
> 
> 	ret = dcs_write(...)
> 	if (ret <0)
> 		return ret;
> 
> So if any of the dcs_writes goes wrong it should just return the
> error code from that write from the function and not try any more
> writes. (or I'm blind and do not see something ;-) )

You are right, the code does it already.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-12-15  9:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 14:42 [PATCH 1/3] dt-bindings: Add vendor prefix for Xinpeng Technology Heiko Stuebner
2019-12-09 14:42 ` Heiko Stuebner
2019-12-09 14:42 ` [PATCH 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272 Heiko Stuebner
2019-12-09 14:42   ` Heiko Stuebner
2019-12-14  7:54   ` Sam Ravnborg
2019-12-14  7:54     ` Sam Ravnborg
2019-12-09 14:42 ` [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels Heiko Stuebner
2019-12-09 14:42   ` Heiko Stuebner
2019-12-14  8:17   ` Sam Ravnborg
2019-12-14  8:17     ` Sam Ravnborg
2019-12-14 23:07     ` Heiko Stübner
2019-12-14 23:07       ` Heiko Stübner
2019-12-15  8:29       ` Sam Ravnborg
2019-12-15  8:29         ` Sam Ravnborg
2019-12-15  9:13         ` Heiko Stuebner
2019-12-15  9:13           ` Heiko Stuebner
2019-12-15  9:40           ` Sam Ravnborg [this message]
2019-12-15  9:40             ` Sam Ravnborg
2019-12-14  7:50 ` [PATCH 1/3] dt-bindings: Add vendor prefix for Xinpeng Technology Sam Ravnborg
2019-12-14  7:50   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191215094018.GA27552@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.