All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-mtd@lists.infradead.org,
	Richard Weinberger <richard@nod.at>,
	linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	stable@vger.kernel.org, Hou Tao <houtao1@huawei.com>
Subject: Re: [PATCH 1/2] ubifs: fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag
Date: Tue, 17 Dec 2019 10:46:09 -0800	[thread overview]
Message-ID: <20191217184608.GB89165@gmail.com> (raw)
In-Reply-To: <20191216150636.0511E2072D@mail.kernel.org>

On Mon, Dec 16, 2019 at 03:06:35PM +0000, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: d475a507457b ("ubifs: Add skeleton for fscrypto").
> 
> The bot has tested the following trees: v5.4.2, v5.3.15, v4.19.88, v4.14.158.
> 
> v5.4.2: Build OK!
> v5.3.15: Build OK!
> v4.19.88: Build failed! Errors:
>     fs/ubifs/ioctl.c:130:28: error: ‘UBIFS_SUPPORTED_IOCTL_FLAGS’ undeclared (first use in this function)
> 
> v4.14.158: Build failed! Errors:
>     fs/ubifs/ioctl.c:127:28: error: ‘UBIFS_SUPPORTED_IOCTL_FLAGS’ undeclared (first use in this function)
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?
> 

4.19 and 4.14 will build if you apply commit 2fe8b2d5578d
("ubifs: Reject unsupported ioctl flags explicitly") first.
That was a bug fix too, so I recommend applying it.

- Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
	stable@vger.kernel.org, linux-fscrypt@vger.kernel.org,
	linux-mtd@lists.infradead.org, Hou Tao <houtao1@huawei.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] ubifs: fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag
Date: Tue, 17 Dec 2019 10:46:09 -0800	[thread overview]
Message-ID: <20191217184608.GB89165@gmail.com> (raw)
In-Reply-To: <20191216150636.0511E2072D@mail.kernel.org>

On Mon, Dec 16, 2019 at 03:06:35PM +0000, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: d475a507457b ("ubifs: Add skeleton for fscrypto").
> 
> The bot has tested the following trees: v5.4.2, v5.3.15, v4.19.88, v4.14.158.
> 
> v5.4.2: Build OK!
> v5.3.15: Build OK!
> v4.19.88: Build failed! Errors:
>     fs/ubifs/ioctl.c:130:28: error: ‘UBIFS_SUPPORTED_IOCTL_FLAGS’ undeclared (first use in this function)
> 
> v4.14.158: Build failed! Errors:
>     fs/ubifs/ioctl.c:127:28: error: ‘UBIFS_SUPPORTED_IOCTL_FLAGS’ undeclared (first use in this function)
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?
> 

4.19 and 4.14 will build if you apply commit 2fe8b2d5578d
("ubifs: Reject unsupported ioctl flags explicitly") first.
That was a bug fix too, so I recommend applying it.

- Eric

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-12-17 18:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 22:23 [PATCH 0/2] ubifs: fixes for FS_IOC_GETFLAGS and FS_IOC_SETFLAGS Eric Biggers
2019-12-09 22:23 ` Eric Biggers
2019-12-09 22:23 ` [PATCH 1/2] ubifs: fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag Eric Biggers
2019-12-09 22:23   ` Eric Biggers
2019-12-16 15:06   ` Sasha Levin
2019-12-17 18:46     ` Eric Biggers [this message]
2019-12-17 18:46       ` Eric Biggers
2019-12-09 22:23 ` [PATCH 2/2] ubifs: add support for FS_ENCRYPT_FL Eric Biggers
2019-12-09 22:23   ` Eric Biggers
2020-01-03 17:08 ` [PATCH 0/2] ubifs: fixes for FS_IOC_GETFLAGS and FS_IOC_SETFLAGS Eric Biggers
2020-01-03 17:08   ` Eric Biggers
2020-01-14 22:00 ` Eric Biggers
2020-01-14 22:00   ` Eric Biggers
2020-01-14 22:03   ` Richard Weinberger
2020-01-14 22:03     ` Richard Weinberger
2020-01-16 23:32     ` Richard Weinberger
2020-01-16 23:32       ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217184608.GB89165@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=houtao1@huawei.com \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.