All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manasi Navare <manasi.d.navare@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size
Date: Tue, 17 Dec 2019 12:58:53 -0800	[thread overview]
Message-ID: <20191217205852.GB24921@intel.com> (raw)
In-Reply-To: <20191211212433.18185-1-manasi.d.navare@intel.com>

On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote:
> DRM Fb driver expects multiple CRTCs if it sees connector->has_tile
> is set, but we need to handle tile support and look for multiple CRTCs
> only for the modes that match the tile size. The other modes should
> be able to be displayed without tile support or uisng single CRTC.
> 
> This patch adds the check to match the tile size with requested mode
> to handle the tile support.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>

Capturing Dave Airlie's r-b from IRC:

Reviewed-by: Dave Airlie <airlied@redhat.com>

Manasi

> ---
>  drivers/gpu/drm/drm_fb_helper.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index fb9bff0f4581..4978363714a9 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1558,7 +1558,9 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
>  		for (j = 0; j < mode_set->num_connectors; j++) {
>  			struct drm_connector *connector = mode_set->connectors[j];
>  
> -			if (connector->has_tile) {
> +			if (connector->has_tile &&
> +			    desired_mode->hdisplay == connector->tile_h_size &&
> +			    desired_mode->vdisplay == connector->tile_v_size) {
>  				lasth = (connector->tile_h_loc == (connector->num_h_tile - 1));
>  				lastv = (connector->tile_v_loc == (connector->num_v_tile - 1));
>  				/* cloning to multiple tiles is just crazy-talk, so: */
> -- 
> 2.19.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Manasi Navare <manasi.d.navare@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>, Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size
Date: Tue, 17 Dec 2019 12:58:53 -0800	[thread overview]
Message-ID: <20191217205852.GB24921@intel.com> (raw)
In-Reply-To: <20191211212433.18185-1-manasi.d.navare@intel.com>

On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote:
> DRM Fb driver expects multiple CRTCs if it sees connector->has_tile
> is set, but we need to handle tile support and look for multiple CRTCs
> only for the modes that match the tile size. The other modes should
> be able to be displayed without tile support or uisng single CRTC.
> 
> This patch adds the check to match the tile size with requested mode
> to handle the tile support.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>

Capturing Dave Airlie's r-b from IRC:

Reviewed-by: Dave Airlie <airlied@redhat.com>

Manasi

> ---
>  drivers/gpu/drm/drm_fb_helper.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index fb9bff0f4581..4978363714a9 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1558,7 +1558,9 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
>  		for (j = 0; j < mode_set->num_connectors; j++) {
>  			struct drm_connector *connector = mode_set->connectors[j];
>  
> -			if (connector->has_tile) {
> +			if (connector->has_tile &&
> +			    desired_mode->hdisplay == connector->tile_h_size &&
> +			    desired_mode->vdisplay == connector->tile_v_size) {
>  				lasth = (connector->tile_h_loc == (connector->num_h_tile - 1));
>  				lastv = (connector->tile_v_loc == (connector->num_v_tile - 1));
>  				/* cloning to multiple tiles is just crazy-talk, so: */
> -- 
> 2.19.1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-12-17 20:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:24 [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size Manasi Navare
2019-12-11 21:24 ` [Intel-gfx] " Manasi Navare
2019-12-11 21:24 ` [PATCH 2/2] drm/fbdev: Fallback to non tiled mode if all tiles not present Manasi Navare
2019-12-11 21:24   ` [Intel-gfx] " Manasi Navare
2019-12-12  2:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Handle connector tile support only for modes that match tile size Patchwork
2019-12-12 21:28   ` Manasi Navare
2019-12-13  8:54     ` Tomi Sarvela
2019-12-16 23:59       ` Manasi Navare
2019-12-17  7:56         ` Tomi Sarvela
2019-12-17 20:57           ` Manasi Navare
2019-12-13 20:40 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2019-12-17 20:58 ` Manasi Navare [this message]
2019-12-17 20:58   ` [Intel-gfx] [PATCH 1/2] " Manasi Navare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217205852.GB24921@intel.com \
    --to=manasi.d.navare@intel.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.