From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mt76: Off by one in mt76_calc_rx_airtime()
Date: Wed, 18 Dec 2019 18:51:54 +0000 [thread overview]
Message-ID: <20191218185154.B16F6C447A3@smtp.codeaurora.org> (raw)
In-Reply-To: <20191121213935.2cbgh3qmd4hv4v5a@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The sband->bitrates[] array has "sband->n_bitrates" elements so this
> check needs to be >= instead of > or we could read beyond the end of the
> array.
>
> These values come from when we call mt76_register_device():
>
> ret = mt76_register_device(&dev->mt76, true, mt7603_rates,
> ARRAY_SIZE(mt7603_rates));
>
> Here sband->bitrates[] is mt7603_rates[] and ->n_bitrates is the
> ARRAY_SIZE()
>
> Fixes: 5ce09c1a7907 ("mt76: track rx airtime for airtime fairness and survey")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers.git, thanks.
b43e36d75e87 mt76: Off by one in mt76_calc_rx_airtime()
--
https://patchwork.kernel.org/patch/11261391/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mt76: Off by one in mt76_calc_rx_airtime()
Date: Wed, 18 Dec 2019 18:51:54 +0000 (UTC) [thread overview]
Message-ID: <20191218185154.B16F6C447A3@smtp.codeaurora.org> (raw)
In-Reply-To: <20191121213935.2cbgh3qmd4hv4v5a@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The sband->bitrates[] array has "sband->n_bitrates" elements so this
> check needs to be >= instead of > or we could read beyond the end of the
> array.
>
> These values come from when we call mt76_register_device():
>
> ret = mt76_register_device(&dev->mt76, true, mt7603_rates,
> ARRAY_SIZE(mt7603_rates));
>
> Here sband->bitrates[] is mt7603_rates[] and ->n_bitrates is the
> ARRAY_SIZE()
>
> Fixes: 5ce09c1a7907 ("mt76: track rx airtime for airtime fairness and survey")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers.git, thanks.
b43e36d75e87 mt76: Off by one in mt76_calc_rx_airtime()
--
https://patchwork.kernel.org/patch/11261391/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-12-18 18:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 4:49 [PATCH] mt76: Off by one in mt76_calc_rx_airtime() Dan Carpenter
2019-11-26 4:49 ` Dan Carpenter
2019-11-26 4:49 ` Dan Carpenter
2019-11-26 5:21 ` Kalle Valo
2019-11-26 5:21 ` Kalle Valo
2019-11-26 5:25 ` Markus Theil
2019-11-26 5:25 ` Markus Theil
2019-11-26 5:25 ` Markus Theil
2019-11-26 8:04 ` Toke Høiland-Jørgensen
2019-11-26 8:04 ` Toke Høiland-Jørgensen
2019-11-26 8:04 ` Toke Høiland-Jørgensen
2019-11-26 9:11 ` Dan Carpenter
2019-11-26 9:11 ` Dan Carpenter
2019-11-26 9:11 ` Dan Carpenter
2019-11-26 9:16 ` Toke Høiland-Jørgensen
2019-11-26 9:16 ` Toke Høiland-Jørgensen
2019-11-26 9:16 ` Toke Høiland-Jørgensen
2019-11-26 9:23 ` Kalle Valo
2019-11-26 9:23 ` Kalle Valo
2019-11-26 12:09 ` [PATCH] mac80211: airtime: Fix an off by one in ieee80211_calc_rx_airtime() Dan Carpenter
2019-11-26 12:09 ` Dan Carpenter
2019-11-26 12:09 ` Dan Carpenter
2019-11-26 12:39 ` Toke Høiland-Jørgensen
2019-11-26 12:39 ` Toke Høiland-Jørgensen
2019-11-26 12:39 ` Toke Høiland-Jørgensen
2019-12-18 18:51 ` [PATCH] mt76: Off by one in mt76_calc_rx_airtime() Kalle Valo
2019-12-18 18:51 ` Kalle Valo [this message]
2019-12-18 18:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218185154.B16F6C447A3@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.