From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org, Roy Luo <royluo@google.com>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] mac80211: airtime: Fix an off by one in ieee80211_calc_rx_airtime()
Date: Tue, 26 Nov 2019 12:39:28 +0000 [thread overview]
Message-ID: <87wobmyfpb.fsf@toke.dk> (raw)
In-Reply-To: <20191126120910.ftr4t7me3by32aiz@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> This code was copied from mt76 and inherited an off by one bug from
> there. The > should be >= so that we don't read one element beyond
> the end of the array.
>
> Fixes: db3e1c40cf2f ("mac80211: Import airtime calculation code from mt76")
> Reported-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org, Roy Luo <royluo@google.com>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] mac80211: airtime: Fix an off by one in ieee80211_calc_rx_airtime()
Date: Tue, 26 Nov 2019 13:39:28 +0100 [thread overview]
Message-ID: <87wobmyfpb.fsf@toke.dk> (raw)
In-Reply-To: <20191126120910.ftr4t7me3by32aiz@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> This code was copied from mt76 and inherited an off by one bug from
> there. The > should be >= so that we don't read one element beyond
> the end of the array.
>
> Fixes: db3e1c40cf2f ("mac80211: Import airtime calculation code from mt76")
> Reported-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>,
Kalle Valo <kvalo@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mac80211: airtime: Fix an off by one in ieee80211_calc_rx_airtime()
Date: Tue, 26 Nov 2019 13:39:28 +0100 [thread overview]
Message-ID: <87wobmyfpb.fsf@toke.dk> (raw)
In-Reply-To: <20191126120910.ftr4t7me3by32aiz@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> This code was copied from mt76 and inherited an off by one bug from
> there. The > should be >= so that we don't read one element beyond
> the end of the array.
>
> Fixes: db3e1c40cf2f ("mac80211: Import airtime calculation code from mt76")
> Reported-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2019-11-26 12:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 4:49 [PATCH] mt76: Off by one in mt76_calc_rx_airtime() Dan Carpenter
2019-11-26 4:49 ` Dan Carpenter
2019-11-26 4:49 ` Dan Carpenter
2019-11-26 5:21 ` Kalle Valo
2019-11-26 5:21 ` Kalle Valo
2019-11-26 5:25 ` Markus Theil
2019-11-26 5:25 ` Markus Theil
2019-11-26 5:25 ` Markus Theil
2019-11-26 8:04 ` Toke Høiland-Jørgensen
2019-11-26 8:04 ` Toke Høiland-Jørgensen
2019-11-26 8:04 ` Toke Høiland-Jørgensen
2019-11-26 9:11 ` Dan Carpenter
2019-11-26 9:11 ` Dan Carpenter
2019-11-26 9:11 ` Dan Carpenter
2019-11-26 9:16 ` Toke Høiland-Jørgensen
2019-11-26 9:16 ` Toke Høiland-Jørgensen
2019-11-26 9:16 ` Toke Høiland-Jørgensen
2019-11-26 9:23 ` Kalle Valo
2019-11-26 9:23 ` Kalle Valo
2019-11-26 12:09 ` [PATCH] mac80211: airtime: Fix an off by one in ieee80211_calc_rx_airtime() Dan Carpenter
2019-11-26 12:09 ` Dan Carpenter
2019-11-26 12:09 ` Dan Carpenter
2019-11-26 12:39 ` Toke Høiland-Jørgensen [this message]
2019-11-26 12:39 ` Toke Høiland-Jørgensen
2019-11-26 12:39 ` Toke Høiland-Jørgensen
2019-12-18 18:51 ` [PATCH] mt76: Off by one in mt76_calc_rx_airtime() Kalle Valo
2019-12-18 18:51 ` Kalle Valo
2019-12-18 18:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wobmyfpb.fsf@toke.dk \
--to=toke@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.