From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>, Adrian Hunter <adrian.hunter@intel.com>,
Chris Mason <clm@fb.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Christoph Hellwig <hch@infradead.org>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Ceph Development <ceph-devel@vger.kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors
Date: Sat, 21 Dec 2019 20:59:56 -0500 [thread overview]
Message-ID: <20191222015956.GA63378@mit.edu> (raw)
In-Reply-To: <20191218192331.GA7473@magnolia>
On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote:
> *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes
> more sense. Er, I guess I don't mind pushing via iomap tree, but could
> we get some acks from Ted and any of the ceph maintainers?
Acked-by: Theodore Ts'o <tytso@mit.edu>
My only nit is the same one Jan raised, which is should
page_mkwrite_check_truncate() be an inline function?
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Jeff Layton <jlayton@kernel.org>, Sage Weil <sage@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Richard Weinberger <richard@nod.at>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ceph Development <ceph-devel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors
Date: Sat, 21 Dec 2019 20:59:56 -0500 [thread overview]
Message-ID: <20191222015956.GA63378@mit.edu> (raw)
In-Reply-To: <20191218192331.GA7473@magnolia>
On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote:
> *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes
> more sense. Er, I guess I don't mind pushing via iomap tree, but could
> we get some acks from Ted and any of the ceph maintainers?
Acked-by: Theodore Ts'o <tytso@mit.edu>
My only nit is the same one Jan raised, which is should
page_mkwrite_check_truncate() be an inline function?
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>, Adrian Hunter <adrian.hunter@intel.com>,
Chris Mason <clm@fb.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Christoph Hellwig <hch@infradead.org>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Ceph Development <ceph-devel@vger.kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v3] fs: Fix page_mkwrite off-by-one errors
Date: Sat, 21 Dec 2019 20:59:56 -0500 [thread overview]
Message-ID: <20191222015956.GA63378@mit.edu> (raw)
In-Reply-To: <20191218192331.GA7473@magnolia>
On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote:
> *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes
> more sense. Er, I guess I don't mind pushing via iomap tree, but could
> we get some acks from Ted and any of the ceph maintainers?
Acked-by: Theodore Ts'o <tytso@mit.edu>
My only nit is the same one Jan raised, which is should
page_mkwrite_check_truncate() be an inline function?
- Ted
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>, Adrian Hunter <adrian.hunter@intel.com>,
Chris Mason <clm@fb.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Christoph Hellwig <hch@infradead.org>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Chao Yu <chao@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Ceph Development <ceph-devel@vger.kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors
Date: Sat, 21 Dec 2019 20:59:56 -0500 [thread overview]
Message-ID: <20191222015956.GA63378@mit.edu> (raw)
In-Reply-To: <20191218192331.GA7473@magnolia>
On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote:
> *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes
> more sense. Er, I guess I don't mind pushing via iomap tree, but could
> we get some acks from Ted and any of the ceph maintainers?
Acked-by: Theodore Ts'o <tytso@mit.edu>
My only nit is the same one Jan raised, which is should
page_mkwrite_check_truncate() be an inline function?
- Ted
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-12-22 1:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 13:09 [PATCH v3] fs: Fix page_mkwrite off-by-one errors Andreas Gruenbacher
2019-12-18 13:09 ` Andreas Gruenbacher
2019-12-18 13:09 ` [f2fs-dev] " Andreas Gruenbacher
2019-12-18 13:09 ` Andreas Gruenbacher
2019-12-18 14:10 ` Jan Kara
2019-12-18 14:10 ` Jan Kara
2019-12-18 14:10 ` [f2fs-dev] " Jan Kara
2019-12-18 14:10 ` Jan Kara
2019-12-18 18:52 ` Darrick J. Wong
2019-12-18 18:52 ` [f2fs-dev] " Darrick J. Wong
2019-12-18 18:52 ` Darrick J. Wong
2019-12-18 19:15 ` Andreas Gruenbacher
2019-12-18 19:15 ` Andreas Gruenbacher
2019-12-18 19:15 ` [f2fs-dev] " Andreas Gruenbacher
2019-12-18 19:15 ` Andreas Gruenbacher
2019-12-18 19:23 ` Darrick J. Wong
2019-12-18 19:23 ` Darrick J. Wong
2019-12-18 19:23 ` [f2fs-dev] " Darrick J. Wong
2019-12-18 19:23 ` Darrick J. Wong
2019-12-22 1:59 ` Theodore Y. Ts'o [this message]
2019-12-22 1:59 ` Theodore Y. Ts'o
2019-12-22 1:59 ` [f2fs-dev] " Theodore Y. Ts'o
2019-12-22 1:59 ` Theodore Y. Ts'o
2019-12-18 19:21 ` Matthew Wilcox
2019-12-18 19:21 ` Matthew Wilcox
2019-12-18 19:21 ` [f2fs-dev] " Matthew Wilcox
2019-12-18 19:21 ` Matthew Wilcox
2020-01-07 23:20 ` Darrick J. Wong
2020-01-07 23:20 ` [f2fs-dev] " Darrick J. Wong
2020-01-07 23:20 ` Darrick J. Wong
2020-01-08 9:09 ` Chao Yu
2020-01-08 9:09 ` Chao Yu
2020-01-08 9:09 ` [f2fs-dev] " Chao Yu
2020-01-08 9:09 ` Chao Yu
2020-01-08 11:51 ` Jaegeuk Kim
2020-01-08 11:51 ` Jaegeuk Kim
2020-01-08 11:51 ` [f2fs-dev] " Jaegeuk Kim
2020-01-08 11:51 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191222015956.GA63378@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=dedekind1@gmail.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=richard@nod.at \
--cc=sage@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.