From: Krzysztof Kozlowski <krzk@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] phy: Enable compile testing for some of drivers
Date: Tue, 31 Dec 2019 09:20:28 +0100 [thread overview]
Message-ID: <20191231082028.GC6804@pi3> (raw)
In-Reply-To: <791d83ef-faee-d6e6-445e-a8088c5ac654@gmail.com>
On Mon, Dec 30, 2019 at 12:10:51PM -0800, Florian Fainelli wrote:
> Hi Krzysztof,
>
> On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote:
> > Some of the phy drivers can be compile tested to increase build
> > coverage.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> This looks fine, you could also consider adding a bunch of other
> Broadcom PHY drivers which are not currently under COMPILE_TEST, yet
> build fine:
I'll send a v2 with them as well. They seem to compile fine.
Best regards,
Krzysztof
>
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index d3d983c128ea..d56db6d375e1 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3
>
> config PHY_NS2_PCIE
> tristate "Broadcom Northstar2 PCIe PHY driver"
> - depends on OF && MDIO_BUS_MUX_BCM_IPROC
> + depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST
> select GENERIC_PHY
> default ARCH_BCM_IPROC
> help
> @@ -83,7 +83,7 @@ config PHY_BRCM_SATA
>
> config PHY_BRCM_USB
> tristate "Broadcom STB USB PHY driver"
> - depends on ARCH_BRCMSTB
> + depends on ARCH_BRCMSTB || COMPILE_TEST
> depends on OF
> select GENERIC_PHY
> select SOC_BRCMSTB
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] phy: Enable compile testing for some of drivers
Date: Tue, 31 Dec 2019 09:20:28 +0100 [thread overview]
Message-ID: <20191231082028.GC6804@pi3> (raw)
In-Reply-To: <791d83ef-faee-d6e6-445e-a8088c5ac654@gmail.com>
On Mon, Dec 30, 2019 at 12:10:51PM -0800, Florian Fainelli wrote:
> Hi Krzysztof,
>
> On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote:
> > Some of the phy drivers can be compile tested to increase build
> > coverage.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> This looks fine, you could also consider adding a bunch of other
> Broadcom PHY drivers which are not currently under COMPILE_TEST, yet
> build fine:
I'll send a v2 with them as well. They seem to compile fine.
Best regards,
Krzysztof
>
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index d3d983c128ea..d56db6d375e1 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3
>
> config PHY_NS2_PCIE
> tristate "Broadcom Northstar2 PCIe PHY driver"
> - depends on OF && MDIO_BUS_MUX_BCM_IPROC
> + depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST
> select GENERIC_PHY
> default ARCH_BCM_IPROC
> help
> @@ -83,7 +83,7 @@ config PHY_BRCM_SATA
>
> config PHY_BRCM_USB
> tristate "Broadcom STB USB PHY driver"
> - depends on ARCH_BRCMSTB
> + depends on ARCH_BRCMSTB || COMPILE_TEST
> depends on OF
> select GENERIC_PHY
> select SOC_BRCMSTB
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] phy: Enable compile testing for some of drivers
Date: Tue, 31 Dec 2019 09:20:28 +0100 [thread overview]
Message-ID: <20191231082028.GC6804@pi3> (raw)
In-Reply-To: <791d83ef-faee-d6e6-445e-a8088c5ac654@gmail.com>
On Mon, Dec 30, 2019 at 12:10:51PM -0800, Florian Fainelli wrote:
> Hi Krzysztof,
>
> On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote:
> > Some of the phy drivers can be compile tested to increase build
> > coverage.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> This looks fine, you could also consider adding a bunch of other
> Broadcom PHY drivers which are not currently under COMPILE_TEST, yet
> build fine:
I'll send a v2 with them as well. They seem to compile fine.
Best regards,
Krzysztof
>
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index d3d983c128ea..d56db6d375e1 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3
>
> config PHY_NS2_PCIE
> tristate "Broadcom Northstar2 PCIe PHY driver"
> - depends on OF && MDIO_BUS_MUX_BCM_IPROC
> + depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST
> select GENERIC_PHY
> default ARCH_BCM_IPROC
> help
> @@ -83,7 +83,7 @@ config PHY_BRCM_SATA
>
> config PHY_BRCM_USB
> tristate "Broadcom STB USB PHY driver"
> - depends on ARCH_BRCMSTB
> + depends on ARCH_BRCMSTB || COMPILE_TEST
> depends on OF
> select GENERIC_PHY
> select SOC_BRCMSTB
>
next prev parent reply other threads:[~2019-12-31 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:24 [PATCH 1/2] phy: mediatek: Fix Kconfig indentation Krzysztof Kozlowski
2019-12-30 17:24 ` Krzysztof Kozlowski
2019-12-30 17:24 ` Krzysztof Kozlowski
2019-12-30 17:24 ` [PATCH 2/2] phy: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-30 17:24 ` Krzysztof Kozlowski
2019-12-30 17:24 ` Krzysztof Kozlowski
2019-12-30 20:10 ` Florian Fainelli
2019-12-30 20:10 ` Florian Fainelli
2019-12-30 20:10 ` Florian Fainelli
2019-12-31 8:20 ` Krzysztof Kozlowski [this message]
2019-12-31 8:20 ` Krzysztof Kozlowski
2019-12-31 8:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231082028.GC6804@pi3 \
--to=krzk@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=f.fainelli@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.