All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Doug Anderson <dianders@chromium.org>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready
Date: Fri, 17 Jun 2016 01:35:28 +0200	[thread overview]
Message-ID: <2019301.c5hsQIZXPF@phil> (raw)
In-Reply-To: <1463092986-61777-1-git-send-email-briannorris@chromium.org>

Am Donnerstag, 12. Mai 2016, 15:43:03 schrieb Brian Norris:
> From: Shawn Lin <shawn.lin@rock-chips.com>
> 
> According to the databook, 10.2us is the max time for dll to be ready to
> work. However in testing, some chips need 20us for dll to be ready. This
> patch adds some extra margin for dllrdy to be ready, fixing our
> -ETIMEDOUT issues.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

haven't looked to deep into the emmc-phy block, but on my rk3399-evb board 
the emmc still runs nicely with this patch, so

Tested-by: Heiko Stuebner <heiko@sntech.de>

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready
Date: Fri, 17 Jun 2016 01:35:28 +0200	[thread overview]
Message-ID: <2019301.c5hsQIZXPF@phil> (raw)
In-Reply-To: <1463092986-61777-1-git-send-email-briannorris@chromium.org>

Am Donnerstag, 12. Mai 2016, 15:43:03 schrieb Brian Norris:
> From: Shawn Lin <shawn.lin@rock-chips.com>
> 
> According to the databook, 10.2us is the max time for dll to be ready to
> work. However in testing, some chips need 20us for dll to be ready. This
> patch adds some extra margin for dllrdy to be ready, fixing our
> -ETIMEDOUT issues.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

haven't looked to deep into the emmc-phy block, but on my rk3399-evb board 
the emmc still runs nicely with this patch, so

Tested-by: Heiko Stuebner <heiko@sntech.de>

  parent reply	other threads:[~2016-06-16 23:35 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 22:43 [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Brian Norris
2016-05-12 22:43 ` Brian Norris
2016-05-12 22:43 ` Brian Norris
2016-05-12 22:43 ` [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay Brian Norris
2016-05-12 22:43   ` Brian Norris
2016-05-12 22:43   ` Brian Norris
2016-05-13 22:25   ` Doug Anderson
2016-05-13 22:25     ` Doug Anderson
2016-05-16  4:15     ` Shawn Lin
2016-05-16  4:15       ` Shawn Lin
     [not found]       ` <52567d92-d1d3-f089-65c2-a30f3a00386b-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-16 15:12         ` Doug Anderson
2016-05-16 15:12           ` Doug Anderson
2016-05-16 15:12           ` Doug Anderson
2016-06-16 23:36   ` Heiko Stuebner
2016-06-16 23:36     ` Heiko Stuebner
     [not found]   ` <1463092986-61777-3-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-06-20 13:11     ` Kishon Vijay Abraham I
2016-06-20 13:11       ` Kishon Vijay Abraham I
2016-06-20 13:11       ` Kishon Vijay Abraham I
2016-05-12 22:43 ` [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions Brian Norris
2016-05-12 22:43   ` Brian Norris
2016-05-12 22:43   ` Brian Norris
2016-05-13 22:26   ` Doug Anderson
2016-05-13 22:26     ` Doug Anderson
2016-06-16 23:37   ` Heiko Stuebner
2016-06-16 23:37     ` Heiko Stuebner
     [not found]   ` <1463092986-61777-4-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-06-20 13:12     ` Kishon Vijay Abraham I
2016-06-20 13:12       ` Kishon Vijay Abraham I
2016-06-20 13:12       ` Kishon Vijay Abraham I
2016-05-13 22:01 ` [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Doug Anderson
2016-05-13 22:01   ` Doug Anderson
2016-06-16 23:35 ` Heiko Stuebner [this message]
2016-06-16 23:35   ` Heiko Stuebner
     [not found] ` <1463092986-61777-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-05-12 22:43   ` [PATCH 2/4] phy: rockchip-emmc: configure frequency range and drive impedance Brian Norris
2016-05-12 22:43     ` Brian Norris
2016-05-12 22:43     ` Brian Norris
2016-05-13  1:02     ` Shawn Lin
2016-05-13  1:02       ` Shawn Lin
2016-05-13 18:46       ` Doug Anderson
2016-05-13 18:46         ` Doug Anderson
2016-05-13 21:04         ` Brian Norris
2016-05-13 21:04           ` Brian Norris
2016-05-24  4:51         ` Doug Anderson
2016-05-24  4:51           ` Doug Anderson
2016-05-13 21:09     ` [PATCH v2 " Brian Norris
2016-05-13 21:09       ` Brian Norris
2016-05-13 22:04       ` Doug Anderson
2016-05-13 22:04         ` Doug Anderson
2016-06-16 23:36       ` Heiko Stuebner
2016-06-16 23:36         ` Heiko Stuebner
2016-06-20 13:11     ` [PATCH " Kishon Vijay Abraham I
2016-06-20 13:11       ` Kishon Vijay Abraham I
2016-06-20 13:11       ` Kishon Vijay Abraham I
2016-06-20 13:11   ` [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Kishon Vijay Abraham I
2016-06-20 13:11     ` Kishon Vijay Abraham I
2016-06-20 13:11     ` Kishon Vijay Abraham I
2016-06-20 16:19     ` Brian Norris
2016-06-20 16:19       ` Brian Norris
2016-06-20 16:19       ` Brian Norris
2016-06-20 16:25       ` Doug Anderson
2016-06-20 16:25         ` Doug Anderson
2016-06-20 16:50         ` Brian Norris
2016-06-20 16:50           ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2019301.c5hsQIZXPF@phil \
    --to=heiko@sntech.de \
    --cc=briannorris@chromium.org \
    --cc=computersforpeace@gmail.com \
    --cc=dianders@chromium.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.