[Buildroot] [PATCH 1/1] package/olsr: add netjson plugin

[Buildroot] [PATCH 1/1] package/olsr: add netjson plugin

[Fabrice Fontaine]

Add netjson plugin, available since version 0.9.5 and
https://github.com/OLSR/olsrd/commit/64c00288f8e87d314a723e20c2dd69f1165f1645

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/olsr/olsr.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
index 766b1432c1..e643a0cfb3 100644
--- a/package/olsr/olsr.mk
+++ b/package/olsr/olsr.mk
@@ -9,7 +9,7 @@ OLSR_VERSION = $(OLSR_VERSION_MAJOR).6.1
 OLSR_SOURCE = olsrd-$(OLSR_VERSION).tar.bz2
 OLSR_SITE = http://www.olsr.org/releases/$(OLSR_VERSION_MAJOR)
 OLSR_PLUGINS = arprefresh bmf dot_draw dyn_gw dyn_gw_plain httpinfo jsoninfo \
-	mdns nameservice p2pd pgraph secure txtinfo watchdog
+	mdns nameservice netjson p2pd pgraph secure txtinfo watchdog
 # Doesn't really need quagga but not very useful without it
 OLSR_PLUGINS += $(if $(BR2_PACKAGE_QUAGGA),quagga)
 OLSR_LICENSE = BSD-3-Clause, LGPL-2.1+
-- 
2.24.1

[Buildroot] [PATCH 1/1] package/olsr: add netjson plugin

[Thomas Petazzoni]

On Sun, 12 Jan 2020 23:27:54 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add netjson plugin, available since version 0.9.5 and
> https://github.com/OLSR/olsrd/commit/64c00288f8e87d314a723e20c2dd69f1165f1645
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/olsr/olsr.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. While reviewing this patch, I noticed
olsr.mk uses shell "for" loops for the build/installation of plugins.
Unfortunately, it is done in a way that will ignore errors if one of
the plugins fails to build or install, which is not great. It would be
nice to change these loops to make "foreach" loops, which will
automatically abort if one iteration of the loop returns a non-zero
error code.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com