From: Krzysztof Kozlowski <krzk@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
Date: Mon, 13 Jan 2020 11:46:54 +0100 [thread overview]
Message-ID: <20200113102733.GA1965@pi3> (raw)
In-Reply-To: <202001090146.Z0aZqj3N%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 4491 bytes --]
On Thu, Jan 09, 2020 at 01:21:28AM +0800, kbuild test robot wrote:
> Hi Krzysztof,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on wsa/i2c/for-next]
> [also build test WARNING on v5.5-rc5 next-20200106]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/i2c-Enable-compile-testing-for-some-of-drivers/20200107-164808
> base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.1-129-g341daf20-dirty
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> drivers/i2c/busses/i2c-stu300.c:446:17: sparse: sparse: cast removes address space '<asn:2>' of expression
I fixed this already here:
https://lore.kernel.org/lkml/20191230172751.17985-4-krzk(a)kernel.org/
Best regards,
Krzysztof
>
> vim +446 drivers/i2c/busses/i2c-stu300.c
>
> 18904c0ecdf2cf Linus Walleij 2009-06-13 421
> 18904c0ecdf2cf Linus Walleij 2009-06-13 422 /*
> 18904c0ecdf2cf Linus Walleij 2009-06-13 423 * Waits for the busy bit to go low by repeated polling.
> 18904c0ecdf2cf Linus Walleij 2009-06-13 424 */
> 18904c0ecdf2cf Linus Walleij 2009-06-13 425 #define BUSY_RELEASE_ATTEMPTS 10
> 18904c0ecdf2cf Linus Walleij 2009-06-13 426 static int stu300_wait_while_busy(struct stu300_dev *dev)
> 18904c0ecdf2cf Linus Walleij 2009-06-13 427 {
> 18904c0ecdf2cf Linus Walleij 2009-06-13 428 unsigned long timeout;
> 18904c0ecdf2cf Linus Walleij 2009-06-13 429 int i;
> 18904c0ecdf2cf Linus Walleij 2009-06-13 430
> 18904c0ecdf2cf Linus Walleij 2009-06-13 431 for (i = 0; i < BUSY_RELEASE_ATTEMPTS; i++) {
> 18904c0ecdf2cf Linus Walleij 2009-06-13 432 timeout = jiffies + STU300_TIMEOUT;
> 18904c0ecdf2cf Linus Walleij 2009-06-13 433
> 18904c0ecdf2cf Linus Walleij 2009-06-13 434 while (!time_after(jiffies, timeout)) {
> 18904c0ecdf2cf Linus Walleij 2009-06-13 435 /* Is not busy? */
> 18904c0ecdf2cf Linus Walleij 2009-06-13 436 if ((stu300_r8(dev->virtbase + I2C_SR1) &
> 18904c0ecdf2cf Linus Walleij 2009-06-13 437 I2C_SR1_BUSY_IND) == 0)
> 18904c0ecdf2cf Linus Walleij 2009-06-13 438 return 0;
> 18904c0ecdf2cf Linus Walleij 2009-06-13 439 msleep(1);
> 18904c0ecdf2cf Linus Walleij 2009-06-13 440 }
> 18904c0ecdf2cf Linus Walleij 2009-06-13 441
> 18904c0ecdf2cf Linus Walleij 2009-06-13 442 dev_err(&dev->pdev->dev, "transaction timed out "
> 18904c0ecdf2cf Linus Walleij 2009-06-13 443 "waiting for device to be free (not busy). "
> 18904c0ecdf2cf Linus Walleij 2009-06-13 444 "Attempt: %d\n", i+1);
> 18904c0ecdf2cf Linus Walleij 2009-06-13 445
> 18904c0ecdf2cf Linus Walleij 2009-06-13 @446 dev_err(&dev->pdev->dev, "base address = "
> 18904c0ecdf2cf Linus Walleij 2009-06-13 447 "0x%08x, reinit hardware\n", (u32) dev->virtbase);
> 18904c0ecdf2cf Linus Walleij 2009-06-13 448
> 18904c0ecdf2cf Linus Walleij 2009-06-13 449 (void) stu300_init_hw(dev);
> 18904c0ecdf2cf Linus Walleij 2009-06-13 450 }
> 18904c0ecdf2cf Linus Walleij 2009-06-13 451
> 18904c0ecdf2cf Linus Walleij 2009-06-13 452 dev_err(&dev->pdev->dev, "giving up after %d attempts "
> 18904c0ecdf2cf Linus Walleij 2009-06-13 453 "to reset the bus.\n", BUSY_RELEASE_ATTEMPTS);
> 18904c0ecdf2cf Linus Walleij 2009-06-13 454
> 18904c0ecdf2cf Linus Walleij 2009-06-13 455 return -ETIMEDOUT;
> 18904c0ecdf2cf Linus Walleij 2009-06-13 456 }
> 18904c0ecdf2cf Linus Walleij 2009-06-13 457
>
> :::::: The code at line 446 was first introduced by commit
> :::::: 18904c0ecdf2cf22347da2adc4b273e9570333d8 i2c: ST DDC I2C U300 bus driver v3
>
> :::::: TO: Linus Walleij <linus.walleij@stericsson.com>
> :::::: CC: Ben Dooks <ben-linux@fluff.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
next prev parent reply other threads:[~2020-01-13 10:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
2020-01-07 8:12 ` Krzysztof Kozlowski
2020-01-07 8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
2020-01-07 8:12 ` Krzysztof Kozlowski
2020-01-23 9:13 ` Wolfram Sang
2020-01-23 9:13 ` Wolfram Sang
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 10:59 ` Wolfram Sang
2020-01-08 17:21 ` [PATCH v2 1/2] i2c: Enable compile testing for some of drivers kbuild test robot
2020-01-13 10:46 ` Krzysztof Kozlowski [this message]
2020-01-10 11:40 ` Dan Carpenter
2020-01-10 11:40 ` Dan Carpenter
2020-01-23 9:12 ` Wolfram Sang
2020-01-23 9:12 ` Wolfram Sang
2020-01-23 9:31 ` Krzysztof Kozlowski
2020-01-23 9:31 ` Krzysztof Kozlowski
2020-01-23 9:41 ` Wolfram Sang
2020-01-23 9:41 ` Wolfram Sang
2020-01-23 10:00 ` Krzysztof Kozlowski
2020-01-23 10:00 ` Krzysztof Kozlowski
2020-01-23 12:46 ` Uwe Kleine-König
2020-01-23 12:46 ` Uwe Kleine-König
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 15:31 ` Marc Gonzalez
2020-01-23 15:31 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113102733.GA1965@pi3 \
--to=krzk@kernel.org \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.