From: Wolfram Sang <wsa@the-dreams.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Jean Delvare <jdelvare@suse.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>, Greg KH <greg@kroah.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
Date: Thu, 23 Jan 2020 10:41:07 +0100 [thread overview]
Message-ID: <20200123094107.GD1105@ninjato> (raw)
In-Reply-To: <20200123093120.GA2365@pi3>
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
On Thu, Jan 23, 2020 at 10:31:20AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Jan 23, 2020 at 10:12:28AM +0100, Wolfram Sang wrote:
> >
> > > config I2C_ZX2967
> > > tristate "ZTE ZX2967 I2C support"
> > > - depends on ARCH_ZX
> > > - default y
> > > + depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> > > + # COMPILE_TEST needs architectures with readsX()/writesX() primitives
> >
> > The list of archs neither looks pretty nor very maintainable. My
> > suggestion is that we leave this out of COMPILE_TEST until we have
> > something like ARCH_HAS_READS or something. What do you think?
>
> Indeed it does not look good. However having compile testing allows
> kbuild to run sparse and smatch which already started pointing minor
> issues in existing drivers.
>
> Yeah... pros and cons... I don't have a strong opinion to keep it. Since
> patch is important, maybe let's just skip this part?
Yeah, let's skip it for now. If you or someone is keen on having it,
something like ARCH_HAS_READS (<- needs better name) should be
introduced so we can use it here. But that can/should be handled
incrementally.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
Date: Thu, 23 Jan 2020 10:41:07 +0100 [thread overview]
Message-ID: <20200123094107.GD1105@ninjato> (raw)
In-Reply-To: <20200123093120.GA2365@pi3>
[-- Attachment #1.1: Type: text/plain, Size: 1193 bytes --]
On Thu, Jan 23, 2020 at 10:31:20AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Jan 23, 2020 at 10:12:28AM +0100, Wolfram Sang wrote:
> >
> > > config I2C_ZX2967
> > > tristate "ZTE ZX2967 I2C support"
> > > - depends on ARCH_ZX
> > > - default y
> > > + depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> > > + # COMPILE_TEST needs architectures with readsX()/writesX() primitives
> >
> > The list of archs neither looks pretty nor very maintainable. My
> > suggestion is that we leave this out of COMPILE_TEST until we have
> > something like ARCH_HAS_READS or something. What do you think?
>
> Indeed it does not look good. However having compile testing allows
> kbuild to run sparse and smatch which already started pointing minor
> issues in existing drivers.
>
> Yeah... pros and cons... I don't have a strong opinion to keep it. Since
> patch is important, maybe let's just skip this part?
Yeah, let's skip it for now. If you or someone is keen on having it,
something like ARCH_HAS_READS (<- needs better name) should be
introduced so we can use it here. But that can/should be handled
incrementally.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-23 9:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
2020-01-07 8:12 ` Krzysztof Kozlowski
2020-01-07 8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
2020-01-07 8:12 ` Krzysztof Kozlowski
2020-01-23 9:13 ` Wolfram Sang
2020-01-23 9:13 ` Wolfram Sang
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 10:59 ` Wolfram Sang
2020-01-08 17:21 ` [PATCH v2 1/2] i2c: Enable compile testing for some of drivers kbuild test robot
2020-01-13 10:46 ` Krzysztof Kozlowski
2020-01-10 11:40 ` Dan Carpenter
2020-01-10 11:40 ` Dan Carpenter
2020-01-23 9:12 ` Wolfram Sang
2020-01-23 9:12 ` Wolfram Sang
2020-01-23 9:31 ` Krzysztof Kozlowski
2020-01-23 9:31 ` Krzysztof Kozlowski
2020-01-23 9:41 ` Wolfram Sang [this message]
2020-01-23 9:41 ` Wolfram Sang
2020-01-23 10:00 ` Krzysztof Kozlowski
2020-01-23 10:00 ` Krzysztof Kozlowski
2020-01-23 12:46 ` Uwe Kleine-König
2020-01-23 12:46 ` Uwe Kleine-König
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 15:31 ` Marc Gonzalez
2020-01-23 15:31 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123094107.GD1105@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=greg@kroah.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.