From: Wu Hao <hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Subject: Re: [RESEND Patch v6 0/2] add performance reporting support to FPGA DFL drivers
Date: Fri, 17 Jan 2020 11:39:34 +0800 [thread overview]
Message-ID: <20200117033934.GA23536@hao-dev> (raw)
In-Reply-To: <1579230628-22243-1-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Will
I resend this patch per suggestion from Greg.
Actually this is one important feature for users, but was blocked by
code review for quite a long time (no comments since last November).
We really need your help on code review from perf, please help us..
Many Thanks!
Hao
On Fri, Jan 17, 2020 at 11:10:26AM +0800, Wu Hao wrote:
> Hi all,
>
> This patchset adds performance reporting support for FPGA DFL drivers. It
> introduces one pmu to expose userspace interfaces via standard perf API.
> User could use standard perf tool to access perf events exposed via pmu.
>
> This patchset is generated based on latest fpga/for-next branch.
>
> Main changes from v5:
> - use dev_ext_attribute instead of fme_perf_event_attr.
> - use is_visible function to decide which events to expose per
> hardware capability, and add event_init checking for all events.
>
> Main changes from v4:
> - rebase and clean up.
> - update Kconfig for PERF_EVENTS dependency.
>
> Main changes from v3:
> - add more descriptions in doc, including how to use perf tool for these
> hardware counters. (patch #1)
> - use standard perf API instead of sysfs entries. (patch #2)
>
> Wu Hao (1):
> fpga: dfl: fme: add performance reporting support
>
> Xu Yilun (1):
> Documentation: fpga: dfl: add description for performance reporting
> support
>
> Documentation/fpga/dfl.rst | 83 ++++
> drivers/fpga/Makefile | 1 +
> drivers/fpga/dfl-fme-main.c | 4 +
> drivers/fpga/dfl-fme-perf.c | 943 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/fpga/dfl-fme.h | 2 +
> drivers/fpga/dfl.h | 2 +
> 6 files changed, 1035 insertions(+)
> create mode 100644 drivers/fpga/dfl-fme-perf.c
>
> --
> 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Wu Hao <hao.wu@intel.com>
To: will@kernel.org
Cc: mdf@kernel.org, mark.rutland@arm.com, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
atull@kernel.org, gregkh@linuxfoundation.org
Subject: Re: [RESEND Patch v6 0/2] add performance reporting support to FPGA DFL drivers
Date: Fri, 17 Jan 2020 11:39:34 +0800 [thread overview]
Message-ID: <20200117033934.GA23536@hao-dev> (raw)
In-Reply-To: <1579230628-22243-1-git-send-email-hao.wu@intel.com>
Hi Will
I resend this patch per suggestion from Greg.
Actually this is one important feature for users, but was blocked by
code review for quite a long time (no comments since last November).
We really need your help on code review from perf, please help us..
Many Thanks!
Hao
On Fri, Jan 17, 2020 at 11:10:26AM +0800, Wu Hao wrote:
> Hi all,
>
> This patchset adds performance reporting support for FPGA DFL drivers. It
> introduces one pmu to expose userspace interfaces via standard perf API.
> User could use standard perf tool to access perf events exposed via pmu.
>
> This patchset is generated based on latest fpga/for-next branch.
>
> Main changes from v5:
> - use dev_ext_attribute instead of fme_perf_event_attr.
> - use is_visible function to decide which events to expose per
> hardware capability, and add event_init checking for all events.
>
> Main changes from v4:
> - rebase and clean up.
> - update Kconfig for PERF_EVENTS dependency.
>
> Main changes from v3:
> - add more descriptions in doc, including how to use perf tool for these
> hardware counters. (patch #1)
> - use standard perf API instead of sysfs entries. (patch #2)
>
> Wu Hao (1):
> fpga: dfl: fme: add performance reporting support
>
> Xu Yilun (1):
> Documentation: fpga: dfl: add description for performance reporting
> support
>
> Documentation/fpga/dfl.rst | 83 ++++
> drivers/fpga/Makefile | 1 +
> drivers/fpga/dfl-fme-main.c | 4 +
> drivers/fpga/dfl-fme-perf.c | 943 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/fpga/dfl-fme.h | 2 +
> drivers/fpga/dfl.h | 2 +
> 6 files changed, 1035 insertions(+)
> create mode 100644 drivers/fpga/dfl-fme-perf.c
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2020-01-17 3:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 3:10 [RESEND Patch v6 0/2] add performance reporting support to FPGA DFL drivers Wu Hao
2020-01-17 3:10 ` Wu Hao
2020-01-17 3:10 ` [RESEND Patch v6 2/2] fpga: dfl: fme: add performance reporting support Wu Hao
2020-01-18 2:59 ` kbuild test robot
2020-01-18 6:54 ` kbuild test robot
[not found] ` <1579230628-22243-3-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-01-22 14:10 ` Greg KH
2020-01-22 14:10 ` Greg KH
[not found] ` <20200122141026.GA10399-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2020-01-23 2:05 ` Wu Hao
2020-01-23 2:05 ` Wu Hao
[not found] ` <1579230628-22243-1-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-01-17 3:10 ` [RESEND Patch v6 1/2] Documentation: fpga: dfl: add description for " Wu Hao
2020-01-17 3:10 ` Wu Hao
2020-01-17 3:39 ` Wu Hao [this message]
2020-01-17 3:39 ` [RESEND Patch v6 0/2] add performance reporting support to FPGA DFL drivers Wu Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117033934.GA23536@hao-dev \
--to=hao.wu-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.