From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Wu Hao <hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Luwei Kang <luwei.kang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Xu Yilun <yilun.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [RESEND Patch v6 2/2] fpga: dfl: fme: add performance reporting support
Date: Wed, 22 Jan 2020 15:10:26 +0100 [thread overview]
Message-ID: <20200122141026.GA10399@kroah.com> (raw)
In-Reply-To: <1579230628-22243-3-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Fri, Jan 17, 2020 at 11:10:28AM +0800, Wu Hao wrote:
> +static const struct attribute_group fme_perf_fabric_events_group = {
> + .name = "events",
> + .attrs = fme_perf_fabric_events_attrs,
> + .is_visible = fme_perf_fabric_events_visible,
> +};
> +
I don't see any Documentation/ABI/ entries for all of these new files.
Please properly document them so we know how to review this.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Wu Hao <hao.wu@intel.com>
Cc: will@kernel.org, mdf@kernel.org, mark.rutland@arm.com,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, atull@kernel.org,
Luwei Kang <luwei.kang@intel.com>, Xu Yilun <yilun.xu@intel.com>
Subject: Re: [RESEND Patch v6 2/2] fpga: dfl: fme: add performance reporting support
Date: Wed, 22 Jan 2020 15:10:26 +0100 [thread overview]
Message-ID: <20200122141026.GA10399@kroah.com> (raw)
In-Reply-To: <1579230628-22243-3-git-send-email-hao.wu@intel.com>
On Fri, Jan 17, 2020 at 11:10:28AM +0800, Wu Hao wrote:
> +static const struct attribute_group fme_perf_fabric_events_group = {
> + .name = "events",
> + .attrs = fme_perf_fabric_events_attrs,
> + .is_visible = fme_perf_fabric_events_visible,
> +};
> +
I don't see any Documentation/ABI/ entries for all of these new files.
Please properly document them so we know how to review this.
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-22 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 3:10 [RESEND Patch v6 0/2] add performance reporting support to FPGA DFL drivers Wu Hao
2020-01-17 3:10 ` Wu Hao
[not found] ` <1579230628-22243-1-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-01-17 3:10 ` [RESEND Patch v6 1/2] Documentation: fpga: dfl: add description for performance reporting support Wu Hao
2020-01-17 3:10 ` Wu Hao
2020-01-17 3:39 ` [RESEND Patch v6 0/2] add performance reporting support to FPGA DFL drivers Wu Hao
2020-01-17 3:39 ` Wu Hao
2020-01-17 3:10 ` [RESEND Patch v6 2/2] fpga: dfl: fme: add performance reporting support Wu Hao
2020-01-18 2:59 ` kbuild test robot
2020-01-18 6:54 ` kbuild test robot
[not found] ` <1579230628-22243-3-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-01-22 14:10 ` Greg KH [this message]
2020-01-22 14:10 ` Greg KH
[not found] ` <20200122141026.GA10399-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2020-01-23 2:05 ` Wu Hao
2020-01-23 2:05 ` Wu Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122141026.GA10399@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luwei.kang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yilun.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.