All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Lukasz Luba <lukasz.luba@arm.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-imx@nxp.com,
	Morten.Rasmussen@arm.com, Chris.Redpath@arm.com,
	ionela.voinescu@arm.com, javi.merino@arm.com,
	cw00.choi@samsung.com, b.zolnierkie@samsung.com,
	rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org,
	nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com,
	amit.kucheria@verdurent.com, daniel.lezcano@linaro.org,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, festevam@gmail.com,
	kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org,
	bjorn.andersson@linaro.org, robh@kernel.org,
	matthias.bgg@gmail.com, steven.price@arm.com,
	tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com,
	airlied@linux.ie, daniel@ffwll.ch, kernel-team@android.com
Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model
Date: Tue, 21 Jan 2020 09:37:55 +0000	[thread overview]
Message-ID: <20200121093755.GA157387@google.com> (raw)
In-Reply-To: <c9910c74-ab47-0c78-a1c7-4f3978e1dd09@arm.com>

On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote:
> True. But then we hard-code that a CPU device performance domain can
> only be a frequency domain (which is true today).
> 
> The task scheduler (build_perf_domains()) and thermal are already using
> cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework
> would too for CPU devices. I assume that could work with a couple of
> adaptations in Documentation/power/energy-model.rst.

Agreed, and if one day we have a real use case where the pd mask and the
cpufreq policy mask need to be different, we'll do the necessary
changes. But until then I don't see a reason to object to Lukasz'
proposal. So +1 from me.

Thanks,
Quentin

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org,
	peterz@infradead.org, viresh.kumar@linaro.org,
	dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
	bsegall@google.com, alyssa.rosenzweig@collabora.com,
	festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org,
	amit.kucheria@verdurent.com, vincent.guittot@linaro.org,
	khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com,
	steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
	linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com,
	mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de,
	rostedt@goodmis.org, linux-mediatek@lists.infradead.org,
	matthias.bgg@gmail.com, Chris.Redpath@arm.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	airlied@linux.ie, javi.merino@arm.com,
	tomeu.vizoso@collabora.com, sboyd@kernel.org,
	shawnguo@kernel.org, rjw@rjwysocki.net,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	sudeep.holla@arm.com, ionela.voinescu@arm.com,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model
Date: Tue, 21 Jan 2020 09:37:55 +0000	[thread overview]
Message-ID: <20200121093755.GA157387@google.com> (raw)
In-Reply-To: <c9910c74-ab47-0c78-a1c7-4f3978e1dd09@arm.com>

On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote:
> True. But then we hard-code that a CPU device performance domain can
> only be a frequency domain (which is true today).
> 
> The task scheduler (build_perf_domains()) and thermal are already using
> cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework
> would too for CPU devices. I assume that could work with a couple of
> adaptations in Documentation/power/energy-model.rst.

Agreed, and if one day we have a real use case where the pd mask and the
cpufreq policy mask need to be different, we'll do the necessary
changes. But until then I don't see a reason to object to Lukasz'
proposal. So +1 from me.

Thanks,
Quentin

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Lukasz Luba <lukasz.luba@arm.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-imx@nxp.com,
	Morten.Rasmussen@arm.com, Chris.Redpath@arm.com,
	ionela.voinescu@arm.com, javi.merino@arm.com,
	cw00.choi@samsung.com, b.zolnierkie@samsung.com,
	rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org,
	nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com,
	amit.kucheria@verdurent.com, daniel.lezcano@linaro.org,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, festevam@gmail
Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model
Date: Tue, 21 Jan 2020 09:37:55 +0000	[thread overview]
Message-ID: <20200121093755.GA157387@google.com> (raw)
In-Reply-To: <c9910c74-ab47-0c78-a1c7-4f3978e1dd09@arm.com>

On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote:
> True. But then we hard-code that a CPU device performance domain can
> only be a frequency domain (which is true today).
> 
> The task scheduler (build_perf_domains()) and thermal are already using
> cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework
> would too for CPU devices. I assume that could work with a couple of
> adaptations in Documentation/power/energy-model.rst.

Agreed, and if one day we have a real use case where the pd mask and the
cpufreq policy mask need to be different, we'll do the necessary
changes. But until then I don't see a reason to object to Lukasz'
proposal. So +1 from me.

Thanks,
Quentin

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org,
	peterz@infradead.org, viresh.kumar@linaro.org,
	dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
	bsegall@google.com, alyssa.rosenzweig@collabora.com,
	festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org,
	amit.kucheria@verdurent.com, khilman@kernel.org,
	agross@kernel.org, b.zolnierkie@samsung.com,
	steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
	linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com,
	mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de,
	rostedt@goodmis.org, linux-mediatek@lists.infradead.org,
	matthias.bgg@gmail.com, Chris.Redpath@arm.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	airlied@linux.ie, javi.merino@arm.com,
	tomeu.vizoso@collabora.com, sboyd@kernel.org,
	shawnguo@kernel.org, rjw@rjwysocki.net,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	sudeep.holla@arm.com, ionela.voinescu@arm.com,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model
Date: Tue, 21 Jan 2020 09:37:55 +0000	[thread overview]
Message-ID: <20200121093755.GA157387@google.com> (raw)
In-Reply-To: <c9910c74-ab47-0c78-a1c7-4f3978e1dd09@arm.com>

On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote:
> True. But then we hard-code that a CPU device performance domain can
> only be a frequency domain (which is true today).
> 
> The task scheduler (build_perf_domains()) and thermal are already using
> cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework
> would too for CPU devices. I assume that could work with a couple of
> adaptations in Documentation/power/energy-model.rst.

Agreed, and if one day we have a real use case where the pd mask and the
cpufreq policy mask need to be different, we'll do the necessary
changes. But until then I don't see a reason to object to Lukasz'
proposal. So +1 from me.

Thanks,
Quentin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org,
	peterz@infradead.org, viresh.kumar@linaro.org,
	dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
	bsegall@google.com, alyssa.rosenzweig@collabora.com,
	Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com,
	vincent.guittot@linaro.org, khilman@kernel.org,
	agross@kernel.org, b.zolnierkie@samsung.com,
	steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
	linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com,
	mgorman@suse.de, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de,
	rostedt@goodmis.org, linux-mediatek@lists.infradead.org,
	matthias.bgg@gmail.com, Chris.Redpath@arm.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	airlied@linux.ie, javi.merino@arm.com,
	tomeu.vizoso@collabora.com, sboyd@kernel.org,
	shawnguo@kernel.org, rjw@rjwysocki.net,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	sudeep.holla@arm.com, ionela.voinescu@arm.com,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model
Date: Tue, 21 Jan 2020 09:37:55 +0000	[thread overview]
Message-ID: <20200121093755.GA157387@google.com> (raw)
In-Reply-To: <c9910c74-ab47-0c78-a1c7-4f3978e1dd09@arm.com>

On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote:
> True. But then we hard-code that a CPU device performance domain can
> only be a frequency domain (which is true today).
> 
> The task scheduler (build_perf_domains()) and thermal are already using
> cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework
> would too for CPU devices. I assume that could work with a couple of
> adaptations in Documentation/power/energy-model.rst.

Agreed, and if one day we have a real use case where the pd mask and the
cpufreq policy mask need to be different, we'll do the necessary
changes. But until then I don't see a reason to object to Lukasz'
proposal. So +1 from me.

Thanks,
Quentin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-01-21  9:38 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 15:20 [PATCH 0/4] Add support for devices in the Energy Model lukasz.luba
2020-01-16 15:20 ` lukasz.luba
2020-01-16 15:20 ` lukasz.luba
2020-01-16 15:20 ` lukasz.luba
2020-01-16 15:20 ` lukasz.luba
2020-01-16 15:20 ` [PATCH 1/4] PM / EM: and devices to " lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-17 10:54   ` Quentin Perret
2020-01-17 10:54     ` Quentin Perret
2020-01-17 10:54     ` Quentin Perret
2020-01-17 10:54     ` Quentin Perret
2020-01-17 10:54     ` Quentin Perret
2020-01-20 14:52     ` Lukasz Luba
2020-01-20 14:52       ` Lukasz Luba
2020-01-20 14:52       ` Lukasz Luba
2020-01-20 14:52       ` Lukasz Luba
2020-01-20 14:52       ` Lukasz Luba
2020-01-20 15:09       ` Quentin Perret
2020-01-20 15:09         ` Quentin Perret
2020-01-20 15:09         ` Quentin Perret
2020-01-20 15:09         ` Quentin Perret
2020-01-20 15:09         ` Quentin Perret
2020-01-20 18:27         ` Dietmar Eggemann
2020-01-20 18:27           ` Dietmar Eggemann
2020-01-20 18:27           ` Dietmar Eggemann
2020-01-20 18:27           ` Dietmar Eggemann
2020-01-20 18:27           ` Dietmar Eggemann
2020-01-20 18:38           ` Lukasz Luba
2020-01-20 18:38             ` Lukasz Luba
2020-01-20 18:38             ` Lukasz Luba
2020-01-20 18:38             ` Lukasz Luba
2020-01-20 18:38             ` Lukasz Luba
2020-01-21  9:10             ` Dietmar Eggemann
2020-01-21  9:10               ` Dietmar Eggemann
2020-01-21  9:10               ` Dietmar Eggemann
2020-01-21  9:10               ` Dietmar Eggemann
2020-01-21  9:10               ` Dietmar Eggemann
2020-01-21  9:37               ` Quentin Perret [this message]
2020-01-21  9:37                 ` Quentin Perret
2020-01-21  9:37                 ` Quentin Perret
2020-01-21  9:37                 ` Quentin Perret
2020-01-21  9:37                 ` Quentin Perret
2020-01-21  9:31             ` Quentin Perret
2020-01-21  9:31               ` Quentin Perret
2020-01-21  9:31               ` Quentin Perret
2020-01-21  9:31               ` Quentin Perret
2020-01-21  9:31               ` Quentin Perret
2020-01-20 14:53   ` Dietmar Eggemann
2020-01-20 14:53     ` Dietmar Eggemann
2020-01-20 14:53     ` Dietmar Eggemann
2020-01-20 14:53     ` Dietmar Eggemann
2020-01-20 14:53     ` Dietmar Eggemann
2020-01-20 15:11     ` Dietmar Eggemann
2020-01-20 15:11       ` Dietmar Eggemann
2020-01-20 15:11       ` Dietmar Eggemann
2020-01-20 15:11       ` Dietmar Eggemann
2020-01-20 15:11       ` Dietmar Eggemann
2020-01-20 15:36       ` Lukasz Luba
2020-01-20 15:36         ` Lukasz Luba
2020-01-20 15:36         ` Lukasz Luba
2020-01-20 15:36         ` Lukasz Luba
2020-01-20 15:36         ` Lukasz Luba
2020-01-20 15:27     ` Lukasz Luba
2020-01-20 15:27       ` Lukasz Luba
2020-01-20 15:27       ` Lukasz Luba
2020-01-20 15:27       ` Lukasz Luba
2020-01-20 15:27       ` Lukasz Luba
2020-01-20 15:28     ` Quentin Perret
2020-01-20 15:28       ` Quentin Perret
2020-01-20 15:28       ` Quentin Perret
2020-01-20 15:28       ` Quentin Perret
2020-01-20 15:28       ` Quentin Perret
2020-01-20 16:20       ` Lukasz Luba
2020-01-20 16:20         ` Lukasz Luba
2020-01-20 16:20         ` Lukasz Luba
2020-01-20 16:20         ` Lukasz Luba
2020-01-20 16:20         ` Lukasz Luba
2020-01-21 10:08         ` Quentin Perret
2020-01-21 10:08           ` Quentin Perret
2020-01-21 10:08           ` Quentin Perret
2020-01-21 10:08           ` Quentin Perret
2020-01-21 10:08           ` Quentin Perret
2020-01-21 10:49           ` Lukasz Luba
2020-01-21 10:49             ` Lukasz Luba
2020-01-21 10:49             ` Lukasz Luba
2020-01-21 10:49             ` Lukasz Luba
2020-01-21 10:49             ` Lukasz Luba
2020-01-16 15:20 ` [PATCH 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20 ` [PATCH 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-21 17:11   ` Steven Rostedt
2020-01-21 17:11     ` Steven Rostedt
2020-01-21 17:11     ` Steven Rostedt
2020-01-21 17:11     ` Steven Rostedt
2020-01-21 17:11     ` Steven Rostedt
2020-01-22  9:35     ` Lukasz Luba
2020-01-22  9:35       ` Lukasz Luba
2020-01-22  9:35       ` Lukasz Luba
2020-01-22  9:35       ` Lukasz Luba
2020-01-16 15:20 ` [PATCH 4/4] drm/panfrost: Register to the Energy Model with devfreq device lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba
2020-01-16 15:20   ` lukasz.luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121093755.GA157387@google.com \
    --to=qperret@google.com \
    --cc=Chris.Redpath@arm.com \
    --cc=Morten.Rasmussen@arm.com \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=bsegall@google.com \
    --cc=cw00.choi@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=dietmar.eggemann@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@android.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=nm@ti.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=steven.price@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.