All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Justin Swartz <justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 0/2] Add rga to rk322x device tree
Date: Mon, 3 Feb 2020 10:36:38 +0000	[thread overview]
Message-ID: <20200203103638.GA32044@bogus> (raw)
In-Reply-To: <20200121220242.22815-1-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>

On Tue, Jan 21, 2020 at 10:02:39PM +0000, Justin Swartz wrote:
> This patchset aims to enable use of Rockchip's RGA, a 2D raster
> graphic acceleration unit, on rk322x based devices.
> 
> Changed in v3:
>   - Relocate rga node to the correct position in rk322x.dtsi, as
>     indicated by Johan Jonker.
> 
> Changes in v2:
>   - Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
>     string patch, as advised by Ezequiel Garcia.

Why's that? You're using the string still, it needs to be documented.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Justin Swartz <justin.swartz@risingedge.co.za>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] Add rga to rk322x device tree
Date: Mon, 3 Feb 2020 10:36:38 +0000	[thread overview]
Message-ID: <20200203103638.GA32044@bogus> (raw)
In-Reply-To: <20200121220242.22815-1-justin.swartz@risingedge.co.za>

On Tue, Jan 21, 2020 at 10:02:39PM +0000, Justin Swartz wrote:
> This patchset aims to enable use of Rockchip's RGA, a 2D raster
> graphic acceleration unit, on rk322x based devices.
> 
> Changed in v3:
>   - Relocate rga node to the correct position in rk322x.dtsi, as
>     indicated by Johan Jonker.
> 
> Changes in v2:
>   - Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
>     string patch, as advised by Ezequiel Garcia.

Why's that? You're using the string still, it needs to be documented.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Justin Swartz <justin.swartz@risingedge.co.za>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Add rga to rk322x device tree
Date: Mon, 3 Feb 2020 10:36:38 +0000	[thread overview]
Message-ID: <20200203103638.GA32044@bogus> (raw)
In-Reply-To: <20200121220242.22815-1-justin.swartz@risingedge.co.za>

On Tue, Jan 21, 2020 at 10:02:39PM +0000, Justin Swartz wrote:
> This patchset aims to enable use of Rockchip's RGA, a 2D raster
> graphic acceleration unit, on rk322x based devices.
> 
> Changed in v3:
>   - Relocate rga node to the correct position in rk322x.dtsi, as
>     indicated by Johan Jonker.
> 
> Changes in v2:
>   - Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
>     string patch, as advised by Ezequiel Garcia.

Why's that? You're using the string still, it needs to be documented.

Rob

  parent reply	other threads:[~2020-02-03 10:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 19:41 [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Justin Swartz
2020-01-20 19:41 ` Justin Swartz
2020-01-20 19:41 ` Justin Swartz
2020-01-20 19:41 ` [PATCH 2/4] [media] dt-bindings: Add rk3228 to the Rockchip RGA binding doc Justin Swartz
2020-01-20 19:41   ` Justin Swartz
2020-01-20 19:41 ` [PATCH 3/4] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-20 19:41   ` Justin Swartz
2020-01-21 10:45 ` [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Ezequiel Garcia
2020-01-21 10:45   ` Ezequiel Garcia
2020-01-21 11:51   ` Justin Swartz
2020-01-21 11:51     ` Justin Swartz
2020-01-21 13:01   ` Heiko Stuebner
2020-01-21 13:01     ` Heiko Stuebner
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 20:11   ` Justin Swartz
2020-01-21 20:11   ` [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 20:11     ` Justin Swartz
     [not found]     ` <20200121201146.18038-2-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
2020-01-21 21:34       ` Johan Jonker
2020-01-21 21:34         ` Johan Jonker
2020-01-21 21:34         ` Johan Jonker
     [not found]         ` <7d85210b-e554-d875-0615-c2e93a264b5b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-21 21:45           ` Justin Swartz
2020-01-21 21:45             ` Justin Swartz
2020-01-21 21:45             ` Justin Swartz
2020-01-21 20:11   ` [PATCH v2 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-01-21 20:11     ` Justin Swartz
     [not found] ` <20200120194158.25357-1-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
2020-01-20 19:41   ` [PATCH 4/4] ARM: dts: rockchip: add rga to rk3229-xms6 Justin Swartz
2020-01-20 19:41     ` Justin Swartz
2020-01-20 19:41     ` Justin Swartz
2020-01-21 22:02   ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 22:02     ` Justin Swartz
2020-01-21 22:02     ` Justin Swartz
2020-01-21 22:02     ` [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 22:02       ` Justin Swartz
     [not found]     ` <20200121220242.22815-1-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
2020-01-21 22:02       ` [PATCH v3 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-01-21 22:02         ` Justin Swartz
2020-01-21 22:02         ` Justin Swartz
2020-02-03 10:36       ` Rob Herring [this message]
2020-02-03 10:36         ` [PATCH v3 0/2] Add rga to rk322x device tree Rob Herring
2020-02-03 10:36         ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203103638.GA32044@bogus \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.