All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x
Date: Tue, 21 Jan 2020 22:34:38 +0100	[thread overview]
Message-ID: <7d85210b-e554-d875-0615-c2e93a264b5b@gmail.com> (raw)
In-Reply-To: <20200121201146.18038-2-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>

Hi Justin,

rga is now inserted above vpu_mmu.
Please check the address.

rga:       rga@20060000 {
vpu_mmu: iommu@20020800 {

Should go between vop_mmu and iep_mmu.

vop_mmu: iommu@20053f00 {
rga:       rga@20060000 {
iep_mmu: iommu@20070800 {

> Add a node to define the presence of RGA, a 2D raster graphic
> acceleration unit.
> 
> Signed-off-by: Justin Swartz <justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
> ---
>  arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index 340ed6ccb..efa733207 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -566,6 +566,17 @@
>  		status = "disabled";
>  	};
>  
> +	rga: rga@20060000 {
> +		compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
> +		reg = <0x20060000 0x1000>;
> +		interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
> +		clock-names = "aclk", "hclk", "sclk";
> +		resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
> +		reset-names = "core", "axi", "ahb";
> +		status = "disabled";
> +	};
> +
>  	vpu_mmu: iommu@20020800 {
>  		compatible = "rockchip,iommu";
>  		reg = <0x20020800 0x100>;
> -- 
> 2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: justin.swartz@risingedge.co.za
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	heiko@sntech.de, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x
Date: Tue, 21 Jan 2020 22:34:38 +0100	[thread overview]
Message-ID: <7d85210b-e554-d875-0615-c2e93a264b5b@gmail.com> (raw)
In-Reply-To: <20200121201146.18038-2-justin.swartz@risingedge.co.za>

Hi Justin,

rga is now inserted above vpu_mmu.
Please check the address.

rga:       rga@20060000 {
vpu_mmu: iommu@20020800 {

Should go between vop_mmu and iep_mmu.

vop_mmu: iommu@20053f00 {
rga:       rga@20060000 {
iep_mmu: iommu@20070800 {

> Add a node to define the presence of RGA, a 2D raster graphic
> acceleration unit.
> 
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> ---
>  arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index 340ed6ccb..efa733207 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -566,6 +566,17 @@
>  		status = "disabled";
>  	};
>  
> +	rga: rga@20060000 {
> +		compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
> +		reg = <0x20060000 0x1000>;
> +		interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
> +		clock-names = "aclk", "hclk", "sclk";
> +		resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
> +		reset-names = "core", "axi", "ahb";
> +		status = "disabled";
> +	};
> +
>  	vpu_mmu: iommu@20020800 {
>  		compatible = "rockchip,iommu";
>  		reg = <0x20020800 0x100>;
> -- 
> 2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: justin.swartz@risingedge.co.za
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	mark.rutland@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x
Date: Tue, 21 Jan 2020 22:34:38 +0100	[thread overview]
Message-ID: <7d85210b-e554-d875-0615-c2e93a264b5b@gmail.com> (raw)
In-Reply-To: <20200121201146.18038-2-justin.swartz@risingedge.co.za>

Hi Justin,

rga is now inserted above vpu_mmu.
Please check the address.

rga:       rga@20060000 {
vpu_mmu: iommu@20020800 {

Should go between vop_mmu and iep_mmu.

vop_mmu: iommu@20053f00 {
rga:       rga@20060000 {
iep_mmu: iommu@20070800 {

> Add a node to define the presence of RGA, a 2D raster graphic
> acceleration unit.
> 
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> ---
>  arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index 340ed6ccb..efa733207 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -566,6 +566,17 @@
>  		status = "disabled";
>  	};
>  
> +	rga: rga@20060000 {
> +		compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
> +		reg = <0x20060000 0x1000>;
> +		interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
> +		clock-names = "aclk", "hclk", "sclk";
> +		resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
> +		reset-names = "core", "axi", "ahb";
> +		status = "disabled";
> +	};
> +
>  	vpu_mmu: iommu@20020800 {
>  		compatible = "rockchip,iommu";
>  		reg = <0x20020800 0x100>;
> -- 
> 2.11.0


  parent reply	other threads:[~2020-01-21 21:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 19:41 [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Justin Swartz
2020-01-20 19:41 ` Justin Swartz
2020-01-20 19:41 ` Justin Swartz
2020-01-20 19:41 ` [PATCH 2/4] [media] dt-bindings: Add rk3228 to the Rockchip RGA binding doc Justin Swartz
2020-01-20 19:41   ` Justin Swartz
2020-01-20 19:41 ` [PATCH 3/4] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-20 19:41   ` Justin Swartz
2020-01-21 10:45 ` [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Ezequiel Garcia
2020-01-21 10:45   ` Ezequiel Garcia
2020-01-21 11:51   ` Justin Swartz
2020-01-21 11:51     ` Justin Swartz
2020-01-21 13:01   ` Heiko Stuebner
2020-01-21 13:01     ` Heiko Stuebner
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 20:11   ` Justin Swartz
2020-01-21 20:11   ` [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 20:11     ` Justin Swartz
     [not found]     ` <20200121201146.18038-2-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
2020-01-21 21:34       ` Johan Jonker [this message]
2020-01-21 21:34         ` Johan Jonker
2020-01-21 21:34         ` Johan Jonker
     [not found]         ` <7d85210b-e554-d875-0615-c2e93a264b5b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-21 21:45           ` Justin Swartz
2020-01-21 21:45             ` Justin Swartz
2020-01-21 21:45             ` Justin Swartz
2020-01-21 20:11   ` [PATCH v2 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-01-21 20:11     ` Justin Swartz
     [not found] ` <20200120194158.25357-1-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
2020-01-20 19:41   ` [PATCH 4/4] ARM: dts: rockchip: add rga to rk3229-xms6 Justin Swartz
2020-01-20 19:41     ` Justin Swartz
2020-01-20 19:41     ` Justin Swartz
2020-01-21 22:02   ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 22:02     ` Justin Swartz
2020-01-21 22:02     ` Justin Swartz
2020-01-21 22:02     ` [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 22:02       ` Justin Swartz
     [not found]     ` <20200121220242.22815-1-justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org>
2020-01-21 22:02       ` [PATCH v3 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-01-21 22:02         ` Justin Swartz
2020-01-21 22:02         ` Justin Swartz
2020-02-03 10:36       ` [PATCH v3 0/2] Add rga to rk322x device tree Rob Herring
2020-02-03 10:36         ` Rob Herring
2020-02-03 10:36         ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d85210b-e554-d875-0615-c2e93a264b5b@gmail.com \
    --to=jbx6244-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=justin.swartz-4mSLLtuPuFdOJuVFMUvaKw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.