From: Christoph Hellwig <hch@infradead.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
willy@infradead.org, jack@suse.cz
Subject: Re: [patch] dax: pass NOWAIT flag to iomap_apply
Date: Wed, 5 Feb 2020 11:28:02 -0800 [thread overview]
Message-ID: <20200205192802.GA2425@infradead.org> (raw)
In-Reply-To: <x49r1z86e1d.fsf@segfault.boston.devel.redhat.com>
On Wed, Feb 05, 2020 at 02:15:58PM -0500, Jeff Moyer wrote:
> fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o
> dax". The reason is that the initial pwrite to an empty file with the
> RWF_NOWAIT flag set does not return -EAGAIN. It turns out that
> dax_iomap_rw doesn't pass that flag through to iomap_apply.
>
> With this patch applied, generic/471 passes for me.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: dan.j.williams@intel.com, linux-fsdevel@vger.kernel.org,
linux-nvdimm@lists.01.org, willy@infradead.org, jack@suse.cz
Subject: Re: [patch] dax: pass NOWAIT flag to iomap_apply
Date: Wed, 5 Feb 2020 11:28:02 -0800 [thread overview]
Message-ID: <20200205192802.GA2425@infradead.org> (raw)
In-Reply-To: <x49r1z86e1d.fsf@segfault.boston.devel.redhat.com>
On Wed, Feb 05, 2020 at 02:15:58PM -0500, Jeff Moyer wrote:
> fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o
> dax". The reason is that the initial pwrite to an empty file with the
> RWF_NOWAIT flag set does not return -EAGAIN. It turns out that
> dax_iomap_rw doesn't pass that flag through to iomap_apply.
>
> With this patch applied, generic/471 passes for me.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-02-05 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 19:15 [patch] dax: pass NOWAIT flag to iomap_apply Jeff Moyer
2020-02-05 19:15 ` Jeff Moyer
2020-02-05 19:28 ` Christoph Hellwig [this message]
2020-02-05 19:28 ` Christoph Hellwig
2020-02-06 4:52 ` Dan Williams
2020-02-06 4:52 ` Dan Williams
2020-02-06 8:47 ` Jan Kara
2020-02-06 8:47 ` Jan Kara
2020-02-06 14:33 ` Jeff Moyer
2020-02-06 14:33 ` Jeff Moyer
2020-02-06 14:43 ` Jan Kara
2020-02-06 14:43 ` Jan Kara
2020-02-06 15:39 ` Jeff Moyer
2020-02-06 15:39 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205192802.GA2425@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.