All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	kraxel@redhat.com, noralf@tronnes.org, sam@ravnborg.org,
	alexander.deucher@amd.com, emil.velikov@collabora.com
Cc: spice-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH 6/6] drm/simple-pipe: Use simple encoder
Date: Fri,  7 Feb 2020 09:41:35 +0100	[thread overview]
Message-ID: <20200207084135.4524-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20200207084135.4524-1-tzimmermann@suse.de>

The simple-pipe helpers use an empty implementation for the encoder.
Replace the code with the generic simple encoder.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_simple_kms_helper.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c
index 15fb516ae2d8..e16606b3ee20 100644
--- a/drivers/gpu/drm/drm_simple_kms_helper.c
+++ b/drivers/gpu/drm/drm_simple_kms_helper.c
@@ -28,10 +28,6 @@
  * encoder drivers.
  */
 
-static const struct drm_encoder_funcs drm_simple_kms_encoder_funcs = {
-	.destroy = drm_encoder_cleanup,
-};
-
 static enum drm_mode_status
 drm_simple_kms_crtc_mode_valid(struct drm_crtc *crtc,
 			       const struct drm_display_mode *mode)
@@ -288,8 +284,8 @@ int drm_simple_display_pipe_init(struct drm_device *dev,
 		return ret;
 
 	encoder->possible_crtcs = drm_crtc_mask(crtc);
-	ret = drm_encoder_init(dev, encoder, &drm_simple_kms_encoder_funcs,
-			       DRM_MODE_ENCODER_NONE, NULL);
+	ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_NONE,
+				      NULL);
 	if (ret || !connector)
 		return ret;
 
-- 
2.25.0

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	kraxel@redhat.com, noralf@tronnes.org, sam@ravnborg.org,
	alexander.deucher@amd.com, emil.velikov@collabora.com
Cc: spice-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH 6/6] drm/simple-pipe: Use simple encoder
Date: Fri,  7 Feb 2020 09:41:35 +0100	[thread overview]
Message-ID: <20200207084135.4524-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20200207084135.4524-1-tzimmermann@suse.de>

The simple-pipe helpers use an empty implementation for the encoder.
Replace the code with the generic simple encoder.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_simple_kms_helper.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c
index 15fb516ae2d8..e16606b3ee20 100644
--- a/drivers/gpu/drm/drm_simple_kms_helper.c
+++ b/drivers/gpu/drm/drm_simple_kms_helper.c
@@ -28,10 +28,6 @@
  * encoder drivers.
  */
 
-static const struct drm_encoder_funcs drm_simple_kms_encoder_funcs = {
-	.destroy = drm_encoder_cleanup,
-};
-
 static enum drm_mode_status
 drm_simple_kms_crtc_mode_valid(struct drm_crtc *crtc,
 			       const struct drm_display_mode *mode)
@@ -288,8 +284,8 @@ int drm_simple_display_pipe_init(struct drm_device *dev,
 		return ret;
 
 	encoder->possible_crtcs = drm_crtc_mask(crtc);
-	ret = drm_encoder_init(dev, encoder, &drm_simple_kms_encoder_funcs,
-			       DRM_MODE_ENCODER_NONE, NULL);
+	ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_NONE,
+				      NULL);
 	if (ret || !connector)
 		return ret;
 
-- 
2.25.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-02-07  8:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  8:41 [PATCH 0/6] drm: Provide a simple encoder Thomas Zimmermann
2020-02-07  8:41 ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 1/6] drm: Move initialization of encoder into an internal function Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07 10:33   ` Gerd Hoffmann
2020-02-07 10:33     ` Gerd Hoffmann
2020-02-07 10:50     ` Thomas Zimmermann
2020-02-07 10:50       ` Thomas Zimmermann
2020-02-07 12:31       ` Gerd Hoffmann
2020-02-07 12:31         ` Gerd Hoffmann
2020-02-07 13:37   ` Daniel Vetter
2020-02-07 13:37     ` Daniel Vetter
2020-02-07 14:00     ` Ville Syrjälä
2020-02-07 14:00       ` Ville Syrjälä
2020-02-07 14:02     ` Thomas Zimmermann
2020-02-07 14:02       ` Thomas Zimmermann
2020-02-07 16:26       ` Daniel Vetter
2020-02-07 16:26         ` Daniel Vetter
2020-02-07 14:36   ` Noralf Trønnes
2020-02-07 14:36     ` Noralf Trønnes
2020-02-07 16:25     ` Daniel Vetter
2020-02-07 16:25       ` Daniel Vetter
2020-02-10 10:28   ` kbuild test robot
2020-02-10 10:28     ` [PATCH 2/6] drm: Add drm_simple_encoder_{init, create}() kbuild test robot
2020-02-10 10:28     ` [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() kbuild test robot
2020-02-07  8:41 ` [PATCH 3/6] drm/ast: Use simple encoder Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 4/6] drm/mgag200: " Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 5/6] drm/qxl: " Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-10  9:08   ` kbuild test robot
2020-02-10  9:08     ` kbuild test robot
2020-02-10  9:08     ` kbuild test robot
2020-02-07  8:41 ` Thomas Zimmermann [this message]
2020-02-07  8:41   ` [PATCH 6/6] drm/simple-pipe: " Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207084135.4524-7-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=kraxel@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=noralf@tronnes.org \
    --cc=sam@ravnborg.org \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.