All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	alexander.deucher@amd.com, spice-devel@lists.freedesktop.org,
	sam@ravnborg.org, emil.velikov@collabora.com
Subject: Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()
Date: Fri, 7 Feb 2020 16:00:30 +0200	[thread overview]
Message-ID: <20200207140030.GY13686@intel.com> (raw)
In-Reply-To: <20200207133720.GZ43062@phenom.ffwll.local>

On Fri, Feb 07, 2020 at 02:37:20PM +0100, Daniel Vetter wrote:
> On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote:
> > The simple-encoder helpers initialize an encoder with an empty
> > implementation. This covers the requirements of most of the existing
> > DRM drivers. A call to drm_simple_encoder_create() allocates and
> > initializes an encoder instance, a call to drm_simple_encoder_init()
> > initializes a pre-allocated instance.
> > 
> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
> This has quick a bit midlayer taste to it ... I think having this as a
> helper would be cleaner ...
> 
> The other bit is drm_encoder->possible_crtcs. If we do create a helper for
> these, lets at least try to make them not suck too badly :-) Otherwise I
> guess it would be time to officially document what exactly possible_crtcs
> == 0 means from an uabi pov.

I had some improvements for this stuff. Just re-sent the remainder.

-- 
Ville Syrjälä
Intel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org, kraxel@redhat.com,
	Thomas Zimmermann <tzimmermann@suse.de>,
	alexander.deucher@amd.com, spice-devel@lists.freedesktop.org,
	sam@ravnborg.org, emil.velikov@collabora.com
Subject: Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()
Date: Fri, 7 Feb 2020 16:00:30 +0200	[thread overview]
Message-ID: <20200207140030.GY13686@intel.com> (raw)
In-Reply-To: <20200207133720.GZ43062@phenom.ffwll.local>

On Fri, Feb 07, 2020 at 02:37:20PM +0100, Daniel Vetter wrote:
> On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote:
> > The simple-encoder helpers initialize an encoder with an empty
> > implementation. This covers the requirements of most of the existing
> > DRM drivers. A call to drm_simple_encoder_create() allocates and
> > initializes an encoder instance, a call to drm_simple_encoder_init()
> > initializes a pre-allocated instance.
> > 
> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
> This has quick a bit midlayer taste to it ... I think having this as a
> helper would be cleaner ...
> 
> The other bit is drm_encoder->possible_crtcs. If we do create a helper for
> these, lets at least try to make them not suck too badly :-) Otherwise I
> guess it would be time to officially document what exactly possible_crtcs
> == 0 means from an uabi pov.

I had some improvements for this stuff. Just re-sent the remainder.

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-02-07 14:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  8:41 [PATCH 0/6] drm: Provide a simple encoder Thomas Zimmermann
2020-02-07  8:41 ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 1/6] drm: Move initialization of encoder into an internal function Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07 10:33   ` Gerd Hoffmann
2020-02-07 10:33     ` Gerd Hoffmann
2020-02-07 10:50     ` Thomas Zimmermann
2020-02-07 10:50       ` Thomas Zimmermann
2020-02-07 12:31       ` Gerd Hoffmann
2020-02-07 12:31         ` Gerd Hoffmann
2020-02-07 13:37   ` Daniel Vetter
2020-02-07 13:37     ` Daniel Vetter
2020-02-07 14:00     ` Ville Syrjälä [this message]
2020-02-07 14:00       ` Ville Syrjälä
2020-02-07 14:02     ` Thomas Zimmermann
2020-02-07 14:02       ` Thomas Zimmermann
2020-02-07 16:26       ` Daniel Vetter
2020-02-07 16:26         ` Daniel Vetter
2020-02-07 14:36   ` Noralf Trønnes
2020-02-07 14:36     ` Noralf Trønnes
2020-02-07 16:25     ` Daniel Vetter
2020-02-07 16:25       ` Daniel Vetter
2020-02-10 10:28   ` kbuild test robot
2020-02-10 10:28     ` [PATCH 2/6] drm: Add drm_simple_encoder_{init, create}() kbuild test robot
2020-02-10 10:28     ` [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() kbuild test robot
2020-02-07  8:41 ` [PATCH 3/6] drm/ast: Use simple encoder Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 4/6] drm/mgag200: " Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-07  8:41 ` [PATCH 5/6] drm/qxl: " Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann
2020-02-10  9:08   ` kbuild test robot
2020-02-10  9:08     ` kbuild test robot
2020-02-10  9:08     ` kbuild test robot
2020-02-07  8:41 ` [PATCH 6/6] drm/simple-pipe: " Thomas Zimmermann
2020-02-07  8:41   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207140030.GY13686@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=sam@ravnborg.org \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.