From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup
Date: Fri, 7 Feb 2020 17:31:59 +0100 [thread overview]
Message-ID: <20200207163159.GL43062@phenom.ffwll.local> (raw)
In-Reply-To: <02b04868-6f7b-f1cf-9cc7-fd1466b21761@suse.de>
On Fri, Feb 07, 2020 at 03:20:44PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 07.02.20 um 14:59 schrieb Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > It's not at all clear what cloning options this driver supports.
> > So let's just clear possible_clones instead of setting it to some
> > bogus value.
> >
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > index da87c70e413b..a0a709dfba34 100644
> > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
> > encoder->possible_crtcs = crtc_mask;
> >
> > /* FIXME: this is the mask of outputs which can clone this output. */
> > - encoder->possible_clones = ~0;
> > + encoder->possible_clones = 0;
>
> Maybe remove the comment as well. It's pointless.
Maybe change it to "FIXME: cloning support not clear, disable it all for
now". With that
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Best regards
> Thomas
>
> >
> > return 0;
> > }
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup
Date: Fri, 7 Feb 2020 17:31:59 +0100 [thread overview]
Message-ID: <20200207163159.GL43062@phenom.ffwll.local> (raw)
In-Reply-To: <02b04868-6f7b-f1cf-9cc7-fd1466b21761@suse.de>
On Fri, Feb 07, 2020 at 03:20:44PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 07.02.20 um 14:59 schrieb Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > It's not at all clear what cloning options this driver supports.
> > So let's just clear possible_clones instead of setting it to some
> > bogus value.
> >
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > index da87c70e413b..a0a709dfba34 100644
> > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
> > encoder->possible_crtcs = crtc_mask;
> >
> > /* FIXME: this is the mask of outputs which can clone this output. */
> > - encoder->possible_clones = ~0;
> > + encoder->possible_clones = 0;
>
> Maybe remove the comment as well. It's pointless.
Maybe change it to "FIXME: cloning support not clear, disable it all for
now". With that
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Best regards
> Thomas
>
> >
> > return 0;
> > }
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-07 16:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:59 [PATCH v2 0/6] drm: Try to fix encoder possible_clones/crtc Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 13:59 ` [PATCH v2 1/6] drm: Include the encoder itself in possible_clones Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 14:28 ` Thomas Zimmermann
2020-02-07 14:28 ` [Intel-gfx] " Thomas Zimmermann
2020-02-07 14:50 ` Ville Syrjälä
2020-02-07 14:50 ` [Intel-gfx] " Ville Syrjälä
2020-02-07 16:27 ` Daniel Vetter
2020-02-07 16:27 ` Daniel Vetter
2020-02-07 16:34 ` Ville Syrjälä
2020-02-07 16:34 ` Ville Syrjälä
2020-02-07 16:40 ` Daniel Vetter
2020-02-07 16:40 ` Daniel Vetter
2020-02-10 8:16 ` Thomas Zimmermann
2020-02-10 8:16 ` Thomas Zimmermann
2020-02-07 16:36 ` Daniel Vetter
2020-02-07 16:36 ` [Intel-gfx] " Daniel Vetter
2020-02-07 13:59 ` [PATCH v2 2/6] drm/gma500: Sanitize possible_clones Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 16:30 ` Daniel Vetter
2020-02-07 16:30 ` [Intel-gfx] " Daniel Vetter
2020-02-07 13:59 ` [PATCH v2 3/6] drm/exynos: Use drm_encoder_mask() Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 14:19 ` Thomas Zimmermann
2020-02-07 14:19 ` [Intel-gfx] " Thomas Zimmermann
2020-02-07 13:59 ` [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 14:20 ` Thomas Zimmermann
2020-02-07 14:20 ` [Intel-gfx] " Thomas Zimmermann
2020-02-07 16:31 ` Daniel Vetter [this message]
2020-02-07 16:31 ` Daniel Vetter
2020-02-07 13:59 ` [PATCH v2 5/6] drm: Validate encoder->possible_clones Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 14:25 ` Thomas Zimmermann
2020-02-07 14:25 ` [Intel-gfx] " Thomas Zimmermann
2020-02-07 13:59 ` [PATCH v2 6/6] drm: Validate encoder->possible_crtcs Ville Syrjala
2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala
2020-02-07 16:39 ` Daniel Vetter
2020-02-07 16:39 ` [Intel-gfx] " Daniel Vetter
2020-02-07 16:49 ` Ville Syrjälä
2020-02-07 16:49 ` [Intel-gfx] " Ville Syrjälä
2020-02-07 17:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Try to fix encoder possible_clones/crtc (rev2) Patchwork
2020-02-10 16:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207163159.GL43062@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.