[PATCH v3] oeqa: Use --disable-maintainer-mode configure option

[PATCH v3] oeqa: Use --disable-maintainer-mode configure option

[Khem Raj]

since the versions of autotools might differ, and difference in
timestamps for configure and system can result in reconfigure lets avoid
that by touching the configure script to match system time

Avoids
error: newly created file is older than distributed files!

[YOCTO #13779]

Suggested-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
v2: Touch configure to match timestamps with system
    Move the touch cmd to configure step itself
v3: Use --disable-maintainer-mode

 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py b/meta/lib/oeqa/runtime/cases/buildcpio.py
index 4bd72dd37e..d0f91668b2 100644
--- a/meta/lib/oeqa/runtime/cases/buildcpio.py
+++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
     @OEHasPackage(['autoconf'])
     def test_cpio(self):
         self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('--disable-maintainer-mode','')
         self.project.run_make()
         self.project.run_install()
diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py b/meta/lib/oeqa/sdk/cases/buildcpio.py
index b0beafb38f..902e93f623 100644
--- a/meta/lib/oeqa/sdk/cases/buildcpio.py
+++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
             self.assertTrue(os.path.isdir(dirs["source"]))
             os.makedirs(dirs["build"])
 
-            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
+            self._run("cd {build} && {source}/configure --disable-maintainer-mode $CONFIGURE_FLAGS".format(**dirs))
             self._run("cd {build} && make -j".format(**dirs))
             self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
 
diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py b/meta/lib/oeqa/selftest/cases/meta_ide.py
index 809142559a..87cc2844a8 100644
--- a/meta/lib/oeqa/selftest/cases/meta_ide.py
+++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                         "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('--disable-maintainer-mode',''), 0,
                         msg="Running configure failed")
         self.assertEqual(self.project.run_make(), 0,
                         msg="Running make failed")
-- 
2.25.0

✗ patchtest: failure for oeqa: Use --disable-maintainer-mode configure option

[Patchwork]

== Series Details ==

Series: oeqa: Use --disable-maintainer-mode configure option
Revision: 1
URL   : https://patchwork.openembedded.org/series/22483/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 6f6a6bbac6)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH v3] oeqa: Use --disable-maintainer-mode configure option

[Jacob Kroon]

On 2/8/20 3:12 AM, Khem Raj wrote:
> since the versions of autotools might differ, and difference in
> timestamps for configure and system can result in reconfigure lets avoid
> that by touching the configure script to match system time
>

Maybe align commit message with patch, and mention 
--disable-maintainer-mode ?

Jacob

> Avoids
> error: newly created file is older than distributed files!
> 
> [YOCTO #13779]
> 
> Suggested-by: Andre McCurdy <armccurdy@gmail.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v2: Touch configure to match timestamps with system
>      Move the touch cmd to configure step itself
> v3: Use --disable-maintainer-mode
> 
>   meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
>   meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
>   meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py b/meta/lib/oeqa/runtime/cases/buildcpio.py
> index 4bd72dd37e..d0f91668b2 100644
> --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
>       @OEHasPackage(['autoconf'])
>       def test_cpio(self):
>           self.project.download_archive()
> -        self.project.run_configure()
> +        self.project.run_configure('--disable-maintainer-mode','')
>           self.project.run_make()
>           self.project.run_install()
> diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py b/meta/lib/oeqa/sdk/cases/buildcpio.py
> index b0beafb38f..902e93f623 100644
> --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> @@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
>               self.assertTrue(os.path.isdir(dirs["source"]))
>               os.makedirs(dirs["build"])
>   
> -            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
> +            self._run("cd {build} && {source}/configure --disable-maintainer-mode $CONFIGURE_FLAGS".format(**dirs))
>               self._run("cd {build} && make -j".format(**dirs))
>               self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
>   
> diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py b/meta/lib/oeqa/selftest/cases/meta_ide.py
> index 809142559a..87cc2844a8 100644
> --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
>                           "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
>                           self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
>           self.project.download_archive()
> -        self.assertEqual(self.project.run_configure(), 0,
> +        self.assertEqual(self.project.run_configure('--disable-maintainer-mode',''), 0,
>                           msg="Running configure failed")
>           self.assertEqual(self.project.run_make(), 0,
>                           msg="Running make failed")
> 

Re: [PATCH v3] oeqa: Use --disable-maintainer-mode configure option

[Richard Purdie]

On Fri, 2020-02-07 at 18:12 -0800, Khem Raj wrote:
> since the versions of autotools might differ, and difference in
> timestamps for configure and system can result in reconfigure lets
> avoid
> that by touching the configure script to match system time
> 
> Avoids
> error: newly created file is older than distributed files!
> 
> [YOCTO #13779]
> 
> Suggested-by: Andre McCurdy <armccurdy@gmail.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v2: Touch configure to match timestamps with system
>     Move the touch cmd to configure step itself
> v3: Use --disable-maintainer-mode

I tweaked the commit message but it failed during testing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/1545
https://autobuilder.yoctoproject.org/typhoon/#/builders/73/builds/1541
(and on other arches too)

Cheers,

Richard