From: Mark Brown <broonie@kernel.org>
To: Adam Serbinski <adam@serbinski.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 8/8] ASoC: qcom: apq8096: add kcontrols to set PCM rate
Date: Mon, 10 Feb 2020 20:08:39 +0000 [thread overview]
Message-ID: <20200210200839.GG14166@sirena.org.uk> (raw)
In-Reply-To: <f88d21773f47f5a543a17ad07d66f9b7@serbinski.com>
[-- Attachment #1.1: Type: text/plain, Size: 1001 bytes --]
On Mon, Feb 10, 2020 at 03:00:55PM -0500, Adam Serbinski wrote:
> On 2020-02-10 13:26, Mark Brown wrote:
> > To repeat my comment on another patch in the series there should still
> > be some representation of the DAI for this device in the kernel.
> Respectfully, I'm not sure I understand what it is that you are suggesting.
> Is it your intention to suggest that instead of adding controls to the
> machine driver, I should instead write a codec driver to contain those
> controls?
I have already separately said that you should write a CODEC driver for
this CODEC. I'm saying that this seems like the sort of thing that
might fit in that CODEC driver.
> Or is it your intention to suggest that something within the kernel is
> already aware of the rate to be set, and it is that which should set the
> rate rather than a control?
That would be one example of how such a CODEC driver could be
configured, and is how other baseband/BT devices have ended up going
(see cx20442.c for example).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Adam Serbinski <adam@serbinski.com>
Cc: Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Patrick Lai <plai@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/8] ASoC: qcom: apq8096: add kcontrols to set PCM rate
Date: Mon, 10 Feb 2020 20:08:39 +0000 [thread overview]
Message-ID: <20200210200839.GG14166@sirena.org.uk> (raw)
In-Reply-To: <f88d21773f47f5a543a17ad07d66f9b7@serbinski.com>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
On Mon, Feb 10, 2020 at 03:00:55PM -0500, Adam Serbinski wrote:
> On 2020-02-10 13:26, Mark Brown wrote:
> > To repeat my comment on another patch in the series there should still
> > be some representation of the DAI for this device in the kernel.
> Respectfully, I'm not sure I understand what it is that you are suggesting.
> Is it your intention to suggest that instead of adding controls to the
> machine driver, I should instead write a codec driver to contain those
> controls?
I have already separately said that you should write a CODEC driver for
this CODEC. I'm saying that this seems like the sort of thing that
might fit in that CODEC driver.
> Or is it your intention to suggest that something within the kernel is
> already aware of the rate to be set, and it is that which should set the
> rate rather than a control?
That would be one example of how such a CODEC driver could be
configured, and is how other baseband/BT devices have ended up going
(see cx20442.c for example).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-10 20:09 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:50 [alsa-devel] [PATCH 0/8] ASoC: qdsp6: db820c: Add support for external and bluetooth audio Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 1/8] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 2/8] ASoC: qdsp6: q6afe: add support to pcm ports Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 4/8] ASoC: qdsp6: q6routing: add pcm port routing Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 5/8] ASoC: qcom: apq8096: add support for primary and quaternary I2S/PCM Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 6/8] ASoC: qcom/common: Use snd-soc-dummy-dai when codec is not specified Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 7/8] dts: msm8996/db820c: enable primary pcm and quaternary i2s Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-08 23:42 ` [alsa-devel] " Bjorn Andersson
2020-02-08 23:42 ` Bjorn Andersson
2020-02-07 20:50 ` [alsa-devel] [PATCH 8/8] ASoC: qcom: apq8096: add kcontrols to set PCM rate Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 0/8] ASoC: qdsp6: db820c: Add support for external and bluetooth audio Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 1/8] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 17:13 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:13 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 2/8] ASoC: qdsp6: q6afe: add support to pcm ports Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:31 ` [alsa-devel] " Mark Brown
2020-02-10 13:31 ` Mark Brown
2020-02-10 14:50 ` [alsa-devel] " Adam Serbinski
2020-02-10 14:50 ` Adam Serbinski
2020-02-10 17:13 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:13 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:34 ` [alsa-devel] " Mark Brown
2020-02-10 13:34 ` Mark Brown
2020-02-10 17:13 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:13 ` Srinivas Kandagatla
2020-02-10 17:22 ` [alsa-devel] " Adam Serbinski
2020-02-10 17:22 ` Adam Serbinski
2020-02-10 17:40 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:40 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 4/8] ASoC: qdsp6: q6routing: add pcm port routing Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 17:19 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:19 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 5/8] ASoC: qcom: apq8096: add support for primary and quaternary I2S/PCM Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 6/8] ASoC: qcom/common: Use snd-soc-dummy-dai when codec is not specified Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:35 ` [alsa-devel] " Mark Brown
2020-02-10 13:35 ` Mark Brown
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 7/8] arm64: dts: qcom: db820c: Enable primary PCM and quaternary I2S Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 8/8] ASoC: qcom: apq8096: add kcontrols to set PCM rate Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:36 ` [alsa-devel] " Mark Brown
2020-02-10 13:36 ` Mark Brown
2020-02-10 15:45 ` [alsa-devel] " Adam Serbinski
2020-02-10 15:45 ` Adam Serbinski
2020-02-10 18:26 ` [alsa-devel] " Mark Brown
2020-02-10 18:26 ` Mark Brown
2020-02-10 20:00 ` [alsa-devel] " Adam Serbinski
2020-02-10 20:00 ` Adam Serbinski
2020-02-10 20:08 ` Mark Brown [this message]
2020-02-10 20:08 ` Mark Brown
2020-02-10 21:13 ` [alsa-devel] " Adam Serbinski
2020-02-10 21:13 ` Adam Serbinski
2020-02-11 11:42 ` [alsa-devel] " Mark Brown
2020-02-11 11:42 ` Mark Brown
2020-02-11 13:52 ` [alsa-devel] " Adam Serbinski
2020-02-11 13:52 ` Adam Serbinski
2020-02-10 16:18 ` [alsa-devel] " Jaroslav Kysela
2020-02-10 16:18 ` Jaroslav Kysela
2020-02-10 17:13 ` [alsa-devel] " Adam Serbinski
2020-02-10 17:13 ` Adam Serbinski
2020-02-10 12:17 ` [alsa-devel] [PATCH v2 0/8] ASoC: qdsp6: db820c: Add support for external and bluetooth audio Mark Brown
2020-02-10 12:17 ` Mark Brown
2020-02-10 13:44 ` [alsa-devel] " Adam Serbinski
2020-02-10 13:44 ` Adam Serbinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210200839.GG14166@sirena.org.uk \
--to=broonie@kernel.org \
--cc=adam@serbinski.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.