From: Adam Serbinski <adam@serbinski.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>, Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais
Date: Mon, 10 Feb 2020 12:22:25 -0500 [thread overview]
Message-ID: <616e3042f46cb7f052fc71e0ba4919a2@serbinski.com> (raw)
In-Reply-To: <d0437f6d-84c8-e1cd-b6f5-c1009e00245d@linaro.org>
On 2020-02-10 12:13, Srinivas Kandagatla wrote:
> Few minor comments
>
>> +static int q6afe_tdm_set_sysclk(struct snd_soc_dai *dai,
>> + int clk_id, unsigned int freq, int dir)
>> +{
>
> Why are we adding exactly duplicate function of q6afe_mi2s_set_sysclk
> here?
It isn't an exact duplicate.
The reason I split off the new function is because the clock IDs for PCM
overlap/duplicate the clock IDs for TDM, yet the parameters to
q6afe_port_set_sysclk are not the same for PCM and TDM.
>> + SND_SOC_DAPM_AIF_IN("QUAT_PCM_RX", NULL,
>> + 0, 0, 0, 0),
>
> This can be in single line, same for below
I will adjust these.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Adam Serbinski <adam@serbinski.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Patrick Lai <plai@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais
Date: Mon, 10 Feb 2020 12:22:25 -0500 [thread overview]
Message-ID: <616e3042f46cb7f052fc71e0ba4919a2@serbinski.com> (raw)
In-Reply-To: <d0437f6d-84c8-e1cd-b6f5-c1009e00245d@linaro.org>
On 2020-02-10 12:13, Srinivas Kandagatla wrote:
> Few minor comments
>
>> +static int q6afe_tdm_set_sysclk(struct snd_soc_dai *dai,
>> + int clk_id, unsigned int freq, int dir)
>> +{
>
> Why are we adding exactly duplicate function of q6afe_mi2s_set_sysclk
> here?
It isn't an exact duplicate.
The reason I split off the new function is because the clock IDs for PCM
overlap/duplicate the clock IDs for TDM, yet the parameters to
q6afe_port_set_sysclk are not the same for PCM and TDM.
>> + SND_SOC_DAPM_AIF_IN("QUAT_PCM_RX", NULL,
>> + 0, 0, 0, 0),
>
> This can be in single line, same for below
I will adjust these.
next prev parent reply other threads:[~2020-02-10 17:23 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:50 [alsa-devel] [PATCH 0/8] ASoC: qdsp6: db820c: Add support for external and bluetooth audio Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 1/8] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 2/8] ASoC: qdsp6: q6afe: add support to pcm ports Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 4/8] ASoC: qdsp6: q6routing: add pcm port routing Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 5/8] ASoC: qcom: apq8096: add support for primary and quaternary I2S/PCM Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 6/8] ASoC: qcom/common: Use snd-soc-dummy-dai when codec is not specified Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-07 20:50 ` [alsa-devel] [PATCH 7/8] dts: msm8996/db820c: enable primary pcm and quaternary i2s Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-08 23:42 ` [alsa-devel] " Bjorn Andersson
2020-02-08 23:42 ` Bjorn Andersson
2020-02-07 20:50 ` [alsa-devel] [PATCH 8/8] ASoC: qcom: apq8096: add kcontrols to set PCM rate Adam Serbinski
2020-02-07 20:50 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 0/8] ASoC: qdsp6: db820c: Add support for external and bluetooth audio Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 1/8] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 17:13 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:13 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 2/8] ASoC: qdsp6: q6afe: add support to pcm ports Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:31 ` [alsa-devel] " Mark Brown
2020-02-10 13:31 ` Mark Brown
2020-02-10 14:50 ` [alsa-devel] " Adam Serbinski
2020-02-10 14:50 ` Adam Serbinski
2020-02-10 17:13 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:13 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:34 ` [alsa-devel] " Mark Brown
2020-02-10 13:34 ` Mark Brown
2020-02-10 17:13 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:13 ` Srinivas Kandagatla
2020-02-10 17:22 ` Adam Serbinski [this message]
2020-02-10 17:22 ` Adam Serbinski
2020-02-10 17:40 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:40 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 4/8] ASoC: qdsp6: q6routing: add pcm port routing Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 17:19 ` [alsa-devel] " Srinivas Kandagatla
2020-02-10 17:19 ` Srinivas Kandagatla
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 5/8] ASoC: qcom: apq8096: add support for primary and quaternary I2S/PCM Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 6/8] ASoC: qcom/common: Use snd-soc-dummy-dai when codec is not specified Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:35 ` [alsa-devel] " Mark Brown
2020-02-10 13:35 ` Mark Brown
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 7/8] arm64: dts: qcom: db820c: Enable primary PCM and quaternary I2S Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-09 15:47 ` [alsa-devel] [PATCH v2 8/8] ASoC: qcom: apq8096: add kcontrols to set PCM rate Adam Serbinski
2020-02-09 15:47 ` Adam Serbinski
2020-02-10 13:36 ` [alsa-devel] " Mark Brown
2020-02-10 13:36 ` Mark Brown
2020-02-10 15:45 ` [alsa-devel] " Adam Serbinski
2020-02-10 15:45 ` Adam Serbinski
2020-02-10 18:26 ` [alsa-devel] " Mark Brown
2020-02-10 18:26 ` Mark Brown
2020-02-10 20:00 ` [alsa-devel] " Adam Serbinski
2020-02-10 20:00 ` Adam Serbinski
2020-02-10 20:08 ` [alsa-devel] " Mark Brown
2020-02-10 20:08 ` Mark Brown
2020-02-10 21:13 ` [alsa-devel] " Adam Serbinski
2020-02-10 21:13 ` Adam Serbinski
2020-02-11 11:42 ` [alsa-devel] " Mark Brown
2020-02-11 11:42 ` Mark Brown
2020-02-11 13:52 ` [alsa-devel] " Adam Serbinski
2020-02-11 13:52 ` Adam Serbinski
2020-02-10 16:18 ` [alsa-devel] " Jaroslav Kysela
2020-02-10 16:18 ` Jaroslav Kysela
2020-02-10 17:13 ` [alsa-devel] " Adam Serbinski
2020-02-10 17:13 ` Adam Serbinski
2020-02-10 12:17 ` [alsa-devel] [PATCH v2 0/8] ASoC: qdsp6: db820c: Add support for external and bluetooth audio Mark Brown
2020-02-10 12:17 ` Mark Brown
2020-02-10 13:44 ` [alsa-devel] " Adam Serbinski
2020-02-10 13:44 ` Adam Serbinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616e3042f46cb7f052fc71e0ba4919a2@serbinski.com \
--to=adam@serbinski.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.