From: Andrey Lebedev <andrey.lebedev@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: airlied@linux.ie, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrey Lebedev <andrey@lebedev.lt>,
wens@csie.org, daniel@ffwll.ch,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20
Date: Thu, 13 Feb 2020 22:08:23 +0200 [thread overview]
Message-ID: <20200213200823.GA28336@kedthinkpad> (raw)
In-Reply-To: <20200213094304.hf3glhgmquypxpyf@gilmour.lan>
On Thu, Feb 13, 2020 at 10:43:04AM +0100, Maxime Ripard wrote:
> On Thu, Feb 13, 2020 at 12:23:57AM +0200, andrey.lebedev@gmail.com wrote:
> > From: Andrey Lebedev <andrey@lebedev.lt>
> >
> > Define pins for LVDS channels 0 and 1, configure reset line for tcon0 and
> > provide sample LVDS panel, connected to tcon0.
> >
> > Signed-off-by: Andrey Lebedev <andrey@lebedev.lt>
>
> And this prefix should be ARM: dts: sun7i ;)
Ah, thanks, I think I've got the pattern now!
> > + /omit-if-no-ref/
> > + lcd_lvds0_pins: lcd_lvds0_pins {
>
> underscores in the node names will create a dtc warning at
> compilation, you should use lcd-lvds0-pins instead.
You're right, I wasn't following the naming convention here. dtc doesn't
produce any warning on this though. Fixed that anyway.
> This will create a spurious warning message for TCON1, since we
> adjusted the driver to tell it supports LVDS, but there's no LVDS
> reset line, so we need to make it finer grained.
Yes, I can attribute two of the messages in my dmesg log [1] to this
("Missing LVDS properties" and "LVDS output disabled". "sun4i-tcon
1c0d000.lcd-controller" is indeed tcon1). And yes, I can see how they
can be confusing to someone.
I'd need some pointers on how to deal with that though (if we want to do
it in this scope).
[1] excerpt from kernel boot log:
[ 4.890975] sun4i-drm display-engine: bound 1e00000.display-frontend (ops sun4i_frontend_driver_exit [sun4i_frontend])
[ 4.902032] sun4i-drm display-engine: bound 1e20000.display-frontend (ops sun4i_frontend_driver_exit [sun4i_frontend])
[ 4.913467] sun4i-drm display-engine: bound 1e60000.display-backend (ops sun4i_backend_ops [sun4i_backend])
[ 4.923806] sun4i-drm display-engine: bound 1e40000.display-backend (ops sun4i_backend_ops [sun4i_backend])
[ 4.934451] sun4i-drm display-engine: bound 1c0c000.lcd-controller (ops sun4i_tcon_platform_driver_exit [sun4i_tcon])
[ 4.945254] sun4i-tcon 1c0d000.lcd-controller: Missing LVDS properties, Please upgrade your DT
[ 4.953935] sun4i-tcon 1c0d000.lcd-controller: LVDS output disabled
[ 4.960857] sun4i-drm display-engine: No panel or bridge found... RGB output disabled
[ 4.968845] sun4i-drm display-engine: bound 1c0d000.lcd-controller (ops sun4i_tcon_platform_driver_exit [sun4i_tcon])
[ 5.080874] sun4i-drm display-engine: bound 1c16000.hdmi (ops sun4i_hdmi_driver_exit [sun4i_drm_hdmi])
[ 5.110087] [drm] Initialized sun4i-drm 1.0.0 20150629 for display-engine on minor 0
[ 5.763064] sun4i-drm display-engine: fb0: sun4i-drmdrmfb frame buffer device
--
Andrey Lebedev aka -.- . -.. -.. . .-.
Software engineer
Homepage: http://lebedev.lt/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Lebedev <andrey.lebedev@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: airlied@linux.ie, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrey Lebedev <andrey@lebedev.lt>,
wens@csie.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20
Date: Thu, 13 Feb 2020 22:08:23 +0200 [thread overview]
Message-ID: <20200213200823.GA28336@kedthinkpad> (raw)
In-Reply-To: <20200213094304.hf3glhgmquypxpyf@gilmour.lan>
On Thu, Feb 13, 2020 at 10:43:04AM +0100, Maxime Ripard wrote:
> On Thu, Feb 13, 2020 at 12:23:57AM +0200, andrey.lebedev@gmail.com wrote:
> > From: Andrey Lebedev <andrey@lebedev.lt>
> >
> > Define pins for LVDS channels 0 and 1, configure reset line for tcon0 and
> > provide sample LVDS panel, connected to tcon0.
> >
> > Signed-off-by: Andrey Lebedev <andrey@lebedev.lt>
>
> And this prefix should be ARM: dts: sun7i ;)
Ah, thanks, I think I've got the pattern now!
> > + /omit-if-no-ref/
> > + lcd_lvds0_pins: lcd_lvds0_pins {
>
> underscores in the node names will create a dtc warning at
> compilation, you should use lcd-lvds0-pins instead.
You're right, I wasn't following the naming convention here. dtc doesn't
produce any warning on this though. Fixed that anyway.
> This will create a spurious warning message for TCON1, since we
> adjusted the driver to tell it supports LVDS, but there's no LVDS
> reset line, so we need to make it finer grained.
Yes, I can attribute two of the messages in my dmesg log [1] to this
("Missing LVDS properties" and "LVDS output disabled". "sun4i-tcon
1c0d000.lcd-controller" is indeed tcon1). And yes, I can see how they
can be confusing to someone.
I'd need some pointers on how to deal with that though (if we want to do
it in this scope).
[1] excerpt from kernel boot log:
[ 4.890975] sun4i-drm display-engine: bound 1e00000.display-frontend (ops sun4i_frontend_driver_exit [sun4i_frontend])
[ 4.902032] sun4i-drm display-engine: bound 1e20000.display-frontend (ops sun4i_frontend_driver_exit [sun4i_frontend])
[ 4.913467] sun4i-drm display-engine: bound 1e60000.display-backend (ops sun4i_backend_ops [sun4i_backend])
[ 4.923806] sun4i-drm display-engine: bound 1e40000.display-backend (ops sun4i_backend_ops [sun4i_backend])
[ 4.934451] sun4i-drm display-engine: bound 1c0c000.lcd-controller (ops sun4i_tcon_platform_driver_exit [sun4i_tcon])
[ 4.945254] sun4i-tcon 1c0d000.lcd-controller: Missing LVDS properties, Please upgrade your DT
[ 4.953935] sun4i-tcon 1c0d000.lcd-controller: LVDS output disabled
[ 4.960857] sun4i-drm display-engine: No panel or bridge found... RGB output disabled
[ 4.968845] sun4i-drm display-engine: bound 1c0d000.lcd-controller (ops sun4i_tcon_platform_driver_exit [sun4i_tcon])
[ 5.080874] sun4i-drm display-engine: bound 1c16000.hdmi (ops sun4i_hdmi_driver_exit [sun4i_drm_hdmi])
[ 5.110087] [drm] Initialized sun4i-drm 1.0.0 20150629 for display-engine on minor 0
[ 5.763064] sun4i-drm display-engine: fb0: sun4i-drmdrmfb frame buffer device
--
Andrey Lebedev aka -.- . -.. -.. . .-.
Software engineer
Homepage: http://lebedev.lt/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Lebedev <andrey.lebedev@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Andrey Lebedev <andrey@lebedev.lt>
Subject: Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20
Date: Thu, 13 Feb 2020 22:08:23 +0200 [thread overview]
Message-ID: <20200213200823.GA28336@kedthinkpad> (raw)
In-Reply-To: <20200213094304.hf3glhgmquypxpyf@gilmour.lan>
On Thu, Feb 13, 2020 at 10:43:04AM +0100, Maxime Ripard wrote:
> On Thu, Feb 13, 2020 at 12:23:57AM +0200, andrey.lebedev@gmail.com wrote:
> > From: Andrey Lebedev <andrey@lebedev.lt>
> >
> > Define pins for LVDS channels 0 and 1, configure reset line for tcon0 and
> > provide sample LVDS panel, connected to tcon0.
> >
> > Signed-off-by: Andrey Lebedev <andrey@lebedev.lt>
>
> And this prefix should be ARM: dts: sun7i ;)
Ah, thanks, I think I've got the pattern now!
> > + /omit-if-no-ref/
> > + lcd_lvds0_pins: lcd_lvds0_pins {
>
> underscores in the node names will create a dtc warning at
> compilation, you should use lcd-lvds0-pins instead.
You're right, I wasn't following the naming convention here. dtc doesn't
produce any warning on this though. Fixed that anyway.
> This will create a spurious warning message for TCON1, since we
> adjusted the driver to tell it supports LVDS, but there's no LVDS
> reset line, so we need to make it finer grained.
Yes, I can attribute two of the messages in my dmesg log [1] to this
("Missing LVDS properties" and "LVDS output disabled". "sun4i-tcon
1c0d000.lcd-controller" is indeed tcon1). And yes, I can see how they
can be confusing to someone.
I'd need some pointers on how to deal with that though (if we want to do
it in this scope).
[1] excerpt from kernel boot log:
[ 4.890975] sun4i-drm display-engine: bound 1e00000.display-frontend (ops sun4i_frontend_driver_exit [sun4i_frontend])
[ 4.902032] sun4i-drm display-engine: bound 1e20000.display-frontend (ops sun4i_frontend_driver_exit [sun4i_frontend])
[ 4.913467] sun4i-drm display-engine: bound 1e60000.display-backend (ops sun4i_backend_ops [sun4i_backend])
[ 4.923806] sun4i-drm display-engine: bound 1e40000.display-backend (ops sun4i_backend_ops [sun4i_backend])
[ 4.934451] sun4i-drm display-engine: bound 1c0c000.lcd-controller (ops sun4i_tcon_platform_driver_exit [sun4i_tcon])
[ 4.945254] sun4i-tcon 1c0d000.lcd-controller: Missing LVDS properties, Please upgrade your DT
[ 4.953935] sun4i-tcon 1c0d000.lcd-controller: LVDS output disabled
[ 4.960857] sun4i-drm display-engine: No panel or bridge found... RGB output disabled
[ 4.968845] sun4i-drm display-engine: bound 1c0d000.lcd-controller (ops sun4i_tcon_platform_driver_exit [sun4i_tcon])
[ 5.080874] sun4i-drm display-engine: bound 1c16000.hdmi (ops sun4i_hdmi_driver_exit [sun4i_drm_hdmi])
[ 5.110087] [drm] Initialized sun4i-drm 1.0.0 20150629 for display-engine on minor 0
[ 5.763064] sun4i-drm display-engine: fb0: sun4i-drmdrmfb frame buffer device
--
Andrey Lebedev aka -.- . -.. -.. . .-.
Software engineer
Homepage: http://lebedev.lt/
next prev parent reply other threads:[~2020-02-13 20:08 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 19:56 [PATCH 1/1] Support LVDS output on Allwinner A20 Andrey Lebedev
2020-02-10 19:56 ` Andrey Lebedev
2020-02-10 19:56 ` Andrey Lebedev
2020-02-11 7:20 ` Maxime Ripard
2020-02-11 7:20 ` Maxime Ripard
2020-02-11 7:20 ` Maxime Ripard
2020-02-11 20:48 ` Andrey Lebedev
2020-02-11 20:48 ` Andrey Lebedev
2020-02-11 20:48 ` Andrey Lebedev
2020-02-12 12:53 ` Maxime Ripard
2020-02-12 12:53 ` Maxime Ripard
2020-02-12 12:53 ` Maxime Ripard
2020-02-12 22:46 ` Andrey Lebedev
2020-02-12 22:46 ` Andrey Lebedev
2020-02-12 22:46 ` Andrey Lebedev
2020-02-13 9:24 ` Maxime Ripard
2020-02-13 9:24 ` Maxime Ripard
2020-02-13 9:24 ` Maxime Ripard
2020-02-13 18:11 ` Andrey Lebedev
2020-02-13 18:11 ` Andrey Lebedev
2020-02-13 18:11 ` Andrey Lebedev
2020-02-14 7:58 ` Maxime Ripard
2020-02-14 7:58 ` Maxime Ripard
2020-02-14 7:58 ` Maxime Ripard
2020-02-12 22:23 ` [PATCH v2 1/2] ARM: sun7i: " andrey.lebedev
2020-02-12 22:23 ` andrey.lebedev
2020-02-12 22:23 ` andrey.lebedev
2020-02-13 9:32 ` Maxime Ripard
2020-02-13 9:32 ` Maxime Ripard
2020-02-13 9:32 ` Maxime Ripard
2020-02-12 22:23 ` [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20 andrey.lebedev
2020-02-12 22:23 ` andrey.lebedev
2020-02-12 22:23 ` andrey.lebedev
2020-02-13 9:43 ` Maxime Ripard
2020-02-13 9:43 ` Maxime Ripard
2020-02-13 9:43 ` Maxime Ripard
2020-02-13 20:08 ` Andrey Lebedev [this message]
2020-02-13 20:08 ` Andrey Lebedev
2020-02-13 20:08 ` Andrey Lebedev
2020-02-14 7:52 ` Maxime Ripard
2020-02-14 7:52 ` Maxime Ripard
2020-02-14 7:52 ` Maxime Ripard
2020-02-14 8:43 ` Andrey Lebedev
2020-02-14 8:43 ` Andrey Lebedev
2020-02-14 8:43 ` Andrey Lebedev
2020-02-14 8:53 ` Maxime Ripard
2020-02-14 8:53 ` Maxime Ripard
2020-02-14 8:53 ` Maxime Ripard
2020-02-14 21:32 ` Andrey Lebedev
2020-02-14 21:32 ` Andrey Lebedev
2020-02-14 21:32 ` Andrey Lebedev
2020-02-17 17:51 ` Maxime Ripard
2020-02-17 17:51 ` Maxime Ripard
2020-02-17 17:51 ` Maxime Ripard
2020-02-18 17:50 ` Andrey Lebedev
2020-02-18 17:50 ` Andrey Lebedev
2020-02-18 17:50 ` Andrey Lebedev
2020-02-19 12:06 ` Maxime Ripard
2020-02-19 12:06 ` Maxime Ripard
2020-02-19 12:06 ` Maxime Ripard
2020-02-13 20:18 ` [PATCH v3 1/3] drm/sun4i: tcon: Introduce LVDS setup routine setting Andrey Lebedev
2020-02-13 20:18 ` Andrey Lebedev
2020-02-13 20:18 ` Andrey Lebedev
2020-02-13 20:18 ` [PATCH v3 2/3] drm/sun4i: tcon: Support LVDS output on Allwinner A20 Andrey Lebedev
2020-02-13 20:18 ` Andrey Lebedev
2020-02-13 20:18 ` Andrey Lebedev
2020-02-13 20:18 ` [PATCH v3 3/3] ARM: dts: sun7i: Add LVDS panel support on A20 Andrey Lebedev
2020-02-13 20:18 ` Andrey Lebedev
2020-02-13 20:18 ` Andrey Lebedev
2020-02-14 8:55 ` Maxime Ripard
2020-02-14 8:55 ` Maxime Ripard
2020-02-14 8:55 ` Maxime Ripard
2020-02-19 18:08 ` PATCH v4 Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` [PATCH 1/5] drm/sun4i: tcon: Introduce LVDS setup routine setting Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-20 17:21 ` Maxime Ripard
2020-02-20 17:21 ` Maxime Ripard
2020-02-20 17:21 ` Maxime Ripard
2020-02-20 18:19 ` Andrey Lebedev
2020-02-20 18:19 ` Andrey Lebedev
2020-02-20 18:19 ` Andrey Lebedev
2020-02-19 18:08 ` [PATCH 2/5] drm/sun4i: tcon: Separate quirks for tcon0 and tcon1 on A20 Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-20 17:22 ` Maxime Ripard
2020-02-20 17:22 ` Maxime Ripard
2020-02-20 17:22 ` Maxime Ripard
2020-02-19 18:08 ` [PATCH 3/5] ARM: dts: sun7i: Add LVDS panel support " Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-20 17:23 ` Maxime Ripard
2020-02-20 17:23 ` Maxime Ripard
2020-02-20 17:23 ` Maxime Ripard
2020-02-19 18:08 ` [PATCH 4/5] dt-bindings: display: sun4i: New compatibles for A20 tcons Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-20 17:24 ` Maxime Ripard
2020-02-20 17:24 ` Maxime Ripard
2020-02-20 17:24 ` Maxime Ripard
2020-02-19 18:08 ` [PATCH 5/5] drm/sun4i: tcon: Support LVDS output on Allwinner A20 Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-19 18:08 ` Andrey Lebedev
2020-02-20 17:25 ` Maxime Ripard
2020-02-20 17:25 ` Maxime Ripard
2020-02-20 17:25 ` Maxime Ripard
2020-04-01 10:59 ` Andrey Lebedev
2020-04-01 10:59 ` Andrey Lebedev
2020-04-01 10:59 ` Andrey Lebedev
2020-04-01 12:14 ` Maxime Ripard
2020-04-01 12:14 ` Maxime Ripard
2020-04-01 12:14 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213200823.GA28336@kedthinkpad \
--to=andrey.lebedev@gmail.com \
--cc=airlied@linux.ie \
--cc=andrey@lebedev.lt \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime@cerno.tech \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.