All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [f2fs-dev] [PATCH 2/3] f2fs: add migration count iff migration happens
Date: Fri, 14 Feb 2020 10:58:54 -0800	[thread overview]
Message-ID: <20200214185855.217360-2-jaegeuk@kernel.org> (raw)
In-Reply-To: <20200214185855.217360-1-jaegeuk@kernel.org>

If first segment is empty and migration_granularity is 1, we can't move this
at all.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/gc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 65c0687ee2bb..bbf4db3f6bb4 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1233,12 +1233,12 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
 							segno, gc_type);
 
 		stat_inc_seg_count(sbi, type, gc_type);
+		migrated++;
 
 freed:
 		if (gc_type == FG_GC &&
 				get_valid_blocks(sbi, segno, false) == 0)
 			seg_freed++;
-		migrated++;
 
 		if (__is_large_section(sbi) && segno + 1 < end_segno)
 			sbi->next_victim_seg[gc_type] = segno + 1;
-- 
2.25.0.265.gbab2e86ba0-goog



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 2/3] f2fs: add migration count iff migration happens
Date: Fri, 14 Feb 2020 10:58:54 -0800	[thread overview]
Message-ID: <20200214185855.217360-2-jaegeuk@kernel.org> (raw)
In-Reply-To: <20200214185855.217360-1-jaegeuk@kernel.org>

If first segment is empty and migration_granularity is 1, we can't move this
at all.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/gc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 65c0687ee2bb..bbf4db3f6bb4 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1233,12 +1233,12 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
 							segno, gc_type);
 
 		stat_inc_seg_count(sbi, type, gc_type);
+		migrated++;
 
 freed:
 		if (gc_type == FG_GC &&
 				get_valid_blocks(sbi, segno, false) == 0)
 			seg_freed++;
-		migrated++;
 
 		if (__is_large_section(sbi) && segno + 1 < end_segno)
 			sbi->next_victim_seg[gc_type] = segno + 1;
-- 
2.25.0.265.gbab2e86ba0-goog


  reply	other threads:[~2020-02-14 18:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 18:58 [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full Jaegeuk Kim
2020-02-14 18:58 ` Jaegeuk Kim
2020-02-14 18:58 ` Jaegeuk Kim [this message]
2020-02-14 18:58   ` [PATCH 2/3] f2fs: add migration count iff migration happens Jaegeuk Kim
2020-02-17  1:41   ` [f2fs-dev] " Chao Yu
2020-02-17  1:41     ` Chao Yu
2020-02-17  1:43   ` Chao Yu
2020-02-17  1:43     ` Chao Yu
2020-02-14 18:58 ` [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called Jaegeuk Kim
2020-02-14 18:58   ` Jaegeuk Kim
2020-02-17  2:22   ` [f2fs-dev] " Chao Yu
2020-02-17  2:22     ` Chao Yu
2020-02-18 23:27     ` Jaegeuk Kim
2020-02-18 23:27       ` Jaegeuk Kim
2020-02-19  3:01       ` Chao Yu
2020-02-19  3:01         ` Chao Yu
2020-02-19  3:04         ` Jaegeuk Kim
2020-02-19  3:04           ` Jaegeuk Kim
2020-02-19  3:54           ` Chao Yu
2020-02-19  3:54             ` Chao Yu
2020-02-24 21:53             ` Jaegeuk Kim
2020-02-24 21:53               ` Jaegeuk Kim
2020-02-25  2:24               ` Chao Yu
2020-02-25  2:24                 ` Chao Yu
2020-02-17  1:40 ` [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full Chao Yu
2020-02-17  1:40   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214185855.217360-2-jaegeuk@kernel.org \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.