From: Andrew Lunn <andrew@lunn.ch>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Arun Parameswaran <arun.parameswaran@broadcom.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver
Date: Fri, 14 Feb 2020 22:50:37 +0100 [thread overview]
Message-ID: <20200214215037.GR31084@lunn.ch> (raw)
In-Reply-To: <20200214214746.10153-1-scott.branden@broadcom.com>
On Fri, Feb 14, 2020 at 01:47:46PM -0800, Scott Branden wrote:
> From: Arun Parameswaran <arun.parameswaran@broadcom.com>
>
> The mii management register in iproc mdio block
> does not have a retention register so it is lost on suspend.
> Save and restore value of register while resuming from suspend.
You actually just reconfigure, you don't save it. But that is minor.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Ray Jui <rjui@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Arun Parameswaran <arun.parameswaran@broadcom.com>
Subject: Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver
Date: Fri, 14 Feb 2020 22:50:37 +0100 [thread overview]
Message-ID: <20200214215037.GR31084@lunn.ch> (raw)
In-Reply-To: <20200214214746.10153-1-scott.branden@broadcom.com>
On Fri, Feb 14, 2020 at 01:47:46PM -0800, Scott Branden wrote:
> From: Arun Parameswaran <arun.parameswaran@broadcom.com>
>
> The mii management register in iproc mdio block
> does not have a retention register so it is lost on suspend.
> Save and restore value of register while resuming from suspend.
You actually just reconfigure, you don't save it. But that is minor.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-02-14 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 21:47 [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Scott Branden
2020-02-14 21:47 ` Scott Branden
2020-02-14 21:50 ` Andrew Lunn [this message]
2020-02-14 21:50 ` Andrew Lunn
2020-02-14 22:02 ` Florian Fainelli
2020-02-14 22:02 ` Florian Fainelli
2020-02-17 3:19 ` David Miller
2020-02-17 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214215037.GR31084@lunn.ch \
--to=andrew@lunn.ch \
--cc=arun.parameswaran@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.