From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com,
Linus Walleij <linus.walleij@linaro.org>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Paul Cercueil <paul@crapouillou.net>,
Neil Armstrong <narmstrong@baylibre.com>,
Heiko Stuebner <heiko@sntech.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Patrice Chotard <patrice.chotard@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Andy Gross <agross@kernel.org>,
linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-oxnas@groups.io, linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Fri, 14 Feb 2020 21:35:17 -0800 [thread overview]
Message-ID: <20200215053517.GN955802@ripper> (raw)
In-Reply-To: <20191112141819.GA22076@localhost.localdomain>
On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 763da0be10d6..8844ca1261d5 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
>
> val = msm_readl_ctl(pctrl, g);
>
> - /* 0 = output, 1 = input */
> - return val & BIT(g->oe_bit) ? 0 : 1;
> + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT :
> + GPIO_LINE_DIRECTION_IN;
For pinctrl-msm:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> }
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Neil Armstrong <narmstrong@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Paul Cercueil <paul@crapouillou.net>,
Eric Anholt <eric@anholt.net>,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@st.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-rockchip@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Andy Gross <agross@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-msm@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
mazziesaccount@gmail.com, Ray Jui <rjui@broadcom.com>,
linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Sean Wang <sean.wang@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Stefan Wahren <wahrenst@gmx.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-oxnas@groups.io
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Fri, 14 Feb 2020 21:35:17 -0800 [thread overview]
Message-ID: <20200215053517.GN955802@ripper> (raw)
In-Reply-To: <20191112141819.GA22076@localhost.localdomain>
On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 763da0be10d6..8844ca1261d5 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
>
> val = msm_readl_ctl(pctrl, g);
>
> - /* 0 = output, 1 = input */
> - return val & BIT(g->oe_bit) ? 0 : 1;
> + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT :
> + GPIO_LINE_DIRECTION_IN;
For pinctrl-msm:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> }
Regards,
Bjorn
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com,
Linus Walleij <linus.walleij@linaro.org>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Paul Cercueil <paul@crapouillou.net>,
Neil
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Fri, 14 Feb 2020 21:35:17 -0800 [thread overview]
Message-ID: <20200215053517.GN955802@ripper> (raw)
In-Reply-To: <20191112141819.GA22076@localhost.localdomain>
On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 763da0be10d6..8844ca1261d5 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
>
> val = msm_readl_ctl(pctrl, g);
>
> - /* 0 = output, 1 = input */
> - return val & BIT(g->oe_bit) ? 0 : 1;
> + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT :
> + GPIO_LINE_DIRECTION_IN;
For pinctrl-msm:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> }
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Neil Armstrong <narmstrong@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Paul Cercueil <paul@crapouillou.net>,
Eric Anholt <eric@anholt.net>,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@st.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-rockchip@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Andy Gross <agross@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-msm@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
mazziesaccount@gmail.com, Ray Jui <rjui@broadcom.com>,
linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Sean Wang <sean.wang@kernel.org>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Stefan Wahren <wahrenst@gmx.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-oxnas@groups.io
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Fri, 14 Feb 2020 21:35:17 -0800 [thread overview]
Message-ID: <20200215053517.GN955802@ripper> (raw)
In-Reply-To: <20191112141819.GA22076@localhost.localdomain>
On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 763da0be10d6..8844ca1261d5 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
>
> val = msm_readl_ctl(pctrl, g);
>
> - /* 0 = output, 1 = input */
> - return val & BIT(g->oe_bit) ? 0 : 1;
> + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT :
> + GPIO_LINE_DIRECTION_IN;
For pinctrl-msm:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> }
Regards,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-15 5:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:18 [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-12 14:18 ` Matti Vaittinen
2019-11-12 14:18 ` Matti Vaittinen
2019-11-12 14:18 ` Matti Vaittinen
2019-11-12 17:01 ` Bjorn Andersson
2019-11-12 17:01 ` Bjorn Andersson
2019-11-12 17:01 ` Bjorn Andersson
2019-11-12 17:01 ` Bjorn Andersson
2019-11-12 18:18 ` Geert Uytterhoeven
2019-11-12 18:18 ` Geert Uytterhoeven
2019-11-12 18:18 ` Geert Uytterhoeven
2019-11-12 18:18 ` Geert Uytterhoeven
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:52 ` Vaittinen, Matti
2019-11-13 6:52 ` Vaittinen, Matti
2019-11-13 6:52 ` Vaittinen, Matti
2019-11-13 9:40 ` Linus Walleij
2019-11-13 9:40 ` Linus Walleij
2019-11-13 9:40 ` Linus Walleij
2019-11-13 9:40 ` Linus Walleij
2019-11-13 9:53 ` Vaittinen, Matti
2019-11-13 9:53 ` Vaittinen, Matti
2019-11-13 9:53 ` Vaittinen, Matti
2019-11-13 10:06 ` Vaittinen, Matti
2019-11-13 10:06 ` Vaittinen, Matti
2019-11-13 10:06 ` Vaittinen, Matti
2019-11-13 17:18 ` Linus Walleij
2019-11-13 17:18 ` Linus Walleij
2019-11-13 17:18 ` Linus Walleij
2019-11-13 17:18 ` Linus Walleij
2020-02-14 11:14 ` Vaittinen, Matti
2020-02-14 11:14 ` Vaittinen, Matti
2020-02-14 11:14 ` Vaittinen, Matti
2020-02-14 13:59 ` Vaittinen, Matti
2019-11-13 8:53 ` Jacopo Mondi
2019-11-13 8:53 ` Jacopo Mondi
2019-11-13 8:53 ` Jacopo Mondi
2019-11-13 8:53 ` Jacopo Mondi
2020-02-15 5:35 ` Bjorn Andersson [this message]
2020-02-15 5:35 ` Bjorn Andersson
2020-02-15 5:35 ` Bjorn Andersson
2020-02-15 5:35 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215053517.GN955802@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@bootlin.com \
--cc=heiko@sntech.de \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=patrice.chotard@st.com \
--cc=paul@crapouillou.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sean.wang@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=wahrenst@gmx.net \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.