Re: [PATCH 1/1] clk: meson-g12a: missing break

[Lukasz Majewski <lukma@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

On Sat, 15 Feb 2020 21:10:54 +0100
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> Add missing break for CLKID_PCIE_PLL in switch statement.
> 
> Reported by CppCheck.
> 
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> Looking at the code it seems obvious that something is wrong in commit
> 08e09c263fdf but I have no board for testing.
> ---
> 
>  drivers/clk/meson/g12a.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 686d94ebfe..cada80e6b5 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk
> *clk, unsigned long id) break;
>  	case CLKID_PCIE_PLL:
>  		rate = meson_pcie_pll_get_rate(clk);
> +		break;
>  	case CLKID_VPU_0:
>  		rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
>  		break;
> --
> 2.25.0
> 

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]