* [PATCH 1/1] clk: meson-g12a: missing break
@ 2020-02-15 20:10 ` Heinrich Schuchardt
0 siblings, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2020-02-15 20:10 UTC (permalink / raw)
To: Lukasz Majewski
Cc: Neil Armstrong, u-boot-amlogic, u-boot, Heinrich Schuchardt
Add missing break for CLKID_PCIE_PLL in switch statement.
Reported by CppCheck.
Cc: Neil Armstrong <narmstrong@baylibre.com>
Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
Looking at the code it seems obvious that something is wrong in commit
08e09c263fdf but I have no board for testing.
---
drivers/clk/meson/g12a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 686d94ebfe..cada80e6b5 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk *clk, unsigned long id)
break;
case CLKID_PCIE_PLL:
rate = meson_pcie_pll_get_rate(clk);
+ break;
case CLKID_VPU_0:
rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
break;
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/1] clk: meson-g12a: missing break
@ 2020-02-15 20:10 ` Heinrich Schuchardt
0 siblings, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2020-02-15 20:10 UTC (permalink / raw)
To: u-boot
Add missing break for CLKID_PCIE_PLL in switch statement.
Reported by CppCheck.
Cc: Neil Armstrong <narmstrong@baylibre.com>
Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
Looking at the code it seems obvious that something is wrong in commit
08e09c263fdf but I have no board for testing.
---
drivers/clk/meson/g12a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 686d94ebfe..cada80e6b5 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk *clk, unsigned long id)
break;
case CLKID_PCIE_PLL:
rate = meson_pcie_pll_get_rate(clk);
+ break;
case CLKID_VPU_0:
rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
break;
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] clk: meson-g12a: missing break
2020-02-15 20:10 ` Heinrich Schuchardt
@ 2020-02-16 8:48 ` Lukasz Majewski
-1 siblings, 0 replies; 6+ messages in thread
From: Lukasz Majewski @ 2020-02-16 8:48 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Neil Armstrong, u-boot-amlogic, u-boot
[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]
On Sat, 15 Feb 2020 21:10:54 +0100
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Add missing break for CLKID_PCIE_PLL in switch statement.
>
> Reported by CppCheck.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> Looking at the code it seems obvious that something is wrong in commit
> 08e09c263fdf but I have no board for testing.
> ---
>
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 686d94ebfe..cada80e6b5 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk
> *clk, unsigned long id) break;
> case CLKID_PCIE_PLL:
> rate = meson_pcie_pll_get_rate(clk);
> + break;
> case CLKID_VPU_0:
> rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
> break;
> --
> 2.25.0
>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/1] clk: meson-g12a: missing break
@ 2020-02-16 8:48 ` Lukasz Majewski
0 siblings, 0 replies; 6+ messages in thread
From: Lukasz Majewski @ 2020-02-16 8:48 UTC (permalink / raw)
To: u-boot
On Sat, 15 Feb 2020 21:10:54 +0100
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Add missing break for CLKID_PCIE_PLL in switch statement.
>
> Reported by CppCheck.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> Looking at the code it seems obvious that something is wrong in commit
> 08e09c263fdf but I have no board for testing.
> ---
>
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 686d94ebfe..cada80e6b5 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk
> *clk, unsigned long id) break;
> case CLKID_PCIE_PLL:
> rate = meson_pcie_pll_get_rate(clk);
> + break;
> case CLKID_VPU_0:
> rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
> break;
> --
> 2.25.0
>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200216/824a41c3/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] clk: meson-g12a: missing break
2020-02-15 20:10 ` Heinrich Schuchardt
@ 2020-02-17 8:42 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-02-17 8:42 UTC (permalink / raw)
To: Heinrich Schuchardt, Lukasz Majewski; +Cc: u-boot-amlogic, u-boot
On 15/02/2020 21:10, Heinrich Schuchardt wrote:
> Add missing break for CLKID_PCIE_PLL in switch statement.
>
> Reported by CppCheck.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> Looking at the code it seems obvious that something is wrong in commit
> 08e09c263fdf but I have no board for testing.
> ---
>
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 686d94ebfe..cada80e6b5 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk *clk, unsigned long id)
> break;
> case CLKID_PCIE_PLL:
> rate = meson_pcie_pll_get_rate(clk);
> + break;
> case CLKID_VPU_0:
> rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
> break;
> --
> 2.25.0
>
Thanks,
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to u-boot-amlogic
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/1] clk: meson-g12a: missing break
@ 2020-02-17 8:42 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-02-17 8:42 UTC (permalink / raw)
To: u-boot
On 15/02/2020 21:10, Heinrich Schuchardt wrote:
> Add missing break for CLKID_PCIE_PLL in switch statement.
>
> Reported by CppCheck.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> Looking at the code it seems obvious that something is wrong in commit
> 08e09c263fdf but I have no board for testing.
> ---
>
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 686d94ebfe..cada80e6b5 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk *clk, unsigned long id)
> break;
> case CLKID_PCIE_PLL:
> rate = meson_pcie_pll_get_rate(clk);
> + break;
> case CLKID_VPU_0:
> rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
> break;
> --
> 2.25.0
>
Thanks,
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to u-boot-amlogic
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-17 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-15 20:10 [PATCH 1/1] clk: meson-g12a: missing break Heinrich Schuchardt
2020-02-15 20:10 ` Heinrich Schuchardt
2020-02-16 8:48 ` Lukasz Majewski
2020-02-16 8:48 ` Lukasz Majewski
2020-02-17 8:42 ` Neil Armstrong
2020-02-17 8:42 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.