All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: b-liu@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org,
	ludovic.desroches@microchip.com, mathias.nyman@intel.com,
	nicolas.ferre@microchip.com, slemieux.tyco@gmail.com,
	stern@rowland.harvard.edu, vz@mleia.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 04/20] usb: gadget: at91_udc: remove useless cast for driver.name
Date: Tue, 18 Feb 2020 20:40:24 +0100	[thread overview]
Message-ID: <20200218194024.GD3385@piout.net> (raw)
In-Reply-To: <1582054383-35760-5-git-send-email-clabbe@baylibre.com>

On 18/02/2020 19:32:47+0000, Corentin Labbe wrote:
> device_driver name is const char pointer, so it not useful to cast
> driver_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/usb/gadget/udc/at91_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index 1b2b548c59a0..eede5cedacb4 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -2021,7 +2021,7 @@ static struct platform_driver at91_udc_driver = {
>  	.suspend	= at91udc_suspend,
>  	.resume		= at91udc_resume,
>  	.driver		= {
> -		.name	= (char *) driver_name,
> +		.name	= driver_name,
>  		.of_match_table	= at91_udc_dt_ids,
>  	},
>  };
> -- 
> 2.24.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: balbi@kernel.org, linux-kernel@vger.kernel.org,
	mathias.nyman@intel.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, vz@mleia.com,
	ludovic.desroches@microchip.com, stern@rowland.harvard.edu,
	slemieux.tyco@gmail.com, b-liu@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/20] usb: gadget: at91_udc: remove useless cast for driver.name
Date: Tue, 18 Feb 2020 20:40:24 +0100	[thread overview]
Message-ID: <20200218194024.GD3385@piout.net> (raw)
In-Reply-To: <1582054383-35760-5-git-send-email-clabbe@baylibre.com>

On 18/02/2020 19:32:47+0000, Corentin Labbe wrote:
> device_driver name is const char pointer, so it not useful to cast
> driver_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/usb/gadget/udc/at91_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index 1b2b548c59a0..eede5cedacb4 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -2021,7 +2021,7 @@ static struct platform_driver at91_udc_driver = {
>  	.suspend	= at91udc_suspend,
>  	.resume		= at91udc_resume,
>  	.driver		= {
> -		.name	= (char *) driver_name,
> +		.name	= driver_name,
>  		.of_match_table	= at91_udc_dt_ids,
>  	},
>  };
> -- 
> 2.24.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-18 19:40 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 19:32 [PATCH 00/20] usb: remove useless cast for driver.name Corentin Labbe
2020-02-18 19:32 ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 01/20] usb: gadget: legacy: gmidi: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 02/20] usb: gadget: legacy: inode: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 03/20] usb: gadget: udc: amd5536udc_pci: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 04/20] usb: gadget: at91_udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:40   ` Alexandre Belloni [this message]
2020-02-18 19:40     ` Alexandre Belloni
2020-02-18 19:32 ` [PATCH 05/20] usb: gadget: dummy_hcd: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 06/20] usb: gadget: fotg210-udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 07/20] usb: gadget: fusb300_udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 08/20] usb: gadget: goku_udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 09/20] usb: gadget: lpc32xx_udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:41   ` Alexandre Belloni
2020-02-18 19:41     ` Alexandre Belloni
2020-02-18 19:32 ` [PATCH 10/20] usb: gadget: m66592-udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 11/20] usb: gadget: net2280: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 12/20] usb: gadget: omap_udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 13/20] usb: gadget: r8a66597-udc: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-19  0:43   ` Yoshihiro Shimoda
2020-02-19  0:43     ` Yoshihiro Shimoda
2020-02-18 19:32 ` [PATCH 14/20] usb: gadget: renesas_usb3: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-19  0:33   ` Yoshihiro Shimoda
2020-02-19  0:33     ` Yoshihiro Shimoda
2020-02-18 19:32 ` [PATCH 15/20] usb: host: ehci-pci: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:32 ` [PATCH 16/20] usb: host: ohci-pci: " Corentin Labbe
2020-02-18 19:32   ` Corentin Labbe
2020-02-18 19:33 ` [PATCH 17/20] usb: host: sl811-hcd: " Corentin Labbe
2020-02-18 19:33   ` Corentin Labbe
2020-02-18 19:33 ` [PATCH 18/20] usb: host: uhci-pci: " Corentin Labbe
2020-02-18 19:33   ` Corentin Labbe
2020-02-18 19:33 ` [PATCH 19/20] usb: host: xhci-pci: " Corentin Labbe
2020-02-18 19:33   ` Corentin Labbe
2020-02-18 19:33 ` [PATCH 20/20] usb: musb: core: " Corentin Labbe
2020-02-18 19:33   ` Corentin Labbe
2020-02-19  7:52 ` [PATCH 00/20] usb: " Johan Hovold
2020-02-19  7:52   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218194024.GD3385@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=b-liu@ti.com \
    --cc=balbi@kernel.org \
    --cc=clabbe@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mathias.nyman@intel.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=slemieux.tyco@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.