Re: [PATCH 09/20] usb: gadget: lpc32xx_udc: remove useless cast for driver.name

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: b-liu@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org,
	ludovic.desroches@microchip.com, mathias.nyman@intel.com,
	nicolas.ferre@microchip.com, slemieux.tyco@gmail.com,
	stern@rowland.harvard.edu, vz@mleia.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 09/20] usb: gadget: lpc32xx_udc: remove useless cast for driver.name
Date: Tue, 18 Feb 2020 20:41:02 +0100	[thread overview]
Message-ID: <20200218194102.GE3385@piout.net> (raw)
In-Reply-To: <1582054383-35760-10-git-send-email-clabbe@baylibre.com>

On 18/02/2020 19:32:52+0000, Corentin Labbe wrote:
> device_driver name is const char pointer, so it not useful to cast
> driver_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
> index d14b2bb3f67c..cb997b82c008 100644
> --- a/drivers/usb/gadget/udc/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
> @@ -3267,7 +3267,7 @@ static struct platform_driver lpc32xx_udc_driver = {
>  	.suspend	= lpc32xx_udc_suspend,
>  	.resume		= lpc32xx_udc_resume,
>  	.driver		= {
> -		.name	= (char *) driver_name,
> +		.name	= driver_name,
>  		.of_match_table = of_match_ptr(lpc32xx_udc_of_match),
>  	},
>  };
> -- 
> 2.24.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com