[meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Andrew F. Davis]

The UM doesn't work too well without the KM side, add this dependency.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
index 129d5cee..d4bc0232 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -28,7 +28,7 @@ inherit update-rc.d
 PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
 
 DEPENDS += "libdrm udev wayland wayland-protocols libffi expat"
-RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat"
+RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat ti-sgx-ddk-km"
 
 RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
 RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
-- 
2.17.1

Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Denys Dmytriyenko]

I was sitting on a similar patch in a private testing branch:
https://lists.yoctoproject.org/g/meta-ti/message/12418


On Tue, Feb 18, 2020 at 11:06:21AM -0500, Andrew F. Davis wrote:
> The UM doesn't work too well without the KM side, add this dependency.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index 129d5cee..d4bc0232 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -28,7 +28,7 @@ inherit update-rc.d
>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
>  
>  DEPENDS += "libdrm udev wayland wayland-protocols libffi expat"
> -RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat"
> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat ti-sgx-ddk-km"
>  
>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> -- 
> 2.17.1
> 

Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Andrew F. Davis]

On 2/18/20 12:52 PM, Denys Dmytriyenko wrote:
> I was sitting on a similar patch in a private testing branch:
> https://lists.yoctoproject.org/g/meta-ti/message/12418
> 


Why RRECOMMENDS? It should be a real dependency right?

Andrew


> 
> On Tue, Feb 18, 2020 at 11:06:21AM -0500, Andrew F. Davis wrote:
>> The UM doesn't work too well without the KM side, add this dependency.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>> index 129d5cee..d4bc0232 100644
>> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>> @@ -28,7 +28,7 @@ inherit update-rc.d
>>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
>>  
>>  DEPENDS += "libdrm udev wayland wayland-protocols libffi expat"
>> -RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat"
>> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat ti-sgx-ddk-km"
>>  
>>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
>>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
>> -- 
>> 2.17.1
>>

Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Denys Dmytriyenko]

On Tue, Feb 18, 2020 at 01:08:46PM -0500, Andrew F. Davis wrote:
> On 2/18/20 12:52 PM, Denys Dmytriyenko wrote:
> > I was sitting on a similar patch in a private testing branch:
> > https://lists.yoctoproject.org/g/meta-ti/message/12418
> 
> Why RRECOMMENDS? It should be a real dependency right?

Andrew,

Historically kernel modules used RRECOMMENDS.

Plus, it's easier to break RRECOMMENDS dependency than RDEPENDS. And we had 
instances in the past, when we needed to be able to build against UM libs, 
even when KM support is not there. Of course, it may not be an issue in the 
future, when we split up UM libs package into individual libs and/or move to 
Mesa based builds...

-- 
Denys


> > On Tue, Feb 18, 2020 at 11:06:21AM -0500, Andrew F. Davis wrote:
> >> The UM doesn't work too well without the KM side, add this dependency.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> ---
> >>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> index 129d5cee..d4bc0232 100644
> >> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> @@ -28,7 +28,7 @@ inherit update-rc.d
> >>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
> >>  
> >>  DEPENDS += "libdrm udev wayland wayland-protocols libffi expat"
> >> -RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat"
> >> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat ti-sgx-ddk-km"
> >>  
> >>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
> >>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> >> -- 
> >> 2.17.1
> >>

Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Andrew F. Davis]

On 2/19/20 6:58 PM, Denys Dmytriyenko wrote:
> On Tue, Feb 18, 2020 at 01:08:46PM -0500, Andrew F. Davis wrote:
>> On 2/18/20 12:52 PM, Denys Dmytriyenko wrote:
>>> I was sitting on a similar patch in a private testing branch:
>>> https://lists.yoctoproject.org/g/meta-ti/message/12418
>>
>> Why RRECOMMENDS? It should be a real dependency right?
> 
> Andrew,
> 
> Historically kernel modules used RRECOMMENDS.
> 
> Plus, it's easier to break RRECOMMENDS dependency than RDEPENDS. And we had 
> instances in the past, when we needed to be able to build against UM libs, 
> even when KM support is not there. Of course, it may not be an issue in the 
> future, when we split up UM libs package into individual libs and/or move to 
> Mesa based builds...
> 

Okay then, either way works for me, I'm just looking to get the
dependency tree in order so we don't have to explicitly include the
"gpudriver" anymore. It should be pulled in by any app using 3D.

Andrew

Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Denys Dmytriyenko]

On Wed, Feb 19, 2020 at 07:06:29PM -0500, Andrew F. Davis wrote:
> On 2/19/20 6:58 PM, Denys Dmytriyenko wrote:
> > On Tue, Feb 18, 2020 at 01:08:46PM -0500, Andrew F. Davis wrote:
> >> On 2/18/20 12:52 PM, Denys Dmytriyenko wrote:
> >>> I was sitting on a similar patch in a private testing branch:
> >>> https://lists.yoctoproject.org/g/meta-ti/message/12418
> >>
> >> Why RRECOMMENDS? It should be a real dependency right?
> > 
> > Andrew,
> > 
> > Historically kernel modules used RRECOMMENDS.
> > 
> > Plus, it's easier to break RRECOMMENDS dependency than RDEPENDS. And we had 
> > instances in the past, when we needed to be able to build against UM libs, 
> > even when KM support is not there. Of course, it may not be an issue in the 
> > future, when we split up UM libs package into individual libs and/or move to 
> > Mesa based builds...
> > 
> 
> Okay then, either way works for me, I'm just looking to get the
> dependency tree in order so we don't have to explicitly include the
> "gpudriver" anymore. It should be pulled in by any app using 3D.

Oh, I totally agree! BTW, I've been starting to look into dependency cleanup 
as part of that parallel private work I mentioned - the patch I linked is from 
that series. I'm hoping to be able to merge everything in the near future, as 
it's diverging quite rapidly, since it was based on Thud for few months...

-- 
Denys

Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module

[Andrew F. Davis]

On 2/19/20 7:15 PM, Denys Dmytriyenko wrote:
> On Wed, Feb 19, 2020 at 07:06:29PM -0500, Andrew F. Davis wrote:
>> On 2/19/20 6:58 PM, Denys Dmytriyenko wrote:
>>> On Tue, Feb 18, 2020 at 01:08:46PM -0500, Andrew F. Davis wrote:
>>>> On 2/18/20 12:52 PM, Denys Dmytriyenko wrote:
>>>>> I was sitting on a similar patch in a private testing branch:
>>>>> https://lists.yoctoproject.org/g/meta-ti/message/12418
>>>>
>>>> Why RRECOMMENDS? It should be a real dependency right?
>>>
>>> Andrew,
>>>
>>> Historically kernel modules used RRECOMMENDS.
>>>
>>> Plus, it's easier to break RRECOMMENDS dependency than RDEPENDS. And we had 
>>> instances in the past, when we needed to be able to build against UM libs, 
>>> even when KM support is not there. Of course, it may not be an issue in the 
>>> future, when we split up UM libs package into individual libs and/or move to 
>>> Mesa based builds...
>>>
>>
>> Okay then, either way works for me, I'm just looking to get the
>> dependency tree in order so we don't have to explicitly include the
>> "gpudriver" anymore. It should be pulled in by any app using 3D.
> 
> Oh, I totally agree! BTW, I've been starting to look into dependency cleanup 
> as part of that parallel private work I mentioned - the patch I linked is from 
> that series. I'm hoping to be able to merge everything in the near future, as 
> it's diverging quite rapidly, since it was based on Thud for few months...
> 

:) I've got the same problem, patches building up on thud that need a
path into zeus/master.

Idea for above being if you include a 3D app in your image you get the
km via

app -> egl/gles2 -> ti-sgx-um -> ti-sgx-km

if no apps need 3D, then we don't pull in any of that extra stuff. Got
the same for gtk3 and webkit.. Should shave a couple hours of the
default (non-tisdk) build of Arago.

Will post some more tomorrow.

Andrew