From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control
Date: Thu, 20 Feb 2020 18:45:07 +0000 [thread overview]
Message-ID: <20200220184507.GF3926@sirena.org.uk> (raw)
In-Reply-To: <20200220172721.10547-1-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Thu, Feb 20, 2020 at 11:27:21AM -0600, Dan Murphy wrote:
> + /* Set the Digital volume to -110dB */
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, 0x00);
> + if (ret)
> + return ret;
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG3, 0x00);
> + if (ret)
> + return ret;
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG2, 0x0d);
> + if (ret)
> + return ret;
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG1, 0x43);
> + if (ret)
> + return ret;
Is there a reason not to use the chip default here? Otherwise this
looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control
Date: Thu, 20 Feb 2020 18:45:07 +0000 [thread overview]
Message-ID: <20200220184507.GF3926@sirena.org.uk> (raw)
In-Reply-To: <20200220172721.10547-1-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Thu, Feb 20, 2020 at 11:27:21AM -0600, Dan Murphy wrote:
> + /* Set the Digital volume to -110dB */
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, 0x00);
> + if (ret)
> + return ret;
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG3, 0x00);
> + if (ret)
> + return ret;
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG2, 0x0d);
> + if (ret)
> + return ret;
> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG1, 0x43);
> + if (ret)
> + return ret;
Is there a reason not to use the chip default here? Otherwise this
looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-20 18:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:27 [PATCH] ASoC: tas2562: Add support for digital volume control Dan Murphy
2020-02-20 17:27 ` Dan Murphy
2020-02-20 18:45 ` Mark Brown [this message]
2020-02-20 18:45 ` Mark Brown
2020-02-20 18:46 ` Dan Murphy
2020-02-20 18:46 ` Dan Murphy
2020-02-20 19:18 ` Mark Brown
2020-02-20 19:18 ` Mark Brown
2020-02-20 19:22 ` Dan Murphy
2020-02-20 19:22 ` Dan Murphy
2020-02-20 19:40 ` Mark Brown
2020-02-20 19:40 ` Mark Brown
2020-02-20 19:52 ` Dan Murphy
2020-02-20 19:52 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220184507.GF3926@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.