* [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal
@ 2020-02-21 14:04 ` Torsten Duwe
0 siblings, 0 replies; 8+ messages in thread
From: Torsten Duwe @ 2020-02-21 14:04 UTC (permalink / raw)
To: Vasily Khoruzhick, Thierry Reding, Daniel Vetter, Thierry Reding
Cc: Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong,
linux-kernel, dri-devel, Andrzej Hajda, Sean Paul,
Laurent Pinchart, Thomas Zimmermann, Maxime Ripard
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
Signed-off-by: Torsten Duwe <duwe@suse.de>
---
https://patchwork.freedesktop.org/patch/343004/
https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html
Can someone please review this? It's equivalent to commit
3e138a63d6674a4567a018a31 which just made it into drm-tip.
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345)
if (err)
return err;
- dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd);
- dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]);
err = regmap_write(anx6345->map[I2C_IDX_DPTX],
- SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]);
+ SP_DP_MAIN_LINK_BW_SET_REG,
+ anx6345->dpcd[DP_MAX_LINK_RATE]);
if (err)
return err;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal @ 2020-02-21 14:04 ` Torsten Duwe 0 siblings, 0 replies; 8+ messages in thread From: Torsten Duwe @ 2020-02-21 14:04 UTC (permalink / raw) To: Vasily Khoruzhick, Thierry Reding, Daniel Vetter, Thierry Reding Cc: Maarten Lankhorst, Sean Paul, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Thomas Zimmermann, Maxime Ripard, dri-devel, linux-kernel drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] and the multiply+divide alltogether. fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") Signed-off-by: Torsten Duwe <duwe@suse.de> --- https://patchwork.freedesktop.org/patch/343004/ https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html Can someone please review this? It's equivalent to commit 3e138a63d6674a4567a018a31 which just made it into drm-tip. --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c @@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345) if (err) return err; - dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd); - dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]); err = regmap_write(anx6345->map[I2C_IDX_DPTX], - SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]); + SP_DP_MAIN_LINK_BW_SET_REG, + anx6345->dpcd[DP_MAX_LINK_RATE]); if (err) return err; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal 2020-02-21 14:04 ` Torsten Duwe @ 2020-02-21 14:39 ` Thomas Zimmermann -1 siblings, 0 replies; 8+ messages in thread From: Thomas Zimmermann @ 2020-02-21 14:39 UTC (permalink / raw) To: Torsten Duwe, Vasily Khoruzhick, Thierry Reding, Daniel Vetter, Thierry Reding Cc: Jernej Skrabec, Neil Armstrong, David Airlie, Jonas Karlman, linux-kernel, dri-devel, Andrzej Hajda, Sean Paul, Laurent Pinchart, Maxime Ripard [-- Attachment #1.1.1: Type: text/plain, Size: 2342 bytes --] Hi Torsten Am 21.02.20 um 15:04 schrieb Torsten Duwe: > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > and the multiply+divide alltogether. > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") You have to create the fixes tag and related cc tags with 'dim fixes', available at [1]. For this patch, the output is Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") Cc: Torsten Duwe <duwe@suse.de> Cc: Maxime Ripard <maxime@cerno.tech> Cc: Torsten Duwe <duwe@lst.de> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Icenowy Zheng <icenowy@aosc.io> Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Torsten Duwe <duwe@suse.de> You signed off with your SUSE email address, but sent the mail from lst.de. I don't know if it's strictly not allowed, but that's at least confusing to the tools. Best regards Thomas [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ > --- > https://patchwork.freedesktop.org/patch/343004/ > https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html > > Can someone please review this? It's equivalent to commit > 3e138a63d6674a4567a018a31 which just made it into drm-tip. > > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345) > if (err) > return err; > > - dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd); > - dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]); > err = regmap_write(anx6345->map[I2C_IDX_DPTX], > - SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]); > + SP_DP_MAIN_LINK_BW_SET_REG, > + anx6345->dpcd[DP_MAX_LINK_RATE]); > if (err) > return err; > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal @ 2020-02-21 14:39 ` Thomas Zimmermann 0 siblings, 0 replies; 8+ messages in thread From: Thomas Zimmermann @ 2020-02-21 14:39 UTC (permalink / raw) To: Torsten Duwe, Vasily Khoruzhick, Thierry Reding, Daniel Vetter, Thierry Reding Cc: Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel, dri-devel, Andrzej Hajda, Sean Paul, Laurent Pinchart, Maxime Ripard [-- Attachment #1.1: Type: text/plain, Size: 2342 bytes --] Hi Torsten Am 21.02.20 um 15:04 schrieb Torsten Duwe: > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > and the multiply+divide alltogether. > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") You have to create the fixes tag and related cc tags with 'dim fixes', available at [1]. For this patch, the output is Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") Cc: Torsten Duwe <duwe@suse.de> Cc: Maxime Ripard <maxime@cerno.tech> Cc: Torsten Duwe <duwe@lst.de> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Icenowy Zheng <icenowy@aosc.io> Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Torsten Duwe <duwe@suse.de> You signed off with your SUSE email address, but sent the mail from lst.de. I don't know if it's strictly not allowed, but that's at least confusing to the tools. Best regards Thomas [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ > --- > https://patchwork.freedesktop.org/patch/343004/ > https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html > > Can someone please review this? It's equivalent to commit > 3e138a63d6674a4567a018a31 which just made it into drm-tip. > > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345) > if (err) > return err; > > - dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd); > - dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]); > err = regmap_write(anx6345->map[I2C_IDX_DPTX], > - SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]); > + SP_DP_MAIN_LINK_BW_SET_REG, > + anx6345->dpcd[DP_MAX_LINK_RATE]); > if (err) > return err; > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal 2020-02-21 14:39 ` Thomas Zimmermann @ 2020-02-21 15:01 ` Torsten Duwe -1 siblings, 0 replies; 8+ messages in thread From: Torsten Duwe @ 2020-02-21 15:01 UTC (permalink / raw) To: Thomas Zimmermann Cc: Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel, dri-devel, Vasily Khoruzhick, Andrzej Hajda, Thierry Reding, Sean Paul, Laurent Pinchart, Thierry Reding, Maxime Ripard On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > Hi Torsten > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > and the multiply+divide alltogether. > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > You have to create the fixes tag and related cc tags with 'dim fixes', > available at [1]. For this patch, the output is > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > Cc: Torsten Duwe <duwe@suse.de> > Cc: Maxime Ripard <maxime@cerno.tech> > Cc: Torsten Duwe <duwe@lst.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Icenowy Zheng <icenowy@aosc.io> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> Ah, neat. > > Signed-off-by: Torsten Duwe <duwe@suse.de> > > You signed off with your SUSE email address, but sent the mail from > lst.de. I don't know if it's strictly not allowed, but that's at least > confusing to the tools. From my understanding, it is legally correct. The work is owned by Suse, so I have to sign off as an employee, but I'm subscribed with the LST address, and I'd also like to see all replies there. > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ I'll send an appropriate v2 once I get a review for it. Thanks! Torsten _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal @ 2020-02-21 15:01 ` Torsten Duwe 0 siblings, 0 replies; 8+ messages in thread From: Torsten Duwe @ 2020-02-21 15:01 UTC (permalink / raw) To: Thomas Zimmermann Cc: Vasily Khoruzhick, Thierry Reding, Daniel Vetter, Thierry Reding, Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel, dri-devel, Andrzej Hajda, Sean Paul, Laurent Pinchart, Maxime Ripard On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > Hi Torsten > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > and the multiply+divide alltogether. > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > You have to create the fixes tag and related cc tags with 'dim fixes', > available at [1]. For this patch, the output is > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > Cc: Torsten Duwe <duwe@suse.de> > Cc: Maxime Ripard <maxime@cerno.tech> > Cc: Torsten Duwe <duwe@lst.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Icenowy Zheng <icenowy@aosc.io> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> Ah, neat. > > Signed-off-by: Torsten Duwe <duwe@suse.de> > > You signed off with your SUSE email address, but sent the mail from > lst.de. I don't know if it's strictly not allowed, but that's at least > confusing to the tools. From my understanding, it is legally correct. The work is owned by Suse, so I have to sign off as an employee, but I'm subscribed with the LST address, and I'd also like to see all replies there. > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ I'll send an appropriate v2 once I get a review for it. Thanks! Torsten ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal 2020-02-21 15:01 ` Torsten Duwe @ 2020-02-21 15:05 ` Laurent Pinchart -1 siblings, 0 replies; 8+ messages in thread From: Laurent Pinchart @ 2020-02-21 15:05 UTC (permalink / raw) To: Torsten Duwe Cc: Jernej Skrabec, Thomas Zimmermann, Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel, dri-devel, Vasily Khoruzhick, Andrzej Hajda, Thierry Reding, Sean Paul, Maxime Ripard, Thierry Reding Hi Torsten, On Fri, Feb 21, 2020 at 04:01:17PM +0100, Torsten Duwe wrote: > On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > > and the multiply+divide alltogether. > > > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > > > You have to create the fixes tag and related cc tags with 'dim fixes', > > available at [1]. For this patch, the output is > > > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > > Cc: Torsten Duwe <duwe@suse.de> > > Cc: Maxime Ripard <maxime@cerno.tech> > > Cc: Torsten Duwe <duwe@lst.de> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: Icenowy Zheng <icenowy@aosc.io> > > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > > Ah, neat. > > > > Signed-off-by: Torsten Duwe <duwe@suse.de> > > > > You signed off with your SUSE email address, but sent the mail from > > lst.de. I don't know if it's strictly not allowed, but that's at least > > confusing to the tools. > > From my understanding, it is legally correct. The work is owned by Suse, > so I have to sign off as an employee, but I'm subscribed with the LST > address, and I'd also like to see all replies there. That's fine, but then the mail body should start with a From: line that matches the address used in Signed-off-by. git-send-email should generate that automatically. > > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ > > I'll send an appropriate v2 once I get a review for it. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal @ 2020-02-21 15:05 ` Laurent Pinchart 0 siblings, 0 replies; 8+ messages in thread From: Laurent Pinchart @ 2020-02-21 15:05 UTC (permalink / raw) To: Torsten Duwe Cc: Thomas Zimmermann, Vasily Khoruzhick, Thierry Reding, Daniel Vetter, Thierry Reding, Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel, dri-devel, Andrzej Hajda, Sean Paul, Maxime Ripard Hi Torsten, On Fri, Feb 21, 2020 at 04:01:17PM +0100, Torsten Duwe wrote: > On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > > and the multiply+divide alltogether. > > > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > > > You have to create the fixes tag and related cc tags with 'dim fixes', > > available at [1]. For this patch, the output is > > > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > > Cc: Torsten Duwe <duwe@suse.de> > > Cc: Maxime Ripard <maxime@cerno.tech> > > Cc: Torsten Duwe <duwe@lst.de> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: Icenowy Zheng <icenowy@aosc.io> > > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > > Ah, neat. > > > > Signed-off-by: Torsten Duwe <duwe@suse.de> > > > > You signed off with your SUSE email address, but sent the mail from > > lst.de. I don't know if it's strictly not allowed, but that's at least > > confusing to the tools. > > From my understanding, it is legally correct. The work is owned by Suse, > so I have to sign off as an employee, but I'm subscribed with the LST > address, and I'd also like to see all replies there. That's fine, but then the mail body should start with a From: line that matches the address used in Signed-off-by. git-send-email should generate that automatically. > > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ > > I'll send an appropriate v2 once I get a review for it. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-21 15:05 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-21 14:04 [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal Torsten Duwe 2020-02-21 14:04 ` Torsten Duwe 2020-02-21 14:39 ` Thomas Zimmermann 2020-02-21 14:39 ` Thomas Zimmermann 2020-02-21 15:01 ` Torsten Duwe 2020-02-21 15:01 ` Torsten Duwe 2020-02-21 15:05 ` Laurent Pinchart 2020-02-21 15:05 ` Laurent Pinchart
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.